Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: Documentation, QueryMaster
    • Labels:
      None

      Description

      Visualizing tajo's state machine will help us design each stage of tajo more conveniently. Yarn has tool for this purpose, we just need to borrow that.

      1. visualize.diff
        5 kB
        Min Zhou
      2. tajo.png
        233 kB
        Min Zhou

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-trunk-postcommit #559 (See https://builds.apache.org/job/Tajo-trunk-postcommit/559/)
          TAJO-320: Visualize Tajo statemachine. (Min Zhou via hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=a7399577a72319982fd4ad197b792f1db88bf472)

          • CHANGES.txt
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Query.java
          • tajo-dist/pom.xml
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryUnit.java
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryUnitAttempt.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-trunk-postcommit #559 (See https://builds.apache.org/job/Tajo-trunk-postcommit/559/ ) TAJO-320 : Visualize Tajo statemachine. (Min Zhou via hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=a7399577a72319982fd4ad197b792f1db88bf472 ) CHANGES.txt tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Query.java tajo-dist/pom.xml tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryUnit.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryUnitAttempt.java
          Hide
          hyunsik Hyunsik Choi added a comment -

          I missed the two above comments because I didn't update the jira page for a while. Nevertheless, I already checked the change of modifiers. That does not affect the whole logic in the current implementation.

          Show
          hyunsik Hyunsik Choi added a comment - I missed the two above comments because I didn't update the jira page for a while. Nevertheless, I already checked the change of modifiers. That does not affect the whole logic in the current implementation.
          Hide
          hyunsik Hyunsik Choi added a comment -

          Committed it to master branch. Thank you for your contribution!

          Show
          hyunsik Hyunsik Choi added a comment - Committed it to master branch. Thank you for your contribution!
          Hide
          coderplay Min Zhou added a comment -

          Please pay attention that the patch has changed a member field of SubQuery into a static one. I don't know why you guys declare it as a member. Please make a judgement if that change will impact the whole logic or not.
          Thanks, Min

          Show
          coderplay Min Zhou added a comment - Please pay attention that the patch has changed a member field of SubQuery into a static one. I don't know why you guys declare it as a member. Please make a judgement if that change will impact the whole logic or not. Thanks, Min
          Hide
          jihoonson Jihoon Son added a comment -

          1+ for this issue.
          The attached figure is awesome.

          Show
          jihoonson Jihoon Son added a comment - 1+ for this issue. The attached figure is awesome.
          Hide
          hyunsik Hyunsik Choi added a comment -

          +1
          Good job! I'll add these diagrams to some internal documents.

          Show
          hyunsik Hyunsik Choi added a comment - +1 Good job! I'll add these diagrams to some internal documents.
          Hide
          coderplay Min Zhou added a comment -

          Attached a patch. Run the below script to generate a png for tajo state machines

          $mvn -Pvisualize compile
          $dot -Tpng Tajo.gv -o tajo.png
          
          Show
          coderplay Min Zhou added a comment - Attached a patch. Run the below script to generate a png for tajo state machines $mvn -Pvisualize compile $dot -Tpng Tajo.gv -o tajo.png
          Hide
          coderplay Min Zhou added a comment - - edited

          I'll upload the patch soon, need some modify at Query/SubQuery/QueryUnit/QueryUnitAttempt because that tool couldn't access private fields.

          Show
          coderplay Min Zhou added a comment - - edited I'll upload the patch soon, need some modify at Query/SubQuery/QueryUnit/QueryUnitAttempt because that tool couldn't access private fields.
          Hide
          coderplay Min Zhou added a comment -

          This is the result picture.

          Show
          coderplay Min Zhou added a comment - This is the result picture.

            People

            • Assignee:
              coderplay Min Zhou
              Reporter:
              coderplay Min Zhou
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development