Tajo
  1. Tajo
  2. TAJO-286

Refactor TableDesc, TableMeta, and Fragment

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8
    • Component/s: catalog
    • Labels:
      None

      Description

      In the current implementation, TableDesc and TableMeta are implemented through interface and its implementation. This is unnecessary abstraction. For simplicity, this patch removes interfaces and merge them into the concrete classes.

      In addition, TableDesc and TableMeta's role is ambiguous. This patch clarifies their roles as follows:

      • TableMeta contains usual physical information which is used in workers.
      • TableDesc contains logical information about a table and others which are not used in workers.

      As a result, I've moved TableStats and Schema from TableMeta to TableDesc.

      Besides, in the current implementation, Fragment also is subclassed of TableDesc. But, this relationship is wrong. Fragment is independent one of TableDesc. This patch changes this relationship. They are independent ones.

      1. PATCH-286.patch
        366 kB
        Hyunsik Choi

        Activity

        Hyunsik Choi made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Hyunsik Choi added a comment -

        Thank you for the review. As you mentioned, I've modified the commented out tests in TestFragment.

        Show
        Hyunsik Choi added a comment - Thank you for the review. As you mentioned, I've modified the commented out tests in TestFragment.
        Hide
        Jihoon Son added a comment -

        +1 for the patch.
        Please remove some commented tests in TestFragment before you submit.

        Show
        Jihoon Son added a comment - +1 for the patch. Please remove some commented tests in TestFragment before you submit.
        Hide
        Jihoon Son added a comment -

        +1 for this issue.
        I'll review the patch at tonight.

        Show
        Jihoon Son added a comment - +1 for this issue. I'll review the patch at tonight.
        Hyunsik Choi made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hyunsik Choi made changes -
        Field Original Value New Value
        Attachment PATCH-286.patch [ 12610440 ]
        Hyunsik Choi created issue -

          People

          • Assignee:
            Hyunsik Choi
            Reporter:
            Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development