Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-270

Boolean datum compatible to apache hive

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.2-incubating
    • Fix Version/s: 0.2-incubating, 0.8.0
    • Component/s: None
    • Labels:
      None

      Description

      In the current implementation, boolean datum is not compatible to apache hive.

      • sample data
        1
        t
        true
        
      • Hive CLI
        hive> select * from bool_test;
        OK
        NULL
        NULL
        true
        

        Issue Links

          Activity

          Hide
          jhkim Jinho Kim added a comment -

          I've changed text comparison to use first byte instead of 'equals'
          and the boolean text is written as 'true' or 'false'

          Show
          jhkim Jinho Kim added a comment - I've changed text comparison to use first byte instead of 'equals' and the boolean text is written as 'true' or 'false'
          Hide
          hyunsik Hyunsik Choi added a comment -

          The patch looks great for me. I've verified 'mvn clean install'.

          Show
          hyunsik Hyunsik Choi added a comment - The patch looks great for me. I've verified 'mvn clean install'.
          Hide
          hyunsik Hyunsik Choi added a comment -

          +1

          I forgot to throw +1.

          Show
          hyunsik Hyunsik Choi added a comment - +1 I forgot to throw +1.
          Hide
          jhkim Jinho Kim added a comment -

          Committed to master and branch-0.2.

          Show
          jhkim Jinho Kim added a comment - Committed to master and branch-0.2.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-trunk-postcommit #530 (See https://builds.apache.org/job/Tajo-trunk-postcommit/530/)
          TAJO-270: Boolean datum compatible to apache hive. (jinho) (jinossy: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=85cff2e7101e6e059285a80268ba2d8aaaca00ec)

          • tajo-common/src/main/java/org/apache/tajo/datum/DatumFactory.java
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java
          • tajo-common/src/main/java/org/apache/tajo/datum/BooleanDatum.java
          • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/LazyTuple.java
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Query.java
          • CHANGES.txt
          • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/CSVFile.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-trunk-postcommit #530 (See https://builds.apache.org/job/Tajo-trunk-postcommit/530/ ) TAJO-270 : Boolean datum compatible to apache hive. (jinho) (jinossy: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=85cff2e7101e6e059285a80268ba2d8aaaca00ec ) tajo-common/src/main/java/org/apache/tajo/datum/DatumFactory.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java tajo-common/src/main/java/org/apache/tajo/datum/BooleanDatum.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/LazyTuple.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Query.java CHANGES.txt tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/CSVFile.java

            People

            • Assignee:
              jhkim Jinho Kim
              Reporter:
              jhkim Jinho Kim
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development