Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-2145

Error codes based on errno.h need prefix

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.11.2
    • Fix Version/s: 0.12.0, 0.11.3
    • Component/s: RPC
    • Labels:
      None

      Description

      Some error codes in errors.proto which are based on C standard library errno.h can be conflicted if it is used in C/C++ client.

      So, it needs to be changed by such as adding prefix.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user eminency opened a pull request:

        https://github.com/apache/tajo/pull/1014

        TAJO-2145: Error codes based on errno.h need prefix

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/eminency/tajo TAJO-2145

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/1014.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #1014


        commit dd1e36aa86b2ef4655f0157b6dba04d330e7a586
        Author: Jongyoung Park <eminency@gmail.com>
        Date: 2016-05-10T06:56:55Z

        Prefix 'CERR_' is added to some error codes


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user eminency opened a pull request: https://github.com/apache/tajo/pull/1014 TAJO-2145 : Error codes based on errno.h need prefix You can merge this pull request into a Git repository by running: $ git pull https://github.com/eminency/tajo TAJO-2145 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/1014.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1014 commit dd1e36aa86b2ef4655f0157b6dba04d330e7a586 Author: Jongyoung Park <eminency@gmail.com> Date: 2016-05-10T06:56:55Z Prefix 'CERR_' is added to some error codes
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/1014#issuecomment-218089411

        How about the prefix 'SYS'? Actually, those error codes were designed to indicate system call errors.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/1014#issuecomment-218089411 How about the prefix 'SYS'? Actually, those error codes were designed to indicate system call errors.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/1014#issuecomment-218095322

        +1 LGTM!

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/1014#issuecomment-218095322 +1 LGTM!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/1014

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/1014
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed.

        Show
        hyunsik Hyunsik Choi added a comment - committed.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #723 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/723/)
        TAJO-2145: Error codes based on errno.h need prefix. (hyunsik: rev 9da3e0d26ed13b1ab89897c3ba36b0bc199c0028)

        • CHANGES
        • tajo-common/src/main/proto/errors.proto
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #723 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/723/ ) TAJO-2145 : Error codes based on errno.h need prefix. (hyunsik: rev 9da3e0d26ed13b1ab89897c3ba36b0bc199c0028) CHANGES tajo-common/src/main/proto/errors.proto
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-build #1144 (See https://builds.apache.org/job/Tajo-master-build/1144/)
        TAJO-2145: Error codes based on errno.h need prefix. (hyunsik: rev 9da3e0d26ed13b1ab89897c3ba36b0bc199c0028)

        • CHANGES
        • tajo-common/src/main/proto/errors.proto
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-build #1144 (See https://builds.apache.org/job/Tajo-master-build/1144/ ) TAJO-2145 : Error codes based on errno.h need prefix. (hyunsik: rev 9da3e0d26ed13b1ab89897c3ba36b0bc199c0028) CHANGES tajo-common/src/main/proto/errors.proto

          People

          • Assignee:
            eminency Jongyoung Park
            Reporter:
            eminency Jongyoung Park
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development