Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-2143

Fix race condition in task history writer

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.10.0
    • Fix Version/s: 0.12.0, 0.11.3
    • Component/s: Worker
    • Labels:
      None

      Description

      If all task history is written before execution block is stopped, the file buffer can't flush. it will be flushed in the next running query.

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #1140 (See https://builds.apache.org/job/Tajo-master-build/1140/)
        TAJO-2143: Fix race condition in task history writer. (jhkim: rev 34c5d5f24c48683f59925cafbec04a832e532753)

        • tajo-core/src/main/java/org/apache/tajo/util/history/HistoryWriter.java
        • tajo-core-tests/src/test/java/org/apache/tajo/util/history/TestHistoryWriterReader.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #1140 (See https://builds.apache.org/job/Tajo-master-build/1140/ ) TAJO-2143 : Fix race condition in task history writer. (jhkim: rev 34c5d5f24c48683f59925cafbec04a832e532753) tajo-core/src/main/java/org/apache/tajo/util/history/HistoryWriter.java tajo-core-tests/src/test/java/org/apache/tajo/util/history/TestHistoryWriterReader.java CHANGES
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #721 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/721/)
        TAJO-2143: Fix race condition in task history writer. (jhkim: rev 34c5d5f24c48683f59925cafbec04a832e532753)

        • tajo-core-tests/src/test/java/org/apache/tajo/util/history/TestHistoryWriterReader.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/util/history/HistoryWriter.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #721 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/721/ ) TAJO-2143 : Fix race condition in task history writer. (jhkim: rev 34c5d5f24c48683f59925cafbec04a832e532753) tajo-core-tests/src/test/java/org/apache/tajo/util/history/TestHistoryWriterReader.java CHANGES tajo-core/src/main/java/org/apache/tajo/util/history/HistoryWriter.java
        Hide
        jhkim Jinho Kim added a comment -

        Thanks for your review!

        Show
        jhkim Jinho Kim added a comment - Thanks for your review!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/1013

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/1013
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/1013#issuecomment-218043431

        +1 nice work!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/1013#issuecomment-218043431 +1 nice work!
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jinossy opened a pull request:

        https://github.com/apache/tajo/pull/1013

        TAJO-2143: Fix race condition in task history writer.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jinossy/tajo TAJO-2143

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/1013.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #1013


        commit 1d3f76aa1779896d04661323d9fe64069b69ca13
        Author: Jinho Kim <jhkim@apache.org>
        Date: 2016-05-09T08:49:16Z

        TAJO-2143: Fix race condition in task history writer.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/1013 TAJO-2143 : Fix race condition in task history writer. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-2143 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/1013.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1013 commit 1d3f76aa1779896d04661323d9fe64069b69ca13 Author: Jinho Kim <jhkim@apache.org> Date: 2016-05-09T08:49:16Z TAJO-2143 : Fix race condition in task history writer.

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development