Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: Unit Test
    • Labels:
      None

      Description

      See the title.

      1. TAJO-1871_2.patch
        2 kB
        Jihoon Son
      2. TAJO-1871_3.patch
        2 kB
        Jihoon Son
      3. TAJO-1871_4.patch
        2 kB
        Jihoon Son
      4. TAJO-1871_5.patch
        3 kB
        Jihoon Son
      5. TAJO-1871.patch
        0.5 kB
        Jihoon Son

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jihoonson opened a pull request:

        https://github.com/apache/tajo/pull/771

        TAJO-1871: '-DskipTests' flag does not work

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jihoonson/tajo-2 TAJO-1871

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/771.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #771


        commit 9624f8cdf798990e0d59f3d237fa2f8e70b97818
        Author: Jihoon Son <jihoonson@apache.org>
        Date: 2015-09-18T15:44:18Z

        TAJO-1871


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jihoonson opened a pull request: https://github.com/apache/tajo/pull/771 TAJO-1871 : '-DskipTests' flag does not work You can merge this pull request into a Git repository by running: $ git pull https://github.com/jihoonson/tajo-2 TAJO-1871 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/771.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #771 commit 9624f8cdf798990e0d59f3d237fa2f8e70b97818 Author: Jihoon Son <jihoonson@apache.org> Date: 2015-09-18T15:44:18Z TAJO-1871
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12761128/TAJO-1871.patch
        against master revision release-0.9.0-rc0-491-gde1b7d4.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-storage/tajo-storage-pgsql.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/865//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/865//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage-pgsql.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/865//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12761128/TAJO-1871.patch against master revision release-0.9.0-rc0-491-gde1b7d4. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-storage/tajo-storage-pgsql. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/865//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/865//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage-pgsql.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/865//console This message is automatically generated.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/771#discussion_r39880448

        — Diff: tajo-storage/tajo-storage-pgsql/pom.xml —
        @@ -236,7 +236,6 @@
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-surefire-plugin</artifactId>
        <configuration>
        — End diff –

        It is my fault. but your patch can't run tests
        please override configuration as follows:
        <configuration combine.self="override">

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/771#discussion_r39880448 — Diff: tajo-storage/tajo-storage-pgsql/pom.xml — @@ -236,7 +236,6 @@ <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-surefire-plugin</artifactId> <configuration> — End diff – It is my fault. but your patch can't run tests please override configuration as follows: <configuration combine.self="override">
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12761274/TAJO-1871_2.patch
        against master revision release-0.9.0-rc0-491-gde1b7d4.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-storage/tajo-storage-pgsql.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/866//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/866//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage-pgsql.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/866//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12761274/TAJO-1871_2.patch against master revision release-0.9.0-rc0-491-gde1b7d4. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-storage/tajo-storage-pgsql. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/866//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/866//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage-pgsql.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/866//console This message is automatically generated.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/771#discussion_r39918804

        — Diff: tajo-storage/tajo-storage-pgsql/pom.xml —
        @@ -224,10 +224,11 @@
        <profiles>
        <profile>
        <!-- testing-postgresql-server only supports x86-64 -->

        • <id>64bit-tests</id>
          + <id>64bit-intel-tests</id>
          <activation>
          <os>
        • <arch>x86_64</arch>
          + <name>x86_64</name>
            • End diff –

        As far as I know, ``name`` is intended to describe operation system name like ``linux`` or ``mac os x``.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on a diff in the pull request: https://github.com/apache/tajo/pull/771#discussion_r39918804 — Diff: tajo-storage/tajo-storage-pgsql/pom.xml — @@ -224,10 +224,11 @@ <profiles> <profile> <!-- testing-postgresql-server only supports x86-64 --> <id>64bit-tests</id> + <id>64bit-intel-tests</id> <activation> <os> <arch>x86_64</arch> + <name>x86_64</name> End diff – As far as I know, ``name`` is intended to describe operation system name like ``linux`` or ``mac os x``.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12761293/TAJO-1871_3.patch
        against master revision release-0.9.0-rc0-491-gde1b7d4.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-storage/tajo-storage-pgsql.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/867//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/867//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage-pgsql.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/867//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12761293/TAJO-1871_3.patch against master revision release-0.9.0-rc0-491-gde1b7d4. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-storage/tajo-storage-pgsql. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/867//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/867//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage-pgsql.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/867//console This message is automatically generated.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12761359/TAJO-1871_4.patch
        against master revision release-0.9.0-rc0-492-g8f00bf7.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-storage/tajo-storage-pgsql.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/868//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/868//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage-pgsql.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/868//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12761359/TAJO-1871_4.patch against master revision release-0.9.0-rc0-492-g8f00bf7. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-storage/tajo-storage-pgsql. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/868//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/868//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage-pgsql.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/868//console This message is automatically generated.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12761369/TAJO-1871_5.patch
        against master revision release-0.9.0-rc0-492-g8f00bf7.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-storage/tajo-storage-pgsql.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/869//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/869//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage-pgsql.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/869//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12761369/TAJO-1871_5.patch against master revision release-0.9.0-rc0-492-g8f00bf7. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-storage/tajo-storage-pgsql. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/869//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/869//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage-pgsql.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/869//console This message is automatically generated.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/771#issuecomment-142155906

        I've tested with my linux desktop and MBP.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/771#issuecomment-142155906 I've tested with my linux desktop and MBP.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/771#issuecomment-142160883

        +1 LGTM

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/771#issuecomment-142160883 +1 LGTM
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/771

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/771
        Hide
        jihoonson Jihoon Son added a comment -

        Committed to master and 0.11.

        Show
        jihoonson Jihoon Son added a comment - Committed to master and 0.11.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/771#issuecomment-142163224

        Thanks for your review.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/771#issuecomment-142163224 Thanks for your review.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #526 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/526/)
        TAJO-1871: '-DskipTests' flag does not work. (jihoonson: rev 08def97c45140d8ffcf50eeef989e2b5760a2195)

        • tajo-storage/tajo-storage-pgsql/pom.xml
        • CHANGES
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #526 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/526/ ) TAJO-1871 : '-DskipTests' flag does not work. (jihoonson: rev 08def97c45140d8ffcf50eeef989e2b5760a2195) tajo-storage/tajo-storage-pgsql/pom.xml CHANGES
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #887 (See https://builds.apache.org/job/Tajo-master-build/887/)
        TAJO-1871: '-DskipTests' flag does not work. (jihoonson: rev 08def97c45140d8ffcf50eeef989e2b5760a2195)

        • CHANGES
        • tajo-storage/tajo-storage-pgsql/pom.xml
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #887 (See https://builds.apache.org/job/Tajo-master-build/887/ ) TAJO-1871 : '-DskipTests' flag does not work. (jihoonson: rev 08def97c45140d8ffcf50eeef989e2b5760a2195) CHANGES tajo-storage/tajo-storage-pgsql/pom.xml
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-0.11.0-build #62 (See https://builds.apache.org/job/Tajo-0.11.0-build/62/)
        TAJO-1871: '-DskipTests' flag does not work. (jihoonson: rev 0e0c5017092a3b028022427e0658265991f04140)

        • tajo-storage/tajo-storage-pgsql/pom.xml
        • CHANGES
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-0.11.0-build #62 (See https://builds.apache.org/job/Tajo-0.11.0-build/62/ ) TAJO-1871 : '-DskipTests' flag does not work. (jihoonson: rev 0e0c5017092a3b028022427e0658265991f04140) tajo-storage/tajo-storage-pgsql/pom.xml CHANGES

          People

          • Assignee:
            jihoonson Jihoon Son
            Reporter:
            jihoonson Jihoon Son
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development