Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1835

TajoClient::executeQueryAndGetResult should throw Query(Failed|Killed)Exception

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: Java Client
    • Labels:
      None

      Description

      TajoClient::executeQueryAndGetResult should throw Query(Failed|Killed)Exception rather than returning NullResultSet when a running query is failed or killed. This patch changes this API semantic.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/754

        TAJO-1835: TajoClient::executeQueryAndGetResult should throw Query(Failed|Killed)Exception.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-1835

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/754.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #754


        commit 2f9a3b97bd5d87275e395201d6d3a84b9af76b99
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-09-10T13:12:34Z

        TAJO-1835: TajoClient::executeQueryAndGetResult should throw Query(Failed|Killed)Exception.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/754 TAJO-1835 : TajoClient::executeQueryAndGetResult should throw Query(Failed|Killed)Exception. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1835 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/754.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #754 commit 2f9a3b97bd5d87275e395201d6d3a84b9af76b99 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-09-10T13:12:34Z TAJO-1835 : TajoClient::executeQueryAndGetResult should throw Query(Failed|Killed)Exception.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/754#issuecomment-139450355

        Could you trigger the CI build?

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/754#issuecomment-139450355 Could you trigger the CI build?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/754#issuecomment-139707711

        +1

        LGTM!

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/754#issuecomment-139707711 +1 LGTM!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/754

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/754
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #505 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/505/)
        TAJO-1835: TajoClient::executeQueryAndGetResult should throw Query(Failed|Killed)Exception. (hyunsik: rev fb5da6647f0b60b4cc1d353e3cc3fe68a617950f)

        • tajo-plan/src/main/java/org/apache/tajo/plan/verifier/PreLogicalPlanVerifier.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java
        • tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestTajoCliNegatives.java
        • tajo-client/src/main/java/org/apache/tajo/jdbc/WaitingResultSet.java
        • tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java
        • tajo-client/src/main/java/org/apache/tajo/client/QueryStatus.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #505 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/505/ ) TAJO-1835 : TajoClient::executeQueryAndGetResult should throw Query(Failed|Killed)Exception. (hyunsik: rev fb5da6647f0b60b4cc1d353e3cc3fe68a617950f) tajo-plan/src/main/java/org/apache/tajo/plan/verifier/PreLogicalPlanVerifier.java CHANGES tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestTajoCliNegatives.java tajo-client/src/main/java/org/apache/tajo/jdbc/WaitingResultSet.java tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java tajo-client/src/main/java/org/apache/tajo/client/QueryStatus.java
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed.

        Show
        hyunsik Hyunsik Choi added a comment - committed.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #863 (See https://builds.apache.org/job/Tajo-master-build/863/)
        TAJO-1835: TajoClient::executeQueryAndGetResult should throw Query(Failed|Killed)Exception. (hyunsik: rev fb5da6647f0b60b4cc1d353e3cc3fe68a617950f)

        • tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestTajoCliNegatives.java
        • tajo-client/src/main/java/org/apache/tajo/jdbc/WaitingResultSet.java
        • tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/verifier/PreLogicalPlanVerifier.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java
        • tajo-client/src/main/java/org/apache/tajo/client/QueryStatus.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #863 (See https://builds.apache.org/job/Tajo-master-build/863/ ) TAJO-1835 : TajoClient::executeQueryAndGetResult should throw Query(Failed|Killed)Exception. (hyunsik: rev fb5da6647f0b60b4cc1d353e3cc3fe68a617950f) tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestTajoCliNegatives.java tajo-client/src/main/java/org/apache/tajo/jdbc/WaitingResultSet.java tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java tajo-plan/src/main/java/org/apache/tajo/plan/verifier/PreLogicalPlanVerifier.java CHANGES tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java tajo-client/src/main/java/org/apache/tajo/client/QueryStatus.java
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-0.11.0-build #40 (See https://builds.apache.org/job/Tajo-0.11.0-build/40/)
        TAJO-1835: TajoClient::executeQueryAndGetResult should throw Query(Failed|Killed)Exception. (hyunsik: rev f0e22b76aba0b7480d96548b3aaedceb59fa8112)

        • CHANGES
        • tajo-client/src/main/java/org/apache/tajo/jdbc/WaitingResultSet.java
        • tajo-client/src/main/java/org/apache/tajo/client/QueryStatus.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/verifier/PreLogicalPlanVerifier.java
        • tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestTajoCliNegatives.java
        • tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-0.11.0-build #40 (See https://builds.apache.org/job/Tajo-0.11.0-build/40/ ) TAJO-1835 : TajoClient::executeQueryAndGetResult should throw Query(Failed|Killed)Exception. (hyunsik: rev f0e22b76aba0b7480d96548b3aaedceb59fa8112) CHANGES tajo-client/src/main/java/org/apache/tajo/jdbc/WaitingResultSet.java tajo-client/src/main/java/org/apache/tajo/client/QueryStatus.java tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java tajo-plan/src/main/java/org/apache/tajo/plan/verifier/PreLogicalPlanVerifier.java tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestTajoCliNegatives.java tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development