Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1831

Add a shutdown hook manager in order to set priorities

    Details

      Description

      Sometimes, event-group thread of netty’s is not stopped. because jvm will start a shutdown-hook after all thread is stopped without kill signal. it is dead-lock state.
      We should explicitly call to shutdown the event-group thread of netty’s and should set a shutdown-hook order

      For example, before you start up TajoMaster, runs tsql, you can find deadlock

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jinossy opened a pull request:

        https://github.com/apache/tajo/pull/751

        TAJO-1831: Add a shutdown hook manager in order to set priorities.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jinossy/tajo TAJO-1831

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/751.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #751


        commit 16c556034c58174e8eb678974e453078daab5472
        Author: Jinho Kim <jhkim@apache.org>
        Date: 2015-09-10T07:21:11Z

        TAJO-1831: Add a shutdown hook manager in order to set priorities.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/751 TAJO-1831 : Add a shutdown hook manager in order to set priorities. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-1831 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/751.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #751 commit 16c556034c58174e8eb678974e453078daab5472 Author: Jinho Kim <jhkim@apache.org> Date: 2015-09-10T07:21:11Z TAJO-1831 : Add a shutdown hook manager in order to set priorities.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/751#issuecomment-139454276

        +1 LGTM!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/751#issuecomment-139454276 +1 LGTM!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/751

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/751
        Hide
        jhkim Jinho Kim added a comment -

        committed it
        Thanks

        Show
        jhkim Jinho Kim added a comment - committed it Thanks
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #502 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/502/)
        TAJO-1831: Add a shutdown hook manager in order to set priorities. (jhkim: rev 60d8d4bc80444402c2b4ad61644859d7bda8b380)

        • tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestAsyncRpc.java
        • tajo-core-tests/pom.xml
        • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/NettyClientBase.java
        • CHANGES
        • tajo-common/src/main/java/org/apache/tajo/util/ShutdownHookManager.java
        • tajo-rpc/tajo-rpc-common/src/main/java/org/apache/tajo/rpc/NettyServerBase.java
        • tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java
        • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/AsyncRpcClient.java
        • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/BlockingRpcServer.java
        • tajo-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java
        • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/BlockingRpcClient.java
        • tajo-rpc/tajo-rpc-common/src/main/java/org/apache/tajo/rpc/NettyUtils.java
        • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/AsyncRpcServer.java
        • tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java
        • tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestBlockingRpc.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/TajoCli.java
        • tajo-rpc/tajo-rpc-common/src/main/java/org/apache/tajo/rpc/RpcChannelFactory.java
        • tajo-core-tests/src/test/java/org/apache/tajo/client/TestTajoClient.java
        • tajo-core/src/main/java/org/apache/tajo/worker/Fetcher.java
        • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/RpcClientManager.java
        • tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #502 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/502/ ) TAJO-1831 : Add a shutdown hook manager in order to set priorities. (jhkim: rev 60d8d4bc80444402c2b4ad61644859d7bda8b380) tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestAsyncRpc.java tajo-core-tests/pom.xml tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/NettyClientBase.java CHANGES tajo-common/src/main/java/org/apache/tajo/util/ShutdownHookManager.java tajo-rpc/tajo-rpc-common/src/main/java/org/apache/tajo/rpc/NettyServerBase.java tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/AsyncRpcClient.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/BlockingRpcServer.java tajo-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/BlockingRpcClient.java tajo-rpc/tajo-rpc-common/src/main/java/org/apache/tajo/rpc/NettyUtils.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/AsyncRpcServer.java tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestBlockingRpc.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/TajoCli.java tajo-rpc/tajo-rpc-common/src/main/java/org/apache/tajo/rpc/RpcChannelFactory.java tajo-core-tests/src/test/java/org/apache/tajo/client/TestTajoClient.java tajo-core/src/main/java/org/apache/tajo/worker/Fetcher.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/RpcClientManager.java tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.11.0-build #37 (See https://builds.apache.org/job/Tajo-0.11.0-build/37/)
        TAJO-1831: Add a shutdown hook manager in order to set priorities. (jhkim: rev 4b9237617f0c1c336452c4fb17187c8e9c179705)

        • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/RpcClientManager.java
        • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/AsyncRpcClient.java
        • tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
        • tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestBlockingRpc.java
        • tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java
        • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/BlockingRpcServer.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/TajoCli.java
        • tajo-core/src/main/java/org/apache/tajo/worker/Fetcher.java
        • tajo-rpc/tajo-rpc-common/src/main/java/org/apache/tajo/rpc/NettyUtils.java
        • tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestAsyncRpc.java
        • tajo-rpc/tajo-rpc-common/src/main/java/org/apache/tajo/rpc/RpcChannelFactory.java
        • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/NettyClientBase.java
        • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/BlockingRpcClient.java
        • CHANGES
        • tajo-rpc/tajo-rpc-common/src/main/java/org/apache/tajo/rpc/NettyServerBase.java
        • tajo-common/src/main/java/org/apache/tajo/util/ShutdownHookManager.java
        • tajo-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java
        • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/AsyncRpcServer.java
        • tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
        • tajo-core-tests/pom.xml
        • tajo-core-tests/src/test/java/org/apache/tajo/client/TestTajoClient.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.11.0-build #37 (See https://builds.apache.org/job/Tajo-0.11.0-build/37/ ) TAJO-1831 : Add a shutdown hook manager in order to set priorities. (jhkim: rev 4b9237617f0c1c336452c4fb17187c8e9c179705) tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/RpcClientManager.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/AsyncRpcClient.java tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestBlockingRpc.java tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/BlockingRpcServer.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/TajoCli.java tajo-core/src/main/java/org/apache/tajo/worker/Fetcher.java tajo-rpc/tajo-rpc-common/src/main/java/org/apache/tajo/rpc/NettyUtils.java tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestAsyncRpc.java tajo-rpc/tajo-rpc-common/src/main/java/org/apache/tajo/rpc/RpcChannelFactory.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/NettyClientBase.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/BlockingRpcClient.java CHANGES tajo-rpc/tajo-rpc-common/src/main/java/org/apache/tajo/rpc/NettyServerBase.java tajo-common/src/main/java/org/apache/tajo/util/ShutdownHookManager.java tajo-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/AsyncRpcServer.java tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java tajo-core-tests/pom.xml tajo-core-tests/src/test/java/org/apache/tajo/client/TestTajoClient.java tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #861 (See https://builds.apache.org/job/Tajo-master-build/861/)
        TAJO-1831: Add a shutdown hook manager in order to set priorities. (jhkim: rev 60d8d4bc80444402c2b4ad61644859d7bda8b380)

        • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/BlockingRpcClient.java
        • tajo-common/src/main/java/org/apache/tajo/util/ShutdownHookManager.java
        • tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestBlockingRpc.java
        • tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestAsyncRpc.java
        • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/AsyncRpcClient.java
        • tajo-rpc/tajo-rpc-common/src/main/java/org/apache/tajo/rpc/NettyUtils.java
        • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/BlockingRpcServer.java
        • tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java
        • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/AsyncRpcServer.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java
        • tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
        • tajo-rpc/tajo-rpc-common/src/main/java/org/apache/tajo/rpc/RpcChannelFactory.java
        • tajo-core-tests/pom.xml
        • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/RpcClientManager.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/TajoCli.java
        • tajo-core/src/main/java/org/apache/tajo/worker/Fetcher.java
        • tajo-core-tests/src/test/java/org/apache/tajo/client/TestTajoClient.java
        • tajo-rpc/tajo-rpc-common/src/main/java/org/apache/tajo/rpc/NettyServerBase.java
        • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/NettyClientBase.java
        • tajo-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #861 (See https://builds.apache.org/job/Tajo-master-build/861/ ) TAJO-1831 : Add a shutdown hook manager in order to set priorities. (jhkim: rev 60d8d4bc80444402c2b4ad61644859d7bda8b380) tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/BlockingRpcClient.java tajo-common/src/main/java/org/apache/tajo/util/ShutdownHookManager.java tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestBlockingRpc.java tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestAsyncRpc.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/AsyncRpcClient.java tajo-rpc/tajo-rpc-common/src/main/java/org/apache/tajo/rpc/NettyUtils.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/BlockingRpcServer.java tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/AsyncRpcServer.java tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java tajo-rpc/tajo-rpc-common/src/main/java/org/apache/tajo/rpc/RpcChannelFactory.java tajo-core-tests/pom.xml tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/RpcClientManager.java CHANGES tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/TajoCli.java tajo-core/src/main/java/org/apache/tajo/worker/Fetcher.java tajo-core-tests/src/test/java/org/apache/tajo/client/TestTajoClient.java tajo-rpc/tajo-rpc-common/src/main/java/org/apache/tajo/rpc/NettyServerBase.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/NettyClientBase.java tajo-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development