Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1828

tajo-daemon scripts should kill process after process can not stop gracefully

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0, 0.12.0
    • Component/s: conf and scripts
    • Labels:
      None

      Description

      Currently, tajo-daemon scripts stop the process gracefully. but it does not verify return code. If process is alive, scripts should retry to kill process

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.11.0-build #26 (See https://builds.apache.org/job/Tajo-0.11.0-build/26/)
        TAJO-1828: tajo-daemon scripts should kill process after process can not stop gracefully. (jhkim: rev dd7adfcc6cef4058d6fa3fb453c4c2e420081d16)

        • CHANGES
        • tajo-dist/src/main/bin/tajo-daemon.sh
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.11.0-build #26 (See https://builds.apache.org/job/Tajo-0.11.0-build/26/ ) TAJO-1828 : tajo-daemon scripts should kill process after process can not stop gracefully. (jhkim: rev dd7adfcc6cef4058d6fa3fb453c4c2e420081d16) CHANGES tajo-dist/src/main/bin/tajo-daemon.sh
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #849 (See https://builds.apache.org/job/Tajo-master-build/849/)
        TAJO-1828: tajo-daemon scripts should kill process after process can not stop gracefully. (jhkim: rev c66d0b4708814ed8f7a1ae530338e1fcf87caddc)

        • CHANGES
        • tajo-dist/src/main/bin/tajo-daemon.sh
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #849 (See https://builds.apache.org/job/Tajo-master-build/849/ ) TAJO-1828 : tajo-daemon scripts should kill process after process can not stop gracefully. (jhkim: rev c66d0b4708814ed8f7a1ae530338e1fcf87caddc) CHANGES tajo-dist/src/main/bin/tajo-daemon.sh
        Hide
        jhkim Jinho Kim added a comment -

        Thanks for quick review!

        Show
        jhkim Jinho Kim added a comment - Thanks for quick review!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #491 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/491/)
        TAJO-1828: tajo-daemon scripts should kill process after process can not stop gracefully. (jhkim: rev c66d0b4708814ed8f7a1ae530338e1fcf87caddc)

        • tajo-dist/src/main/bin/tajo-daemon.sh
        • CHANGES
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #491 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/491/ ) TAJO-1828 : tajo-daemon scripts should kill process after process can not stop gracefully. (jhkim: rev c66d0b4708814ed8f7a1ae530338e1fcf87caddc) tajo-dist/src/main/bin/tajo-daemon.sh CHANGES
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/746

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/746
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/746#issuecomment-138767523

        +1 LGTM!

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/746#issuecomment-138767523 +1 LGTM!
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jinossy opened a pull request:

        https://github.com/apache/tajo/pull/746

        TAJO-1828: tajo-daemon scripts should kill process after process can …

        …not stop gracefully.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jinossy/tajo TAJO-1828

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/746.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #746


        commit 9b8b7bfeeaaa3e1d580b5f342e319afa046575f9
        Author: Jinho Kim <jhkim@apache.org>
        Date: 2015-09-08T13:04:53Z

        TAJO-1828: tajo-daemon scripts should kill process after process can not stop gracefully.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/746 TAJO-1828 : tajo-daemon scripts should kill process after process can … …not stop gracefully. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-1828 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/746.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #746 commit 9b8b7bfeeaaa3e1d580b5f342e319afa046575f9 Author: Jinho Kim <jhkim@apache.org> Date: 2015-09-08T13:04:53Z TAJO-1828 : tajo-daemon scripts should kill process after process can not stop gracefully.

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development