Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1827

JSON parsing error at storage-site.json while tajo master starts up

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0, 0.12.0
    • Component/s: conf and scripts
    • Labels:
      None

      Description

      Tajo provides storage-site.json-template by default to accommodate user convenience. This file contains commented out apache license and example configurations. However, this incurs JSON parsing error when starting up the cluster.

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #907 (See https://builds.apache.org/job/Tajo-master-build/907/)
        TAJO-1827: JSON parsing error at storage-site.json while tajo master starts up. (blrunner: rev bf04b56c52a53d6465d0eff97eef3dcf9b0187e3)

        • tajo-dist/src/main/conf/storage-site.json.template
        • tajo-dist/pom.xml
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #907 (See https://builds.apache.org/job/Tajo-master-build/907/ ) TAJO-1827 : JSON parsing error at storage-site.json while tajo master starts up. (blrunner: rev bf04b56c52a53d6465d0eff97eef3dcf9b0187e3) tajo-dist/src/main/conf/storage-site.json.template tajo-dist/pom.xml CHANGES
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-0.11.0-build #72 (See https://builds.apache.org/job/Tajo-0.11.0-build/72/)
        TAJO-1827: JSON parsing error at storage-site.json while tajo master starts up. (blrunner: rev 8c8093367033f6282c7bc03f92769abcaef2d868)

        • tajo-dist/src/main/conf/storage-site.json.template
        • CHANGES
        • tajo-dist/pom.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-0.11.0-build #72 (See https://builds.apache.org/job/Tajo-0.11.0-build/72/ ) TAJO-1827 : JSON parsing error at storage-site.json while tajo master starts up. (blrunner: rev 8c8093367033f6282c7bc03f92769abcaef2d868) tajo-dist/src/main/conf/storage-site.json.template CHANGES tajo-dist/pom.xml
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #540 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/540/)
        TAJO-1827: JSON parsing error at storage-site.json while tajo master starts up. (blrunner: rev bf04b56c52a53d6465d0eff97eef3dcf9b0187e3)

        • CHANGES
        • tajo-dist/pom.xml
        • tajo-dist/src/main/conf/storage-site.json.template
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #540 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/540/ ) TAJO-1827 : JSON parsing error at storage-site.json while tajo master starts up. (blrunner: rev bf04b56c52a53d6465d0eff97eef3dcf9b0187e3) CHANGES tajo-dist/pom.xml tajo-dist/src/main/conf/storage-site.json.template
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/776

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/776
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/776#issuecomment-142978271

        +1
        Ship it. the patch looks good to me.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/776#issuecomment-142978271 +1 Ship it. the patch looks good to me.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/776#issuecomment-142814740

        @hyunsik

        On second thought, the template file might cause a problem when starting HBaseTableSpace. I'll shit previous version.

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/776#issuecomment-142814740 @hyunsik On second thought, the template file might cause a problem when starting HBaseTableSpace. I'll shit previous version.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/776#issuecomment-142770410

        Thanks @hyunsik

        I added a description element to JSON template instead of removing contents. If possible, could you check it again?

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/776#issuecomment-142770410 Thanks @hyunsik I added a description element to JSON template instead of removing contents. If possible, could you check it again?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/776#issuecomment-142487168

        +1
        The patch looks good to me.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/776#issuecomment-142487168 +1 The patch looks good to me.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/776#issuecomment-142467460

        Thanks @hyunsik .
        I've reflected your comments.

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/776#issuecomment-142467460 Thanks @hyunsik . I've reflected your comments.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/776#issuecomment-142425585

        How about removing all contents from the template file? The default template will add a tablespace as soon as a user just copies ``storage-site.json`` from ``storage-site.json.template``. It may cause some problem.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/776#issuecomment-142425585 How about removing all contents from the template file? The default template will add a tablespace as soon as a user just copies ``storage-site.json`` from ``storage-site.json.template``. It may cause some problem.
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user blrunner opened a pull request:

        https://github.com/apache/tajo/pull/776

        TAJO-1827: JSON parsing error at storage-site.json while tajo master starts up

        Removed comments in the template file.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/blrunner/tajo TAJO-1827

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/776.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #776


        commit d0093e54623299bc98eb6ee6c00fc7ca28d7f1b0
        Author: JaeHwa Jung <blrunner@apache.org>
        Date: 2015-09-22T08:50:12Z

        TAJO-1827: JSON parsing error at storage-site.json while tajo master starts up


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user blrunner opened a pull request: https://github.com/apache/tajo/pull/776 TAJO-1827 : JSON parsing error at storage-site.json while tajo master starts up Removed comments in the template file. You can merge this pull request into a Git repository by running: $ git pull https://github.com/blrunner/tajo TAJO-1827 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/776.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #776 commit d0093e54623299bc98eb6ee6c00fc7ca28d7f1b0 Author: JaeHwa Jung <blrunner@apache.org> Date: 2015-09-22T08:50:12Z TAJO-1827 : JSON parsing error at storage-site.json while tajo master starts up
        Hide
        blrunner Jaehwa Jung added a comment - - edited

        Hi Jihoon Son

        I know that comments in JSON are not allowed. We can consider the following items.

        1. Remove comments in the template file.
        2. Add description property.
        3. Add notice message about JSON parse error by comments to the file.
        4. Remove the file.
        5. Change JSON parser : I hear some JSON parser may allow comments in JSON.

        What do you think about it?

        Show
        blrunner Jaehwa Jung added a comment - - edited Hi Jihoon Son I know that comments in JSON are not allowed. We can consider the following items. 1. Remove comments in the template file. 2. Add description property. 3. Add notice message about JSON parse error by comments to the file. 4. Remove the file. 5. Change JSON parser : I hear some JSON parser may allow comments in JSON. What do you think about it?

          People

          • Assignee:
            blrunner Jaehwa Jung
            Reporter:
            jihoonson Jihoon Son
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development