Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0, 0.12.0
    • Component/s: Catalog
    • Labels:
      None

      Description

      Selecting partition keys is not necessary because partitions are searched with its partition name. It would be better to remove from information_schema.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user blrunner opened a pull request:

          https://github.com/apache/tajo/pull/743

          TAJO-1824: Remove partition_keys table from information_schema

          Selecting partition keys is not necessary because partitions are searched with its partition name. It would be better to remove from information_schema.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/blrunner/tajo TAJO-1824

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tajo/pull/743.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #743


          commit 4862c2ac781bdbbcea13c5656266afee5f240e67
          Author: JaeHwa Jung <blrunner@apache.org>
          Date: 2015-09-08T05:39:14Z

          TAJO-1824: Remove partition_keys table from information_schema


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user blrunner opened a pull request: https://github.com/apache/tajo/pull/743 TAJO-1824 : Remove partition_keys table from information_schema Selecting partition keys is not necessary because partitions are searched with its partition name. It would be better to remove from information_schema. You can merge this pull request into a Git repository by running: $ git pull https://github.com/blrunner/tajo TAJO-1824 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/743.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #743 commit 4862c2ac781bdbbcea13c5656266afee5f240e67 Author: JaeHwa Jung <blrunner@apache.org> Date: 2015-09-08T05:39:14Z TAJO-1824 : Remove partition_keys table from information_schema
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12754574/TAJO-1824.patch
          against master revision release-0.9.0-rc0-454-g8a27a43.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          -1 findbugs. The patch appears to introduce 8 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-common tajo-catalog/tajo-catalog-server tajo-core-tests.

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/862//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/862//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-server.html
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/862//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12754574/TAJO-1824.patch against master revision release-0.9.0-rc0-454-g8a27a43. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 8 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-common tajo-catalog/tajo-catalog-server tajo-core-tests. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/862//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/862//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-server.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/862//console This message is automatically generated.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik commented on a diff in the pull request:

          https://github.com/apache/tajo/pull/743#discussion_r39019222

          — Diff: tajo-core-tests/src/test/java/org/apache/tajo/master/TestNonForwardQueryResultSystemScanner.java —
          @@ -38,4 +47,20 @@ public void testGetNextRowsForTable() throws Exception {
          public void testGetClusterDetails() throws Exception

          { assertQueryStr("SELECT TYPE FROM INFORMATION_SCHEMA.CLUSTER"); }

          +
          — End diff –

          I think that this test is not necessary.

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on a diff in the pull request: https://github.com/apache/tajo/pull/743#discussion_r39019222 — Diff: tajo-core-tests/src/test/java/org/apache/tajo/master/TestNonForwardQueryResultSystemScanner.java — @@ -38,4 +47,20 @@ public void testGetNextRowsForTable() throws Exception { public void testGetClusterDetails() throws Exception { assertQueryStr("SELECT TYPE FROM INFORMATION_SCHEMA.CLUSTER"); } + — End diff – I think that this test is not necessary.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik commented on the pull request:

          https://github.com/apache/tajo/pull/743#issuecomment-138831245

          This change looks straightforward. So, the added unit test is not necessary.

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/743#issuecomment-138831245 This change looks straightforward. So, the added unit test is not necessary.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user blrunner commented on the pull request:

          https://github.com/apache/tajo/pull/743#issuecomment-139106868

          Thanks @hyunsik

          I've just removed the unit test.

          Show
          githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/743#issuecomment-139106868 Thanks @hyunsik I've just removed the unit test.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik commented on the pull request:

          https://github.com/apache/tajo/pull/743#issuecomment-140607834

          +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/743#issuecomment-140607834 +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tajo/pull/743

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/743
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Tajo-master-CODEGEN-build #511 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/511/)
          TAJO-1824: Remove partition_keys table from information_schema. (blrunner: rev 8baaa481ee6c627b88ecc21097aaf51f571c4e14)

          • CHANGES
          • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/dictionary/InfoSchemaMetadataDictionary.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #511 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/511/ ) TAJO-1824 : Remove partition_keys table from information_schema. (blrunner: rev 8baaa481ee6c627b88ecc21097aaf51f571c4e14) CHANGES tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/dictionary/InfoSchemaMetadataDictionary.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-0.11.0-build #46 (See https://builds.apache.org/job/Tajo-0.11.0-build/46/)
          TAJO-1824: Remove partition_keys table from information_schema. (blrunner: rev b2b708024419c15db6111656ce4da84b355e965a)

          • CHANGES
          • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/dictionary/InfoSchemaMetadataDictionary.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.11.0-build #46 (See https://builds.apache.org/job/Tajo-0.11.0-build/46/ ) TAJO-1824 : Remove partition_keys table from information_schema. (blrunner: rev b2b708024419c15db6111656ce4da84b355e965a) CHANGES tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/dictionary/InfoSchemaMetadataDictionary.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-build #869 (See https://builds.apache.org/job/Tajo-master-build/869/)
          TAJO-1824: Remove partition_keys table from information_schema. (blrunner: rev 8baaa481ee6c627b88ecc21097aaf51f571c4e14)

          • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/dictionary/InfoSchemaMetadataDictionary.java
          • CHANGES
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #869 (See https://builds.apache.org/job/Tajo-master-build/869/ ) TAJO-1824 : Remove partition_keys table from information_schema. (blrunner: rev 8baaa481ee6c627b88ecc21097aaf51f571c4e14) tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/dictionary/InfoSchemaMetadataDictionary.java CHANGES

            People

            • Assignee:
              blrunner Jaehwa Jung
              Reporter:
              blrunner Jaehwa Jung
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Due:
                Created:
                Updated:
                Resolved:

                Development