Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1810

Remove QueryMasterTask cache immediately, if it stored to persistent storage

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.11.0
    • Fix Version/s: 0.11.0, 0.12.0
    • Component/s: QueryMaster
    • Labels:
      None

      Description

      Query information is stored asyncronously to the persistent storage and It does exist in LRU cache for a while.
      The cache entry should be removed immediately, if stored to persistent storage

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jinossy opened a pull request:

        https://github.com/apache/tajo/pull/721

        TAJO-1810: Remove QueryMasterTask cache immediately, if it stored to …

        …persistent storage

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jinossy/tajo TAJO-1810

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/721.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #721


        commit b4b329ff1c932d7e9d0760b1b197c73d00a4ed73
        Author: Jinho Kim <jhkim@apache.org>
        Date: 2015-09-03T07:06:32Z

        TAJO-1810: Remove QueryMasterTask cache immediately, if it stored to persistent storage


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/721 TAJO-1810 : Remove QueryMasterTask cache immediately, if it stored to … …persistent storage You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-1810 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/721.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #721 commit b4b329ff1c932d7e9d0760b1b197c73d00a4ed73 Author: Jinho Kim <jhkim@apache.org> Date: 2015-09-03T07:06:32Z TAJO-1810 : Remove QueryMasterTask cache immediately, if it stored to persistent storage
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/721#issuecomment-137396120

        +1 ship it!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/721#issuecomment-137396120 +1 ship it!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #471 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/471/)
        TAJO-1810: Remove QueryMasterTask cache immediately, if it stored to persistent storage. (jhkim: rev 8c50410dcf370290982719f8add9aad814a5d4e0)

        • tajo-core/src/main/java/org/apache/tajo/util/history/HistoryWriter.java
        • tajo-cluster-tests/src/test/java/org/apache/tajo/QueryTestCaseBase.java
        • tajo-core/src/main/java/org/apache/tajo/master/QueryManager.java
        • tajo-core-tests/src/test/java/org/apache/tajo/master/TestQueryResult.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMaster.java
        • tajo-core-tests/src/test/java/org/apache/tajo/querymaster/TestTaskStatusUpdate.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/worker/TajoWorkerClientService.java
        • tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java
        • tajo-core-tests/src/test/java/org/apache/tajo/querymaster/TestQueryState.java
        • tajo-cluster-tests/src/test/java/org/apache/tajo/TajoTestingCluster.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestGroupByQuery.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #471 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/471/ ) TAJO-1810 : Remove QueryMasterTask cache immediately, if it stored to persistent storage. (jhkim: rev 8c50410dcf370290982719f8add9aad814a5d4e0) tajo-core/src/main/java/org/apache/tajo/util/history/HistoryWriter.java tajo-cluster-tests/src/test/java/org/apache/tajo/QueryTestCaseBase.java tajo-core/src/main/java/org/apache/tajo/master/QueryManager.java tajo-core-tests/src/test/java/org/apache/tajo/master/TestQueryResult.java tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMaster.java tajo-core-tests/src/test/java/org/apache/tajo/querymaster/TestTaskStatusUpdate.java CHANGES tajo-core/src/main/java/org/apache/tajo/worker/TajoWorkerClientService.java tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java tajo-core-tests/src/test/java/org/apache/tajo/querymaster/TestQueryState.java tajo-cluster-tests/src/test/java/org/apache/tajo/TajoTestingCluster.java tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestGroupByQuery.java tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/721

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/721
        Hide
        jhkim Jinho Kim added a comment -

        Thanks for your quick review!!

        Show
        jhkim Jinho Kim added a comment - Thanks for your quick review!!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #828 (See https://builds.apache.org/job/Tajo-master-build/828/)
        TAJO-1810: Remove QueryMasterTask cache immediately, if it stored to persistent storage. (jhkim: rev 8c50410dcf370290982719f8add9aad814a5d4e0)

        • tajo-core-tests/src/test/java/org/apache/tajo/master/TestQueryResult.java
        • tajo-core-tests/src/test/java/org/apache/tajo/querymaster/TestTaskStatusUpdate.java
        • tajo-core/src/main/java/org/apache/tajo/master/QueryManager.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java
        • tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
        • CHANGES
        • tajo-core-tests/src/test/java/org/apache/tajo/querymaster/TestQueryState.java
        • tajo-cluster-tests/src/test/java/org/apache/tajo/QueryTestCaseBase.java
        • tajo-core/src/main/java/org/apache/tajo/util/history/HistoryWriter.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestGroupByQuery.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TajoWorkerClientService.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMaster.java
        • tajo-cluster-tests/src/test/java/org/apache/tajo/TajoTestingCluster.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #828 (See https://builds.apache.org/job/Tajo-master-build/828/ ) TAJO-1810 : Remove QueryMasterTask cache immediately, if it stored to persistent storage. (jhkim: rev 8c50410dcf370290982719f8add9aad814a5d4e0) tajo-core-tests/src/test/java/org/apache/tajo/master/TestQueryResult.java tajo-core-tests/src/test/java/org/apache/tajo/querymaster/TestTaskStatusUpdate.java tajo-core/src/main/java/org/apache/tajo/master/QueryManager.java tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java CHANGES tajo-core-tests/src/test/java/org/apache/tajo/querymaster/TestQueryState.java tajo-cluster-tests/src/test/java/org/apache/tajo/QueryTestCaseBase.java tajo-core/src/main/java/org/apache/tajo/util/history/HistoryWriter.java tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestGroupByQuery.java tajo-core/src/main/java/org/apache/tajo/worker/TajoWorkerClientService.java tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMaster.java tajo-cluster-tests/src/test/java/org/apache/tajo/TajoTestingCluster.java
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-0.11.0-build #8 (See https://builds.apache.org/job/Tajo-0.11.0-build/8/)
        TAJO-1810: Remove QueryMasterTask cache immediately, if it stored to persistent storage. (jhkim: rev ade06657807b26733e320ce515898b809f611700)

        • tajo-core-tests/src/test/java/org/apache/tajo/master/TestQueryResult.java
        • tajo-core-tests/src/test/java/org/apache/tajo/querymaster/TestTaskStatusUpdate.java
        • tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java
        • tajo-core-tests/src/test/java/org/apache/tajo/querymaster/TestQueryState.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TajoWorkerClientService.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMaster.java
        • tajo-core/src/main/java/org/apache/tajo/master/QueryManager.java
        • tajo-cluster-tests/src/test/java/org/apache/tajo/TajoTestingCluster.java
        • tajo-cluster-tests/src/test/java/org/apache/tajo/QueryTestCaseBase.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/util/history/HistoryWriter.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestGroupByQuery.java
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-0.11.0-build #8 (See https://builds.apache.org/job/Tajo-0.11.0-build/8/ ) TAJO-1810 : Remove QueryMasterTask cache immediately, if it stored to persistent storage. (jhkim: rev ade06657807b26733e320ce515898b809f611700) tajo-core-tests/src/test/java/org/apache/tajo/master/TestQueryResult.java tajo-core-tests/src/test/java/org/apache/tajo/querymaster/TestTaskStatusUpdate.java tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java tajo-core-tests/src/test/java/org/apache/tajo/querymaster/TestQueryState.java tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java tajo-core/src/main/java/org/apache/tajo/worker/TajoWorkerClientService.java tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMaster.java tajo-core/src/main/java/org/apache/tajo/master/QueryManager.java tajo-cluster-tests/src/test/java/org/apache/tajo/TajoTestingCluster.java tajo-cluster-tests/src/test/java/org/apache/tajo/QueryTestCaseBase.java CHANGES tajo-core/src/main/java/org/apache/tajo/util/history/HistoryWriter.java tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestGroupByQuery.java

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development