Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Cannot Reproduce
    • Affects Version/s: None
    • Fix Version/s: 0.11.0, 0.12.0
    • Component/s: None
    • Labels:
      None

      Description

      This patch eliminates PlanningException, IllegalQueryStateException, InvalidQueryException and their usages.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/702

        TAJO-1787: Remove unused and legacy exceptions.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-1787

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/702.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #702


        commit 9b262df9e1987808067c7adcd583c44368f6c1ed
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-08-19T14:49:23Z

        TAJO-1787: Remove unused and legacy exceptions.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/702 TAJO-1787 : Remove unused and legacy exceptions. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1787 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/702.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #702 commit 9b262df9e1987808067c7adcd583c44368f6c1ed Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-08-19T14:49:23Z TAJO-1787 : Remove unused and legacy exceptions.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/702#issuecomment-132851202

        Trigger CI please? Maybe Failure is OOM caused by python tests

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/702#issuecomment-132851202 Trigger CI please? Maybe Failure is OOM caused by python tests
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/702#issuecomment-132875120

        I just triggered. Thanks!

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/702#issuecomment-132875120 I just triggered. Thanks!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/702#issuecomment-133000949

        +1 LGTM!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/702#issuecomment-133000949 +1 LGTM!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/702

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/702
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #451 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/451/)
        TAJO-1787: Remove unused and legacy exceptions. (hyunsik: rev 65283b541b7bd4779cdf9b32cc794f24c3123adb)

        • tajo-plan/src/main/java/org/apache/tajo/plan/util/PlannerUtil.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/PlanningException.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/NameResolver.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/global/rewriter/GlobalPlanRewriteRule.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/global/builder/DistinctGroupbyBuilder.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/global/rewriter/rules/GlobalPlanRewriteUtil.java
        • tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/ExplainPlanPreprocessorForTest.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/verifier/VerifyException.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/NonForwardQueryResultSystemScanner.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/Repartitioner.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/joinorder/JoinOrderAlgorithm.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/InvalidQueryException.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/IllegalQueryStatusException.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/global/rewriter/rules/BroadcastJoinRule.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SortIntersectExec.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/FilterPushDownRule.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/UnionExec.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/expr/AlgebraicUtil.java
        • CHANGES
        • tajo-plan/src/main/java/org/apache/tajo/plan/joinorder/GreedyHeuristicJoinOrderAlgorithm.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #451 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/451/ ) TAJO-1787 : Remove unused and legacy exceptions. (hyunsik: rev 65283b541b7bd4779cdf9b32cc794f24c3123adb) tajo-plan/src/main/java/org/apache/tajo/plan/util/PlannerUtil.java tajo-plan/src/main/java/org/apache/tajo/plan/PlanningException.java tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/NameResolver.java tajo-core/src/main/java/org/apache/tajo/engine/planner/global/rewriter/GlobalPlanRewriteRule.java tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java tajo-core/src/main/java/org/apache/tajo/engine/planner/global/builder/DistinctGroupbyBuilder.java tajo-core/src/main/java/org/apache/tajo/engine/planner/global/rewriter/rules/GlobalPlanRewriteUtil.java tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java tajo-core/src/main/java/org/apache/tajo/master/exec/ExplainPlanPreprocessorForTest.java tajo-plan/src/main/java/org/apache/tajo/plan/verifier/VerifyException.java tajo-core/src/main/java/org/apache/tajo/master/exec/NonForwardQueryResultSystemScanner.java tajo-core/src/main/java/org/apache/tajo/querymaster/Repartitioner.java tajo-plan/src/main/java/org/apache/tajo/plan/joinorder/JoinOrderAlgorithm.java tajo-plan/src/main/java/org/apache/tajo/plan/InvalidQueryException.java tajo-plan/src/main/java/org/apache/tajo/plan/IllegalQueryStatusException.java tajo-core/src/main/java/org/apache/tajo/engine/planner/global/rewriter/rules/BroadcastJoinRule.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SortIntersectExec.java tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/FilterPushDownRule.java tajo-core-tests/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/UnionExec.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/AlgebraicUtil.java CHANGES tajo-plan/src/main/java/org/apache/tajo/plan/joinorder/GreedyHeuristicJoinOrderAlgorithm.java
        Hide
        hyunsik Hyunsik Choi added a comment -

        I just committed it to branch-0.11.0 and master branch. thank you for the quick review.

        Show
        hyunsik Hyunsik Choi added a comment - I just committed it to branch-0.11.0 and master branch. thank you for the quick review.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-build #812 (See https://builds.apache.org/job/Tajo-master-build/812/)
        TAJO-1787: Remove unused and legacy exceptions. (hyunsik: rev 65283b541b7bd4779cdf9b32cc794f24c3123adb)

        • tajo-core/src/main/java/org/apache/tajo/engine/planner/global/rewriter/rules/BroadcastJoinRule.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/UnionExec.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/joinorder/JoinOrderAlgorithm.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/NameResolver.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/global/rewriter/GlobalPlanRewriteRule.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SortIntersectExec.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/verifier/VerifyException.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/NonForwardQueryResultSystemScanner.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/util/PlannerUtil.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/FilterPushDownRule.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/PlanningException.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/Repartitioner.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/expr/AlgebraicUtil.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/ExplainPlanPreprocessorForTest.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/global/rewriter/rules/GlobalPlanRewriteUtil.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/InvalidQueryException.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/IllegalQueryStatusException.java
        • CHANGES
        • tajo-plan/src/main/java/org/apache/tajo/plan/joinorder/GreedyHeuristicJoinOrderAlgorithm.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/global/builder/DistinctGroupbyBuilder.java
        • tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-build #812 (See https://builds.apache.org/job/Tajo-master-build/812/ ) TAJO-1787 : Remove unused and legacy exceptions. (hyunsik: rev 65283b541b7bd4779cdf9b32cc794f24c3123adb) tajo-core/src/main/java/org/apache/tajo/engine/planner/global/rewriter/rules/BroadcastJoinRule.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/UnionExec.java tajo-plan/src/main/java/org/apache/tajo/plan/joinorder/JoinOrderAlgorithm.java tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/NameResolver.java tajo-core/src/main/java/org/apache/tajo/engine/planner/global/rewriter/GlobalPlanRewriteRule.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SortIntersectExec.java tajo-plan/src/main/java/org/apache/tajo/plan/verifier/VerifyException.java tajo-core-tests/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java tajo-core/src/main/java/org/apache/tajo/master/exec/NonForwardQueryResultSystemScanner.java tajo-plan/src/main/java/org/apache/tajo/plan/util/PlannerUtil.java tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/FilterPushDownRule.java tajo-plan/src/main/java/org/apache/tajo/plan/PlanningException.java tajo-core/src/main/java/org/apache/tajo/querymaster/Repartitioner.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/AlgebraicUtil.java tajo-core/src/main/java/org/apache/tajo/master/exec/ExplainPlanPreprocessorForTest.java tajo-core/src/main/java/org/apache/tajo/engine/planner/global/rewriter/rules/GlobalPlanRewriteUtil.java tajo-plan/src/main/java/org/apache/tajo/plan/InvalidQueryException.java tajo-plan/src/main/java/org/apache/tajo/plan/IllegalQueryStatusException.java CHANGES tajo-plan/src/main/java/org/apache/tajo/plan/joinorder/GreedyHeuristicJoinOrderAlgorithm.java tajo-core/src/main/java/org/apache/tajo/engine/planner/global/builder/DistinctGroupbyBuilder.java tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development