Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1783

Query result is not returned by invalid output path

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.11.0
    • Fix Version/s: 0.11.0
    • Component/s: TajoMaster
    • Labels:
      None

      Description

      A simple query returns a result from TajoMaster and partitioned table was applied by TAJO-1403. but TAJO-1403 is not thread-safe. because a output path is overwritten by other query

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jinossy opened a pull request:

        https://github.com/apache/tajo/pull/701

        TAJO-1783: Query result is not returned by invalid output path

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jinossy/tajo TAJO-1783

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/701.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #701


        commit aecace6ffab6de0604070740df1064aa0814c52a
        Author: Jinho Kim <jhkim@apache.org>
        Date: 2015-08-19T14:39:00Z

        TAJO-1783: Query result is not returned by invalid output path.

        commit cd1dfddae6a1336cf145f6e51faeafc786823ec9
        Author: Jinho Kim <jhkim@apache.org>
        Date: 2015-08-19T14:39:46Z

        Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1783


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/701 TAJO-1783 : Query result is not returned by invalid output path You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-1783 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/701.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #701 commit aecace6ffab6de0604070740df1064aa0814c52a Author: Jinho Kim <jhkim@apache.org> Date: 2015-08-19T14:39:00Z TAJO-1783 : Query result is not returned by invalid output path. commit cd1dfddae6a1336cf145f6e51faeafc786823ec9 Author: Jinho Kim <jhkim@apache.org> Date: 2015-08-19T14:39:46Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1783
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/701#issuecomment-133008762

        I just reviewed the patch. The change and its clean up look great to me.

        I tried to find non-forwarded tests on partitioned tables. I haven't found them. If they exist, could you let me know where they are?

        Actually, it's not your problem. But, I'd like to ensure that your change guarantees that non-forwarded scans work well on partitioned tables.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/701#issuecomment-133008762 I just reviewed the patch. The change and its clean up look great to me. I tried to find non-forwarded tests on partitioned tables. I haven't found them. If they exist, could you let me know where they are? Actually, it's not your problem. But, I'd like to ensure that your change guarantees that non-forwarded scans work well on partitioned tables.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/701#issuecomment-133257810

        You can find it like testColumnPartitionedTableByThreeColumns in TestTablePartitions.
        https://github.com/apache/tajo/pull/431 does not allow the managed table. so it does not test the non-forwarded query.
        Anyway, I’m going to add TestSimpleQuery

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/701#issuecomment-133257810 You can find it like testColumnPartitionedTableByThreeColumns in TestTablePartitions. https://github.com/apache/tajo/pull/431 does not allow the managed table. so it does not test the non-forwarded query. Anyway, I’m going to add TestSimpleQuery
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/701#issuecomment-133410328

        +1
        The patch looks great to me. The patch seems to include unit tests to verify the things you changed.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/701#issuecomment-133410328 +1 The patch looks great to me. The patch seems to include unit tests to verify the things you changed.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/701

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/701
        Hide
        jhkim Jinho Kim added a comment -

        committed it
        Thanks for your review!

        Show
        jhkim Jinho Kim added a comment - committed it Thanks for your review!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #461 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/461/)
        TAJO-1783: Query result is not returned by invalid output path. (jhkim: rev 45ca4993db3659206846b8815ae9a4c091ca0c36)

        • tajo-core/src/main/java/org/apache/tajo/master/exec/NonForwardQueryResultFileScanner.java
        • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/Tablespace.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/PartitionedTableRewriter.java
        • tajo-core-tests/src/test/resources/results/TestSimpleQuery/testNoWhere.result
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/FileTablespace.java
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestSimpleQuery.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java
        • tajo-core-tests/src/test/resources/results/TestSimpleQuery/testPartitionColumnWhere.result
        • tajo-core/src/main/java/org/apache/tajo/master/exec/NonForwardQueryResultScanner.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/expr/EvalTreeUtil.java
        • tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/QueryResultResource.java
        • tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseTablespace.java
        • tajo-core-tests/src/test/resources/results/TestSimpleQuery/testWhere.result
        • CHANGES
        • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/AccessPathRewriter.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/util/PlannerUtil.java
        • tajo-core-tests/src/test/resources/results/TestSimpleQuery/testLimit.result
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestHBaseTable.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #461 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/461/ ) TAJO-1783 : Query result is not returned by invalid output path. (jhkim: rev 45ca4993db3659206846b8815ae9a4c091ca0c36) tajo-core/src/main/java/org/apache/tajo/master/exec/NonForwardQueryResultFileScanner.java tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/Tablespace.java tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/PartitionedTableRewriter.java tajo-core-tests/src/test/resources/results/TestSimpleQuery/testNoWhere.result tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/FileTablespace.java tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestSimpleQuery.java tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java tajo-core-tests/src/test/resources/results/TestSimpleQuery/testPartitionColumnWhere.result tajo-core/src/main/java/org/apache/tajo/master/exec/NonForwardQueryResultScanner.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/EvalTreeUtil.java tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/QueryResultResource.java tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseTablespace.java tajo-core-tests/src/test/resources/results/TestSimpleQuery/testWhere.result CHANGES tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/AccessPathRewriter.java tajo-plan/src/main/java/org/apache/tajo/plan/util/PlannerUtil.java tajo-core-tests/src/test/resources/results/TestSimpleQuery/testLimit.result tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestHBaseTable.java
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-master-build #815 (See https://builds.apache.org/job/Tajo-master-build/815/)
        TAJO-1783: Query result is not returned by invalid output path. (jhkim: rev 45ca4993db3659206846b8815ae9a4c091ca0c36)

        • tajo-plan/src/main/java/org/apache/tajo/plan/expr/EvalTreeUtil.java
        • tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseTablespace.java
        • tajo-core-tests/src/test/resources/results/TestSimpleQuery/testPartitionColumnWhere.result
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestHBaseTable.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/PartitionedTableRewriter.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java
        • tajo-core-tests/src/test/resources/results/TestSimpleQuery/testWhere.result
        • tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/QueryResultResource.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/FileTablespace.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/NonForwardQueryResultScanner.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/AccessPathRewriter.java
        • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/Tablespace.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/NonForwardQueryResultFileScanner.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/util/PlannerUtil.java
        • tajo-core-tests/src/test/resources/results/TestSimpleQuery/testNoWhere.result
        • CHANGES
        • tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestSimpleQuery.java
        • tajo-core-tests/src/test/resources/results/TestSimpleQuery/testLimit.result
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-build #815 (See https://builds.apache.org/job/Tajo-master-build/815/ ) TAJO-1783 : Query result is not returned by invalid output path. (jhkim: rev 45ca4993db3659206846b8815ae9a4c091ca0c36) tajo-plan/src/main/java/org/apache/tajo/plan/expr/EvalTreeUtil.java tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseTablespace.java tajo-core-tests/src/test/resources/results/TestSimpleQuery/testPartitionColumnWhere.result tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestHBaseTable.java tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/PartitionedTableRewriter.java tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java tajo-core-tests/src/test/resources/results/TestSimpleQuery/testWhere.result tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/QueryResultResource.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/FileTablespace.java tajo-core/src/main/java/org/apache/tajo/master/exec/NonForwardQueryResultScanner.java tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/AccessPathRewriter.java tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/Tablespace.java tajo-core/src/main/java/org/apache/tajo/master/exec/NonForwardQueryResultFileScanner.java tajo-plan/src/main/java/org/apache/tajo/plan/util/PlannerUtil.java tajo-core-tests/src/test/resources/results/TestSimpleQuery/testNoWhere.result CHANGES tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestSimpleQuery.java tajo-core-tests/src/test/resources/results/TestSimpleQuery/testLimit.result

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development