Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1779

Remove "DFSInputStream has been closed already" messages in DelimitedLineReader

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.11.0
    • Fix Version/s: 0.11.0, 0.12.0
    • Component/s: Storage
    • Labels:
      None

      Description

      We was upgrade the hadoop dependency to 2.7.1 in TAJO-1750
      I found “DFSInputStream has been closed already” message too many.
      We should remove the duplicate invoking of DFSInputStream.close in DelimitedLineReader

      https://issues.apache.org/jira/browse/HDFS-8099

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jinossy opened a pull request:

        https://github.com/apache/tajo/pull/697

        TAJO-1779: Remove "DFSInputStream has been closed already" messages i…

        …n DelimitedLineReader

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jinossy/tajo TAJO-1779

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/697.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #697


        commit f687029710f45adc5e46bf248a0b9e86aac3a5e5
        Author: Jinho Kim <jhkim@apache.org>
        Date: 2015-08-17T08:33:55Z

        TAJO-1779: Remove "DFSInputStream has been closed already" messages in DelimitedLineReader


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/697 TAJO-1779 : Remove "DFSInputStream has been closed already" messages i… …n DelimitedLineReader You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-1779 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/697.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #697 commit f687029710f45adc5e46bf248a0b9e86aac3a5e5 Author: Jinho Kim <jhkim@apache.org> Date: 2015-08-17T08:33:55Z TAJO-1779 : Remove "DFSInputStream has been closed already" messages in DelimitedLineReader
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/697#issuecomment-131745330

        +1

        The patch looks straightforward.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/697#issuecomment-131745330 +1 The patch looks straightforward.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/697

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/697
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #442 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/442/)
        TAJO-1779: Remove "DFSInputStream has been closed already" messages in DelimitedLineReader. (jhkim: rev 175f3f01684483b60c6afd48a0f50f1c3ae74953)

        • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/FSDataInputChannel.java
        • CHANGES
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/text/DelimitedLineReader.java
        • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/ByteBufInputChannel.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestLineReader.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #442 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/442/ ) TAJO-1779 : Remove "DFSInputStream has been closed already" messages in DelimitedLineReader. (jhkim: rev 175f3f01684483b60c6afd48a0f50f1c3ae74953) tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/FSDataInputChannel.java CHANGES tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/text/DelimitedLineReader.java tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/ByteBufInputChannel.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestLineReader.java
        Hide
        jhkim Jinho Kim added a comment -

        committed it
        Thanks for your quick review!

        Show
        jhkim Jinho Kim added a comment - committed it Thanks for your quick review!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #803 (See https://builds.apache.org/job/Tajo-master-build/803/)
        TAJO-1779: Remove "DFSInputStream has been closed already" messages in DelimitedLineReader. (jhkim: rev 175f3f01684483b60c6afd48a0f50f1c3ae74953)

        • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/FSDataInputChannel.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/text/DelimitedLineReader.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestLineReader.java
        • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/ByteBufInputChannel.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #803 (See https://builds.apache.org/job/Tajo-master-build/803/ ) TAJO-1779 : Remove "DFSInputStream has been closed already" messages in DelimitedLineReader. (jhkim: rev 175f3f01684483b60c6afd48a0f50f1c3ae74953) tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/FSDataInputChannel.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/text/DelimitedLineReader.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestLineReader.java tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/ByteBufInputChannel.java CHANGES

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development