Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: Catalog, Java Client
    • Labels:
      None

      Description

      This patch includes lots of API changes in terms of only exceptions. In overall, this patch changes throwable exceptions for APIs and unit tests to ensure that the APIs throws exact exceptions.

      In sum, this patch includes the following changes:

      • Rename TajoExceptionInterface to DefaultTajoException.
      • Rename UnImplementedException to NotImplementedException.
      • Replace CatalogException by TajoException
      • Move almost TajoException/TajoRunException in tajo-core into tajo-common
      • Remove CatalogException and CatalogExceptionUtil
      • Add throwable exception to all APIs in TajoClient, QueryClient, CatalogService, and CatalogAdminClient.
      • Refine all client implementations to throw received exception exactly.
      • Add negative unit tests for all APIs of them
      • Refine Client API v2 to handle exceptional cases like query failed, and killed.
      • Add query fail and kill tests for Client v2

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/680

        TAJO-1748: Refine client APIs to throw specific exceptions.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-1748

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/680.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #680


        commit 874227f26e89f0327e0e54c42a3e0af6da701f1f
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-08-07T13:12:20Z

        Refined catalog APIs' exceptions.

        commit 070191e871a0a3d73e093863fd7c3f4b78d32a52
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-08-07T15:49:49Z

        Add unit tests for QueryClient and CatalogAdminClient.

        commit e80a72223056086d08e4a10b1f1e85b40128eae2
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-08-08T03:06:49Z

        Cleanup CLI errors.

        commit 12052252d6b4b6057ecf2870b0493159025f9969
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-08-08T07:43:14Z

        Improved TajoCli's error handling through client API v1.

        commit 0989cd5da73413877c19fe0d01e0d517e6c18ec9
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-08-08T14:05:48Z

        Add error handling to client v2 for failed and killed queries.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/680 TAJO-1748 : Refine client APIs to throw specific exceptions. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1748 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/680.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #680 commit 874227f26e89f0327e0e54c42a3e0af6da701f1f Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-08-07T13:12:20Z Refined catalog APIs' exceptions. commit 070191e871a0a3d73e093863fd7c3f4b78d32a52 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-08-07T15:49:49Z Add unit tests for QueryClient and CatalogAdminClient. commit e80a72223056086d08e4a10b1f1e85b40128eae2 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-08-08T03:06:49Z Cleanup CLI errors. commit 12052252d6b4b6057ecf2870b0493159025f9969 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-08-08T07:43:14Z Improved TajoCli's error handling through client API v1. commit 0989cd5da73413877c19fe0d01e0d517e6c18ec9 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-08-08T14:05:48Z Add error handling to client v2 for failed and killed queries.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36608658

        — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java —
        @@ -140,13 +143,14 @@ public final Boolean existTablespace(final String tablespaceName) {
        }

        @Override

        • public TablespaceProto getTablespace(final String tablespaceName) {
          + public TablespaceProto getTablespace(final String tablespaceName) throws UndefinedTableException {
            • End diff –

        This method should throw UndefinedTablespaceException.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36608658 — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java — @@ -140,13 +143,14 @@ public final Boolean existTablespace(final String tablespaceName) { } @Override public TablespaceProto getTablespace(final String tablespaceName) { + public TablespaceProto getTablespace(final String tablespaceName) throws UndefinedTableException { End diff – This method should throw UndefinedTablespaceException.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36608669

        — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java —
        @@ -140,13 +143,14 @@ public final Boolean existTablespace(final String tablespaceName) {
        }

        @Override

        • public TablespaceProto getTablespace(final String tablespaceName) {
          + public TablespaceProto getTablespace(final String tablespaceName) throws UndefinedTableException {

        try {
        final BlockingInterface stub = getStub();
        final GetTablespaceResponse response = stub.getTablespace(null, ProtoUtil.convertString(tablespaceName));

        • ensureOk(response.getState());

        + throwsIfThisError(response.getState(), UndefinedTableException.class);
        — End diff –

        This method should throw UndefinedTablespaceException.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36608669 — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java — @@ -140,13 +143,14 @@ public final Boolean existTablespace(final String tablespaceName) { } @Override public TablespaceProto getTablespace(final String tablespaceName) { + public TablespaceProto getTablespace(final String tablespaceName) throws UndefinedTableException { try { final BlockingInterface stub = getStub(); final GetTablespaceResponse response = stub.getTablespace(null, ProtoUtil.convertString(tablespaceName)); ensureOk(response.getState()); + throwsIfThisError(response.getState(), UndefinedTableException.class); — End diff – This method should throw UndefinedTablespaceException.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36609330

        — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java —
        @@ -343,14 +358,18 @@ public TableDesc getTableDesc(String qualifiedName) {
        }

        @Override

        • public final PartitionMethodDesc getPartitionMethod(final String databaseName, final String tableName) {
          + public final PartitionMethodDesc getPartitionMethod(final String databaseName, final String tableName)
          + throws UndefinedPartitionMethodException, UndefinedTableException {
            • End diff –

        It seems that ```UndefinedDatabaseException``` can also occur.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36609330 — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java — @@ -343,14 +358,18 @@ public TableDesc getTableDesc(String qualifiedName) { } @Override public final PartitionMethodDesc getPartitionMethod(final String databaseName, final String tableName) { + public final PartitionMethodDesc getPartitionMethod(final String databaseName, final String tableName) + throws UndefinedPartitionMethodException, UndefinedTableException { End diff – It seems that ```UndefinedDatabaseException``` can also occur.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36609336

        — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java —
        @@ -359,11 +378,20 @@ public final PartitionMethodDesc getPartitionMethod(final String databaseName, f
        }

        @Override

        • public final boolean existPartitionMethod(final String databaseName, final String tableName) {
          + public final boolean existPartitionMethod(final String databaseName, final String tableName)
          + throws UndefinedTableException {
            • End diff –

        It seems that ```UndefinedDatabaseException``` can also occur.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36609336 — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java — @@ -359,11 +378,20 @@ public final PartitionMethodDesc getPartitionMethod(final String databaseName, f } @Override public final boolean existPartitionMethod(final String databaseName, final String tableName) { + public final boolean existPartitionMethod(final String databaseName, final String tableName) + throws UndefinedTableException { End diff – It seems that ```UndefinedDatabaseException``` can also occur.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36609449

        — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java —
        @@ -372,7 +400,8 @@ public final boolean existPartitionMethod(final String databaseName, final Strin

        @Override
        public final PartitionDescProto getPartition(final String databaseName, final String tableName,

        • final String partitionName) throws UndefinedPartitionException {
          + final String partitionName)
          + throws UndefinedPartitionException, UndefinedPartitionMethodException {
            • End diff –

        It seems that ```UndefinedDatabaseException``` and ```UndefinedTableExeption``` can also occur.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36609449 — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java — @@ -372,7 +400,8 @@ public final boolean existPartitionMethod(final String databaseName, final Strin @Override public final PartitionDescProto getPartition(final String databaseName, final String tableName, final String partitionName) throws UndefinedPartitionException { + final String partitionName) + throws UndefinedPartitionException, UndefinedPartitionMethodException { End diff – It seems that ```UndefinedDatabaseException``` and ```UndefinedTableExeption``` can also occur.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36609456

        — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java —
        @@ -380,15 +409,11 @@ public final PartitionDescProto getPartition(final String databaseName, final St
        .setTableName(tableName)
        .setPartitionName(partitionName)
        .build();
        -
        final GetPartitionDescResponse response = stub.getPartitionByPartitionName(null, request);

        • if (ReturnStateUtil.isThisError(response.getState(), ResultCode.UNDEFINED_PARTITION)) { - throw new UndefinedPartitionException(partitionName); - }

          -
          + throwsIfThisError(response.getState(), UndefinedPartitionMethodException.class);
          + throwsIfThisError(response.getState(), UndefinedPartitionException.class);

            • End diff –

        It seems that UndefinedDatabaseException and UndefinedTableExeption can also occur.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36609456 — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java — @@ -380,15 +409,11 @@ public final PartitionDescProto getPartition(final String databaseName, final St .setTableName(tableName) .setPartitionName(partitionName) .build(); - final GetPartitionDescResponse response = stub.getPartitionByPartitionName(null, request); if (ReturnStateUtil.isThisError(response.getState(), ResultCode.UNDEFINED_PARTITION)) { - throw new UndefinedPartitionException(partitionName); - } - + throwsIfThisError(response.getState(), UndefinedPartitionMethodException.class); + throwsIfThisError(response.getState(), UndefinedPartitionException.class); End diff – It seems that UndefinedDatabaseException and UndefinedTableExeption can also occur.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36609654

        — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java —
        @@ -430,27 +454,32 @@ public final PartitionDescProto getPartition(final String databaseName, final St
        }

        @Override

        • public boolean addPartitions(String databaseName, String tableName, List<PartitionDescProto> partitions
        • , boolean ifNotExists) {
          + public void addPartitions(String databaseName, String tableName, List<PartitionDescProto> partitions,
          + boolean ifNotExists) throws UndefinedTableException, DuplicatePartitionException,
          + UndefinedPartitionMethodException {
            • End diff –

        ```UndefinedDatabaseException``` also should be handled.
        In addition, ```DuplicatePartitionException``` is missed at CatalogServer.addPartitions(). It would be great if you add it.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36609654 — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java — @@ -430,27 +454,32 @@ public final PartitionDescProto getPartition(final String databaseName, final St } @Override public boolean addPartitions(String databaseName, String tableName, List<PartitionDescProto> partitions , boolean ifNotExists) { + public void addPartitions(String databaseName, String tableName, List<PartitionDescProto> partitions, + boolean ifNotExists) throws UndefinedTableException, DuplicatePartitionException, + UndefinedPartitionMethodException { End diff – ```UndefinedDatabaseException``` also should be handled. In addition, ```DuplicatePartitionException``` is missed at CatalogServer.addPartitions(). It would be great if you add it.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36609754

        — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java —
        @@ -471,31 +500,35 @@ public boolean addPartitions(String databaseName, String tableName, List<Partiti
        @Override
        public final Collection<FunctionDesc> getFunctions() {
        List<FunctionDesc> list = new ArrayList<FunctionDesc>();
        +
        try {

        • GetFunctionsResponse response;
        • BlockingInterface stub = getStub();
        • response = stub.getFunctions(null, NullProto.newBuilder().build());
        • int size = response.getFunctionDescCount();
        • for (int i = 0; i < size; i++) {
          + final BlockingInterface stub = getStub();
          + final GetFunctionsResponse response = stub.getFunctions(null, NullProto.newBuilder().build());
          +
          + ensureOk(response.getState());
          + for (int i = 0; i < response.getFunctionDescCount(); i++)
          Unknown macro: { try { list.add(new FunctionDesc(response.getFunctionDesc(i))); } catch (ClassNotFoundException e) { - LOG.error(e, e); - return list; + throw new RuntimeException(e); } }

          return list;
          +
          } catch (ServiceException e)

          { throw new RuntimeException(e); }

          }

        @Override

        • public final boolean createTable(final TableDesc desc) {
          + public final void createTable(final TableDesc desc) throws DuplicateTableException, InsufficientPrivilegeException {
            • End diff –

        ```UndefinedDatabaseException``` should be handled.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36609754 — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java — @@ -471,31 +500,35 @@ public boolean addPartitions(String databaseName, String tableName, List<Partiti @Override public final Collection<FunctionDesc> getFunctions() { List<FunctionDesc> list = new ArrayList<FunctionDesc>(); + try { GetFunctionsResponse response; BlockingInterface stub = getStub(); response = stub.getFunctions(null, NullProto.newBuilder().build()); int size = response.getFunctionDescCount(); for (int i = 0; i < size; i++) { + final BlockingInterface stub = getStub(); + final GetFunctionsResponse response = stub.getFunctions(null, NullProto.newBuilder().build()); + + ensureOk(response.getState()); + for (int i = 0; i < response.getFunctionDescCount(); i++) Unknown macro: { try { list.add(new FunctionDesc(response.getFunctionDesc(i))); } catch (ClassNotFoundException e) { - LOG.error(e, e); - return list; + throw new RuntimeException(e); } } return list; + } catch (ServiceException e) { throw new RuntimeException(e); } } @Override public final boolean createTable(final TableDesc desc) { + public final void createTable(final TableDesc desc) throws DuplicateTableException, InsufficientPrivilegeException { End diff – ```UndefinedDatabaseException``` should be handled.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36609776

        — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java —
        @@ -503,7 +536,7 @@ public final boolean createTable(final TableDesc desc) {
        }

        @Override

        • public boolean dropTable(String tableName) {
          + public void dropTable(String tableName) throws UndefinedTableException, InsufficientPrivilegeException {
            • End diff –

        ```UndefinedDatabaseException``` should be handled.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36609776 — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java — @@ -503,7 +536,7 @@ public final boolean createTable(final TableDesc desc) { } @Override public boolean dropTable(String tableName) { + public void dropTable(String tableName) throws UndefinedTableException, InsufficientPrivilegeException { End diff – ```UndefinedDatabaseException``` should be handled.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36609840

        — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java —
        @@ -720,15 +764,18 @@ public final boolean createFunction(final FunctionDesc funcDesc) {
        }

        @Override

        • public final boolean dropFunction(final String signature) {
          + public final void dropFunction(final String signature) throws UndefinedFunctionException, InsufficientPrivilegeException {
            • End diff –

        This line exceeds the row width limit.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36609840 — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java — @@ -720,15 +764,18 @@ public final boolean createFunction(final FunctionDesc funcDesc) { } @Override public final boolean dropFunction(final String signature) { + public final void dropFunction(final String signature) throws UndefinedFunctionException, InsufficientPrivilegeException { End diff – This line exceeds the row width limit.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36610170

        — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java —
        @@ -754,26 +801,19 @@ public final FunctionDesc getFunction(final String signature, FunctionType funcT
        builder.addParameterTypes(type);
        }

        • FunctionResponse response = null;
          try { final BlockingInterface stub = getStub(); - response = stub.getFunctionMeta(null, builder.build()); - }

          catch (ServiceException se)

          { - throw new RuntimeException(se); - }

          -

        • if (isThisError(response.getState(), ResultCode.UNDEFINED_FUNCTION)) { - throw new UndefinedFunctionException(signature, paramTypes); - }

          else if (isThisError(response.getState(), ResultCode.AMBIGUOUS_FUNCTION))

          { - throw new AmbiguousFunctionException(signature, paramTypes); - }

          + final FunctionResponse response = stub.getFunctionMeta(null, builder.build());

            • End diff –

        If there are several functions of the given name, getFunctionMeta() always throws a function which has the nearest argument among them instead of throwing ```AmbiguousFunctionException```.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36610170 — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java — @@ -754,26 +801,19 @@ public final FunctionDesc getFunction(final String signature, FunctionType funcT builder.addParameterTypes(type); } FunctionResponse response = null; try { final BlockingInterface stub = getStub(); - response = stub.getFunctionMeta(null, builder.build()); - } catch (ServiceException se) { - throw new RuntimeException(se); - } - if (isThisError(response.getState(), ResultCode.UNDEFINED_FUNCTION)) { - throw new UndefinedFunctionException(signature, paramTypes); - } else if (isThisError(response.getState(), ResultCode.AMBIGUOUS_FUNCTION)) { - throw new AmbiguousFunctionException(signature, paramTypes); - } + final FunctionResponse response = stub.getFunctionMeta(null, builder.build()); End diff – If there are several functions of the given name, getFunctionMeta() always throws a function which has the nearest argument among them instead of throwing ```AmbiguousFunctionException```.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36610932

        — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java —
        @@ -805,11 +851,19 @@ public final boolean containFunction(final String signature, FunctionType funcTy
        }

        @Override

        • public final boolean alterTable(final AlterTableDesc desc) {
          + public final void alterTable(final AlterTableDesc desc) throws UndefinedTableException, DuplicateColumnException,
          + InsufficientPrivilegeException, DuplicateTableException {

        try {
        final BlockingInterface stub = getStub();

        • return isSuccess(stub.alterTable(null, desc.getProto()));
          + final ReturnState state = stub.alterTable(null, desc.getProto());
            • End diff –

        CatalogServer.alterTable() throws only ```UndefinedTableException```. Did you add handling other exceptions for future work? Even though you did, I think that ```DuplicateTableException``` does not occur.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36610932 — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java — @@ -805,11 +851,19 @@ public final boolean containFunction(final String signature, FunctionType funcTy } @Override public final boolean alterTable(final AlterTableDesc desc) { + public final void alterTable(final AlterTableDesc desc) throws UndefinedTableException, DuplicateColumnException, + InsufficientPrivilegeException, DuplicateTableException { try { final BlockingInterface stub = getStub(); return isSuccess(stub.alterTable(null, desc.getProto())); + final ReturnState state = stub.alterTable(null, desc.getProto()); End diff – CatalogServer.alterTable() throws only ```UndefinedTableException```. Did you add handling other exceptions for future work? Even though you did, I think that ```DuplicateTableException``` does not occur.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36610946

        — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java —
        @@ -805,11 +851,19 @@ public final boolean containFunction(final String signature, FunctionType funcTy
        }

        @Override

        • public final boolean alterTable(final AlterTableDesc desc) {
          + public final void alterTable(final AlterTableDesc desc) throws UndefinedTableException, DuplicateColumnException,
          + InsufficientPrivilegeException, DuplicateTableException {

        try {
        final BlockingInterface stub = getStub();

        • return isSuccess(stub.alterTable(null, desc.getProto()));
          + final ReturnState state = stub.alterTable(null, desc.getProto());
          +
          + throwsIfThisError(state, DuplicateColumnException.class);
          + throwsIfThisError(state, DuplicateTableException.class);
          + throwsIfThisError(state, DuplicateColumnException.class);
            • End diff –

        ```DuplicateColumnException``` is handled twice.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36610946 — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java — @@ -805,11 +851,19 @@ public final boolean containFunction(final String signature, FunctionType funcTy } @Override public final boolean alterTable(final AlterTableDesc desc) { + public final void alterTable(final AlterTableDesc desc) throws UndefinedTableException, DuplicateColumnException, + InsufficientPrivilegeException, DuplicateTableException { try { final BlockingInterface stub = getStub(); return isSuccess(stub.alterTable(null, desc.getProto())); + final ReturnState state = stub.alterTable(null, desc.getProto()); + + throwsIfThisError(state, DuplicateColumnException.class); + throwsIfThisError(state, DuplicateTableException.class); + throwsIfThisError(state, DuplicateColumnException.class); End diff – ```DuplicateColumnException``` is handled twice.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36612071

        — Diff: tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClientImpl.java —
        @@ -164,21 +166,22 @@ public TableDesc createExternalTable(final String tableName, final Schema schema
        throw new RuntimeException(e);
        }

        • if (isThisError(res.getState(), Errors.ResultCode.DUPLICATE_TABLE)) { - throw new DuplicateTableException(res.getState()); - }

          + throwsIfThisError(res.getState(), DuplicateTableException.class);
          + throwsIfThisError(res.getState(), InsufficientPrivilegeException.class);

            • End diff –

        The above two exceptions should be properly thrown when TajoMasterClientService.createExternalTable() is called.
        For more detailed, these exceptions should be caught at the following code (TajoMasterClientService::887), and then thrown properly to handle them here.
        ```
        TableDesc desc = context.getGlobalEngine().getDDLExecutor().getCreateTableExecutor().create(
        queryContext,
        request.getName(),
        null,
        schema,
        meta,
        path.toUri(),
        true,
        partitionDesc,
        false
        );
        ```

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36612071 — Diff: tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClientImpl.java — @@ -164,21 +166,22 @@ public TableDesc createExternalTable(final String tableName, final Schema schema throw new RuntimeException(e); } if (isThisError(res.getState(), Errors.ResultCode.DUPLICATE_TABLE)) { - throw new DuplicateTableException(res.getState()); - } + throwsIfThisError(res.getState(), DuplicateTableException.class); + throwsIfThisError(res.getState(), InsufficientPrivilegeException.class); End diff – The above two exceptions should be properly thrown when TajoMasterClientService.createExternalTable() is called. For more detailed, these exceptions should be caught at the following code (TajoMasterClientService::887), and then thrown properly to handle them here. ``` TableDesc desc = context.getGlobalEngine().getDDLExecutor().getCreateTableExecutor().create( queryContext, request.getName(), null, schema, meta, path.toUri(), true, partitionDesc, false ); ```
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36612157

        — Diff: tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClientImpl.java —
        @@ -164,21 +166,22 @@ public TableDesc createExternalTable(final String tableName, final Schema schema
        throw new RuntimeException(e);
        }

        • if (isThisError(res.getState(), Errors.ResultCode.DUPLICATE_TABLE)) { - throw new DuplicateTableException(res.getState()); - }

          + throwsIfThisError(res.getState(), DuplicateTableException.class);
          + throwsIfThisError(res.getState(), InsufficientPrivilegeException.class);
          + throwsIfThisError(res.getState(), UnavailableTableLocationException.class);

        ensureOk(res.getState());
        return CatalogUtil.newTableDesc(res.getTable());
        }

        @Override

        • public boolean dropTable(String tableName) throws UndefinedTableException {
        • return dropTable(tableName, false);
          + public void dropTable(String tableName) throws UndefinedTableException, InsufficientPrivilegeException { + dropTable(tableName, false); }

        @Override

        • public boolean dropTable(final String tableName, final boolean purge) throws UndefinedTableException {
          + public void dropTable(final String tableName, final boolean purge)
          + throws UndefinedTableException, InsufficientPrivilegeException {
            • End diff –

        Similar to the case of the above ```createExternalTable```, these exceptions should be thrown properly at TajoMasterClientService.dropTable().

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36612157 — Diff: tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClientImpl.java — @@ -164,21 +166,22 @@ public TableDesc createExternalTable(final String tableName, final Schema schema throw new RuntimeException(e); } if (isThisError(res.getState(), Errors.ResultCode.DUPLICATE_TABLE)) { - throw new DuplicateTableException(res.getState()); - } + throwsIfThisError(res.getState(), DuplicateTableException.class); + throwsIfThisError(res.getState(), InsufficientPrivilegeException.class); + throwsIfThisError(res.getState(), UnavailableTableLocationException.class); ensureOk(res.getState()); return CatalogUtil.newTableDesc(res.getTable()); } @Override public boolean dropTable(String tableName) throws UndefinedTableException { return dropTable(tableName, false); + public void dropTable(String tableName) throws UndefinedTableException, InsufficientPrivilegeException { + dropTable(tableName, false); } @Override public boolean dropTable(final String tableName, final boolean purge) throws UndefinedTableException { + public void dropTable(final String tableName, final boolean purge) + throws UndefinedTableException, InsufficientPrivilegeException { End diff – Similar to the case of the above ```createExternalTable```, these exceptions should be thrown properly at TajoMasterClientService.dropTable().
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36612229

        — Diff: tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClientImpl.java —
        @@ -164,21 +166,22 @@ public TableDesc createExternalTable(final String tableName, final Schema schema
        throw new RuntimeException(e);
        }

        • if (isThisError(res.getState(), Errors.ResultCode.DUPLICATE_TABLE)) { - throw new DuplicateTableException(res.getState()); - }

          + throwsIfThisError(res.getState(), DuplicateTableException.class);
          + throwsIfThisError(res.getState(), InsufficientPrivilegeException.class);

            • End diff –

        I misunderstood some codes. Please forget this comment.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36612229 — Diff: tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClientImpl.java — @@ -164,21 +166,22 @@ public TableDesc createExternalTable(final String tableName, final Schema schema throw new RuntimeException(e); } if (isThisError(res.getState(), Errors.ResultCode.DUPLICATE_TABLE)) { - throw new DuplicateTableException(res.getState()); - } + throwsIfThisError(res.getState(), DuplicateTableException.class); + throwsIfThisError(res.getState(), InsufficientPrivilegeException.class); End diff – I misunderstood some codes. Please forget this comment.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36612232

        — Diff: tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClientImpl.java —
        @@ -164,21 +166,22 @@ public TableDesc createExternalTable(final String tableName, final Schema schema
        throw new RuntimeException(e);
        }

        • if (isThisError(res.getState(), Errors.ResultCode.DUPLICATE_TABLE)) { - throw new DuplicateTableException(res.getState()); - }

          + throwsIfThisError(res.getState(), DuplicateTableException.class);
          + throwsIfThisError(res.getState(), InsufficientPrivilegeException.class);
          + throwsIfThisError(res.getState(), UnavailableTableLocationException.class);

        ensureOk(res.getState());
        return CatalogUtil.newTableDesc(res.getTable());
        }

        @Override

        • public boolean dropTable(String tableName) throws UndefinedTableException {
        • return dropTable(tableName, false);
          + public void dropTable(String tableName) throws UndefinedTableException, InsufficientPrivilegeException { + dropTable(tableName, false); }

        @Override

        • public boolean dropTable(final String tableName, final boolean purge) throws UndefinedTableException {
          + public void dropTable(final String tableName, final boolean purge)
          + throws UndefinedTableException, InsufficientPrivilegeException {
            • End diff –

        I misunderstood some codes. Please forget this comment.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36612232 — Diff: tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClientImpl.java — @@ -164,21 +166,22 @@ public TableDesc createExternalTable(final String tableName, final Schema schema throw new RuntimeException(e); } if (isThisError(res.getState(), Errors.ResultCode.DUPLICATE_TABLE)) { - throw new DuplicateTableException(res.getState()); - } + throwsIfThisError(res.getState(), DuplicateTableException.class); + throwsIfThisError(res.getState(), InsufficientPrivilegeException.class); + throwsIfThisError(res.getState(), UnavailableTableLocationException.class); ensureOk(res.getState()); return CatalogUtil.newTableDesc(res.getTable()); } @Override public boolean dropTable(String tableName) throws UndefinedTableException { return dropTable(tableName, false); + public void dropTable(String tableName) throws UndefinedTableException, InsufficientPrivilegeException { + dropTable(tableName, false); } @Override public boolean dropTable(final String tableName, final boolean purge) throws UndefinedTableException { + public void dropTable(final String tableName, final boolean purge) + throws UndefinedTableException, InsufficientPrivilegeException { End diff – I misunderstood some codes. Please forget this comment.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36612494

        — Diff: tajo-client/src/main/java/org/apache/tajo/client/v2/ClientDelegate.java —
        @@ -31,7 +32,7 @@

        int executeUpdate(String sql) throws TajoException;

        • ResultSet executeSQL(String sql) throws TajoException;
          + ResultSet executeSQL(String sql) throws TajoException, QueryFailedException;
            • End diff –

        QueryFailedException extends TajoException, so it seems that it is not necessary.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36612494 — Diff: tajo-client/src/main/java/org/apache/tajo/client/v2/ClientDelegate.java — @@ -31,7 +32,7 @@ int executeUpdate(String sql) throws TajoException; ResultSet executeSQL(String sql) throws TajoException; + ResultSet executeSQL(String sql) throws TajoException, QueryFailedException; End diff – QueryFailedException extends TajoException, so it seems that it is not necessary.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36612511

        — Diff: tajo-client/src/main/java/org/apache/tajo/client/v2/LegacyClientDelegate.java —
        @@ -72,10 +72,20 @@ public int executeUpdate(String sql) throws TajoException {
        }

        @Override

        • public ResultSet executeSQL(String sql) throws TajoException {
          + public ResultSet executeSQL(String sql) throws TajoException, QueryFailedException, QueryKilledException {
            • End diff –

        The last two exceptions extend TajoException, so they looks not necessary.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36612511 — Diff: tajo-client/src/main/java/org/apache/tajo/client/v2/LegacyClientDelegate.java — @@ -72,10 +72,20 @@ public int executeUpdate(String sql) throws TajoException { } @Override public ResultSet executeSQL(String sql) throws TajoException { + public ResultSet executeSQL(String sql) throws TajoException, QueryFailedException, QueryKilledException { End diff – The last two exceptions extend TajoException, so they looks not necessary.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36612799

        — Diff: tajo-common/src/main/java/org/apache/tajo/exception/DuplicateFunctionException.java —
        @@ -0,0 +1,34 @@
        +/**
        + * Licensed to the Apache Software Foundation (ASF) under one
        + * or more contributor license agreements. See the NOTICE file
        + * distributed with this work for additional information
        + * regarding copyright ownership. The ASF licenses this file
        + * to you under the Apache License, Version 2.0 (the
        + * "License"); you may not use this file except in compliance
        + * with the License. You may obtain a copy of the License at
        + *
        + * http://www.apache.org/licenses/LICENSE-2.0
        + *
        + * Unless required by applicable law or agreed to in writing, software
        + * distributed under the License is distributed on an "AS IS" BASIS,
        + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
        + * See the License for the specific language governing permissions and
        + * limitations under the License.
        + */
        +
        +package org.apache.tajo.exception;
        +
        +import org.apache.tajo.error.Errors;
        +import org.apache.tajo.rpc.protocolrecords.PrimitiveProtos.ReturnState;
        +
        +public class DuplicateFunctionException extends TajoException {
        + private static final long serialVersionUID = 3224521585413794703L;
        +
        + public DuplicateFunctionException(ReturnState state)

        { + super(state); + }

        +
        + public DuplicateFunctionException(String signature) {
        — End diff –

        Please fix the indent.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36612799 — Diff: tajo-common/src/main/java/org/apache/tajo/exception/DuplicateFunctionException.java — @@ -0,0 +1,34 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.tajo.exception; + +import org.apache.tajo.error.Errors; +import org.apache.tajo.rpc.protocolrecords.PrimitiveProtos.ReturnState; + +public class DuplicateFunctionException extends TajoException { + private static final long serialVersionUID = 3224521585413794703L; + + public DuplicateFunctionException(ReturnState state) { + super(state); + } + + public DuplicateFunctionException(String signature) { — End diff – Please fix the indent.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36612885

        — Diff: tajo-common/src/main/proto/errors.proto —
        @@ -154,11 +157,15 @@ enum ResultCode {
        CAT_UPGRADE_REQUIRED = 901; // Migration
        CAT_CANNOT_CONNECT = 902; // Cannot connect metadata server

        • // MetaData Connector (MDC)
        • MDC_NO_MATCHED_DATATYPE = 910; // No matched data type between Tajo and connector
          + // Linked Metadata (MDC)
            • End diff –

        MDC should be changed to LMD.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36612885 — Diff: tajo-common/src/main/proto/errors.proto — @@ -154,11 +157,15 @@ enum ResultCode { CAT_UPGRADE_REQUIRED = 901; // Migration CAT_CANNOT_CONNECT = 902; // Cannot connect metadata server // MetaData Connector (MDC) MDC_NO_MATCHED_DATATYPE = 910; // No matched data type between Tajo and connector + // Linked Metadata (MDC) End diff – MDC should be changed to LMD.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/680#issuecomment-129375429

        @hyunsik, thanks for your work. Please consider my comments.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/680#issuecomment-129375429 @hyunsik, thanks for your work. Please consider my comments.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36826136

        — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java —
        @@ -140,13 +143,14 @@ public final Boolean existTablespace(final String tablespaceName) {
        }

        @Override

        • public TablespaceProto getTablespace(final String tablespaceName) {
          + public TablespaceProto getTablespace(final String tablespaceName) throws UndefinedTableException {
            • End diff –

        fixed

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36826136 — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java — @@ -140,13 +143,14 @@ public final Boolean existTablespace(final String tablespaceName) { } @Override public TablespaceProto getTablespace(final String tablespaceName) { + public TablespaceProto getTablespace(final String tablespaceName) throws UndefinedTableException { End diff – fixed
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36826146

        — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java —
        @@ -140,13 +143,14 @@ public final Boolean existTablespace(final String tablespaceName) {
        }

        @Override

        • public TablespaceProto getTablespace(final String tablespaceName) {
          + public TablespaceProto getTablespace(final String tablespaceName) throws UndefinedTableException {

        try {
        final BlockingInterface stub = getStub();
        final GetTablespaceResponse response = stub.getTablespace(null, ProtoUtil.convertString(tablespaceName));

        • ensureOk(response.getState());

        + throwsIfThisError(response.getState(), UndefinedTableException.class);
        — End diff –

        fixed

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36826146 — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java — @@ -140,13 +143,14 @@ public final Boolean existTablespace(final String tablespaceName) { } @Override public TablespaceProto getTablespace(final String tablespaceName) { + public TablespaceProto getTablespace(final String tablespaceName) throws UndefinedTableException { try { final BlockingInterface stub = getStub(); final GetTablespaceResponse response = stub.getTablespace(null, ProtoUtil.convertString(tablespaceName)); ensureOk(response.getState()); + throwsIfThisError(response.getState(), UndefinedTableException.class); — End diff – fixed
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36826443

        — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java —
        @@ -343,14 +358,18 @@ public TableDesc getTableDesc(String qualifiedName) {
        }

        @Override

        • public final PartitionMethodDesc getPartitionMethod(final String databaseName, final String tableName) {
          + public final PartitionMethodDesc getPartitionMethod(final String databaseName, final String tableName)
          + throws UndefinedPartitionMethodException, UndefinedTableException {
            • End diff –

        fixed

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36826443 — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java — @@ -343,14 +358,18 @@ public TableDesc getTableDesc(String qualifiedName) { } @Override public final PartitionMethodDesc getPartitionMethod(final String databaseName, final String tableName) { + public final PartitionMethodDesc getPartitionMethod(final String databaseName, final String tableName) + throws UndefinedPartitionMethodException, UndefinedTableException { End diff – fixed
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36827502

        — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java —
        @@ -359,11 +378,20 @@ public final PartitionMethodDesc getPartitionMethod(final String databaseName, f
        }

        @Override

        • public final boolean existPartitionMethod(final String databaseName, final String tableName) {
          + public final boolean existPartitionMethod(final String databaseName, final String tableName)
          + throws UndefinedTableException {
            • End diff –

        fixed

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36827502 — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java — @@ -359,11 +378,20 @@ public final PartitionMethodDesc getPartitionMethod(final String databaseName, f } @Override public final boolean existPartitionMethod(final String databaseName, final String tableName) { + public final boolean existPartitionMethod(final String databaseName, final String tableName) + throws UndefinedTableException { End diff – fixed
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36827516

        — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java —
        @@ -372,7 +400,8 @@ public final boolean existPartitionMethod(final String databaseName, final Strin

        @Override
        public final PartitionDescProto getPartition(final String databaseName, final String tableName,

        • final String partitionName) throws UndefinedPartitionException {
          + final String partitionName)
          + throws UndefinedPartitionException, UndefinedPartitionMethodException {
            • End diff –

        fixed

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36827516 — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java — @@ -372,7 +400,8 @@ public final boolean existPartitionMethod(final String databaseName, final Strin @Override public final PartitionDescProto getPartition(final String databaseName, final String tableName, final String partitionName) throws UndefinedPartitionException { + final String partitionName) + throws UndefinedPartitionException, UndefinedPartitionMethodException { End diff – fixed
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36827524

        — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java —
        @@ -380,15 +409,11 @@ public final PartitionDescProto getPartition(final String databaseName, final St
        .setTableName(tableName)
        .setPartitionName(partitionName)
        .build();
        -
        final GetPartitionDescResponse response = stub.getPartitionByPartitionName(null, request);

        • if (ReturnStateUtil.isThisError(response.getState(), ResultCode.UNDEFINED_PARTITION)) { - throw new UndefinedPartitionException(partitionName); - }

          -
          + throwsIfThisError(response.getState(), UndefinedPartitionMethodException.class);
          + throwsIfThisError(response.getState(), UndefinedPartitionException.class);

            • End diff –

        fixed

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36827524 — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java — @@ -380,15 +409,11 @@ public final PartitionDescProto getPartition(final String databaseName, final St .setTableName(tableName) .setPartitionName(partitionName) .build(); - final GetPartitionDescResponse response = stub.getPartitionByPartitionName(null, request); if (ReturnStateUtil.isThisError(response.getState(), ResultCode.UNDEFINED_PARTITION)) { - throw new UndefinedPartitionException(partitionName); - } - + throwsIfThisError(response.getState(), UndefinedPartitionMethodException.class); + throwsIfThisError(response.getState(), UndefinedPartitionException.class); End diff – fixed
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36936501

        — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java —
        @@ -430,27 +454,32 @@ public final PartitionDescProto getPartition(final String databaseName, final St
        }

        @Override

        • public boolean addPartitions(String databaseName, String tableName, List<PartitionDescProto> partitions
        • , boolean ifNotExists) {
          + public void addPartitions(String databaseName, String tableName, List<PartitionDescProto> partitions,
          + boolean ifNotExists) throws UndefinedTableException, DuplicatePartitionException,
          + UndefinedPartitionMethodException {
            • End diff –

        fixed

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36936501 — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java — @@ -430,27 +454,32 @@ public final PartitionDescProto getPartition(final String databaseName, final St } @Override public boolean addPartitions(String databaseName, String tableName, List<PartitionDescProto> partitions , boolean ifNotExists) { + public void addPartitions(String databaseName, String tableName, List<PartitionDescProto> partitions, + boolean ifNotExists) throws UndefinedTableException, DuplicatePartitionException, + UndefinedPartitionMethodException { End diff – fixed
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36936503

        — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java —
        @@ -471,31 +500,35 @@ public boolean addPartitions(String databaseName, String tableName, List<Partiti
        @Override
        public final Collection<FunctionDesc> getFunctions() {
        List<FunctionDesc> list = new ArrayList<FunctionDesc>();
        +
        try {

        • GetFunctionsResponse response;
        • BlockingInterface stub = getStub();
        • response = stub.getFunctions(null, NullProto.newBuilder().build());
        • int size = response.getFunctionDescCount();
        • for (int i = 0; i < size; i++) {
          + final BlockingInterface stub = getStub();
          + final GetFunctionsResponse response = stub.getFunctions(null, NullProto.newBuilder().build());
          +
          + ensureOk(response.getState());
          + for (int i = 0; i < response.getFunctionDescCount(); i++)
          Unknown macro: { try { list.add(new FunctionDesc(response.getFunctionDesc(i))); } catch (ClassNotFoundException e) { - LOG.error(e, e); - return list; + throw new RuntimeException(e); } }

          return list;
          +
          } catch (ServiceException e)

          { throw new RuntimeException(e); }

          }

        @Override

        • public final boolean createTable(final TableDesc desc) {
          + public final void createTable(final TableDesc desc) throws DuplicateTableException, InsufficientPrivilegeException {
            • End diff –

        fixed

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36936503 — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java — @@ -471,31 +500,35 @@ public boolean addPartitions(String databaseName, String tableName, List<Partiti @Override public final Collection<FunctionDesc> getFunctions() { List<FunctionDesc> list = new ArrayList<FunctionDesc>(); + try { GetFunctionsResponse response; BlockingInterface stub = getStub(); response = stub.getFunctions(null, NullProto.newBuilder().build()); int size = response.getFunctionDescCount(); for (int i = 0; i < size; i++) { + final BlockingInterface stub = getStub(); + final GetFunctionsResponse response = stub.getFunctions(null, NullProto.newBuilder().build()); + + ensureOk(response.getState()); + for (int i = 0; i < response.getFunctionDescCount(); i++) Unknown macro: { try { list.add(new FunctionDesc(response.getFunctionDesc(i))); } catch (ClassNotFoundException e) { - LOG.error(e, e); - return list; + throw new RuntimeException(e); } } return list; + } catch (ServiceException e) { throw new RuntimeException(e); } } @Override public final boolean createTable(final TableDesc desc) { + public final void createTable(final TableDesc desc) throws DuplicateTableException, InsufficientPrivilegeException { End diff – fixed
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36936509

        — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java —
        @@ -503,7 +536,7 @@ public final boolean createTable(final TableDesc desc) {
        }

        @Override

        • public boolean dropTable(String tableName) {
          + public void dropTable(String tableName) throws UndefinedTableException, InsufficientPrivilegeException {
            • End diff –

        fixed

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36936509 — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java — @@ -503,7 +536,7 @@ public final boolean createTable(final TableDesc desc) { } @Override public boolean dropTable(String tableName) { + public void dropTable(String tableName) throws UndefinedTableException, InsufficientPrivilegeException { End diff – fixed
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36936522

        — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java —
        @@ -720,15 +764,18 @@ public final boolean createFunction(final FunctionDesc funcDesc) {
        }

        @Override

        • public final boolean dropFunction(final String signature) {
          + public final void dropFunction(final String signature) throws UndefinedFunctionException, InsufficientPrivilegeException {
            • End diff –

        fixed

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36936522 — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java — @@ -720,15 +764,18 @@ public final boolean createFunction(final FunctionDesc funcDesc) { } @Override public final boolean dropFunction(final String signature) { + public final void dropFunction(final String signature) throws UndefinedFunctionException, InsufficientPrivilegeException { End diff – fixed
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36937244

        — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java —
        @@ -754,26 +801,19 @@ public final FunctionDesc getFunction(final String signature, FunctionType funcT
        builder.addParameterTypes(type);
        }

        • FunctionResponse response = null;
          try { final BlockingInterface stub = getStub(); - response = stub.getFunctionMeta(null, builder.build()); - }

          catch (ServiceException se)

          { - throw new RuntimeException(se); - }

          -

        • if (isThisError(response.getState(), ResultCode.UNDEFINED_FUNCTION)) { - throw new UndefinedFunctionException(signature, paramTypes); - }

          else if (isThisError(response.getState(), ResultCode.AMBIGUOUS_FUNCTION))

          { - throw new AmbiguousFunctionException(signature, paramTypes); - }

          + final FunctionResponse response = stub.getFunctionMeta(null, builder.build());

            • End diff –

        fixed

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36937244 — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java — @@ -754,26 +801,19 @@ public final FunctionDesc getFunction(final String signature, FunctionType funcT builder.addParameterTypes(type); } FunctionResponse response = null; try { final BlockingInterface stub = getStub(); - response = stub.getFunctionMeta(null, builder.build()); - } catch (ServiceException se) { - throw new RuntimeException(se); - } - if (isThisError(response.getState(), ResultCode.UNDEFINED_FUNCTION)) { - throw new UndefinedFunctionException(signature, paramTypes); - } else if (isThisError(response.getState(), ResultCode.AMBIGUOUS_FUNCTION)) { - throw new AmbiguousFunctionException(signature, paramTypes); - } + final FunctionResponse response = stub.getFunctionMeta(null, builder.build()); End diff – fixed
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36937450

        — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java —
        @@ -805,11 +851,19 @@ public final boolean containFunction(final String signature, FunctionType funcTy
        }

        @Override

        • public final boolean alterTable(final AlterTableDesc desc) {
          + public final void alterTable(final AlterTableDesc desc) throws UndefinedTableException, DuplicateColumnException,
          + InsufficientPrivilegeException, DuplicateTableException {

        try {
        final BlockingInterface stub = getStub();

        • return isSuccess(stub.alterTable(null, desc.getProto()));
          + final ReturnState state = stub.alterTable(null, desc.getProto());
            • End diff –

        I added more exceptions.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36937450 — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java — @@ -805,11 +851,19 @@ public final boolean containFunction(final String signature, FunctionType funcTy } @Override public final boolean alterTable(final AlterTableDesc desc) { + public final void alterTable(final AlterTableDesc desc) throws UndefinedTableException, DuplicateColumnException, + InsufficientPrivilegeException, DuplicateTableException { try { final BlockingInterface stub = getStub(); return isSuccess(stub.alterTable(null, desc.getProto())); + final ReturnState state = stub.alterTable(null, desc.getProto()); End diff – I added more exceptions.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36937458

        — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java —
        @@ -805,11 +851,19 @@ public final boolean containFunction(final String signature, FunctionType funcTy
        }

        @Override

        • public final boolean alterTable(final AlterTableDesc desc) {
          + public final void alterTable(final AlterTableDesc desc) throws UndefinedTableException, DuplicateColumnException,
          + InsufficientPrivilegeException, DuplicateTableException {

        try {
        final BlockingInterface stub = getStub();

        • return isSuccess(stub.alterTable(null, desc.getProto()));
          + final ReturnState state = stub.alterTable(null, desc.getProto());
          +
          + throwsIfThisError(state, DuplicateColumnException.class);
          + throwsIfThisError(state, DuplicateTableException.class);
          + throwsIfThisError(state, DuplicateColumnException.class);
            • End diff –

        fixed

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36937458 — Diff: tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java — @@ -805,11 +851,19 @@ public final boolean containFunction(final String signature, FunctionType funcTy } @Override public final boolean alterTable(final AlterTableDesc desc) { + public final void alterTable(final AlterTableDesc desc) throws UndefinedTableException, DuplicateColumnException, + InsufficientPrivilegeException, DuplicateTableException { try { final BlockingInterface stub = getStub(); return isSuccess(stub.alterTable(null, desc.getProto())); + final ReturnState state = stub.alterTable(null, desc.getProto()); + + throwsIfThisError(state, DuplicateColumnException.class); + throwsIfThisError(state, DuplicateTableException.class); + throwsIfThisError(state, DuplicateColumnException.class); End diff – fixed
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36937509

        — Diff: tajo-client/src/main/java/org/apache/tajo/client/v2/LegacyClientDelegate.java —
        @@ -72,10 +72,20 @@ public int executeUpdate(String sql) throws TajoException {
        }

        @Override

        • public ResultSet executeSQL(String sql) throws TajoException {
          + public ResultSet executeSQL(String sql) throws TajoException, QueryFailedException, QueryKilledException {
            • End diff –

        It means a documentation. This exceptions will let users to know what exception should be handled.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36937509 — Diff: tajo-client/src/main/java/org/apache/tajo/client/v2/LegacyClientDelegate.java — @@ -72,10 +72,20 @@ public int executeUpdate(String sql) throws TajoException { } @Override public ResultSet executeSQL(String sql) throws TajoException { + public ResultSet executeSQL(String sql) throws TajoException, QueryFailedException, QueryKilledException { End diff – It means a documentation. This exceptions will let users to know what exception should be handled.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36937512

        — Diff: tajo-client/src/main/java/org/apache/tajo/client/v2/ClientDelegate.java —
        @@ -31,7 +32,7 @@

        int executeUpdate(String sql) throws TajoException;

        • ResultSet executeSQL(String sql) throws TajoException;
          + ResultSet executeSQL(String sql) throws TajoException, QueryFailedException;
            • End diff –

        It means a documentation. This exceptions will let users to know what exception should be handled.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36937512 — Diff: tajo-client/src/main/java/org/apache/tajo/client/v2/ClientDelegate.java — @@ -31,7 +32,7 @@ int executeUpdate(String sql) throws TajoException; ResultSet executeSQL(String sql) throws TajoException; + ResultSet executeSQL(String sql) throws TajoException, QueryFailedException; End diff – It means a documentation. This exceptions will let users to know what exception should be handled.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36937521

        — Diff: tajo-common/src/main/java/org/apache/tajo/exception/DuplicateFunctionException.java —
        @@ -0,0 +1,34 @@
        +/**
        + * Licensed to the Apache Software Foundation (ASF) under one
        + * or more contributor license agreements. See the NOTICE file
        + * distributed with this work for additional information
        + * regarding copyright ownership. The ASF licenses this file
        + * to you under the Apache License, Version 2.0 (the
        + * "License"); you may not use this file except in compliance
        + * with the License. You may obtain a copy of the License at
        + *
        + * http://www.apache.org/licenses/LICENSE-2.0
        + *
        + * Unless required by applicable law or agreed to in writing, software
        + * distributed under the License is distributed on an "AS IS" BASIS,
        + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
        + * See the License for the specific language governing permissions and
        + * limitations under the License.
        + */
        +
        +package org.apache.tajo.exception;
        +
        +import org.apache.tajo.error.Errors;
        +import org.apache.tajo.rpc.protocolrecords.PrimitiveProtos.ReturnState;
        +
        +public class DuplicateFunctionException extends TajoException {
        + private static final long serialVersionUID = 3224521585413794703L;
        +
        + public DuplicateFunctionException(ReturnState state)

        { + super(state); + }

        +
        + public DuplicateFunctionException(String signature) {
        — End diff –

        fixed

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36937521 — Diff: tajo-common/src/main/java/org/apache/tajo/exception/DuplicateFunctionException.java — @@ -0,0 +1,34 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.tajo.exception; + +import org.apache.tajo.error.Errors; +import org.apache.tajo.rpc.protocolrecords.PrimitiveProtos.ReturnState; + +public class DuplicateFunctionException extends TajoException { + private static final long serialVersionUID = 3224521585413794703L; + + public DuplicateFunctionException(ReturnState state) { + super(state); + } + + public DuplicateFunctionException(String signature) { — End diff – fixed
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on a diff in the pull request:

        https://github.com/apache/tajo/pull/680#discussion_r36937817

        — Diff: tajo-common/src/main/proto/errors.proto —
        @@ -154,11 +157,15 @@ enum ResultCode {
        CAT_UPGRADE_REQUIRED = 901; // Migration
        CAT_CANNOT_CONNECT = 902; // Cannot connect metadata server

        • // MetaData Connector (MDC)
        • MDC_NO_MATCHED_DATATYPE = 910; // No matched data type between Tajo and connector
          + // Linked Metadata (MDC)
            • End diff –

        fixed

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on a diff in the pull request: https://github.com/apache/tajo/pull/680#discussion_r36937817 — Diff: tajo-common/src/main/proto/errors.proto — @@ -154,11 +157,15 @@ enum ResultCode { CAT_UPGRADE_REQUIRED = 901; // Migration CAT_CANNOT_CONNECT = 902; // Cannot connect metadata server // MetaData Connector (MDC) MDC_NO_MATCHED_DATATYPE = 910; // No matched data type between Tajo and connector + // Linked Metadata (MDC) End diff – fixed
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/680#issuecomment-130545281

        I reflected the comments and rebased.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/680#issuecomment-130545281 I reflected the comments and rebased.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/680#issuecomment-130586950

        Thanks for updating your patch.
        I have more comments.

        • AbstractDBStore.getTableSpaceInfo() should throw UndefinedTablespaceException instead of TajoInternalError.
        • AbstractDBStore.getTableName() should throw UndefinedTableException instead of TajoInternalError.
        • AbstractDBStore.getIndexByName() should throw UndefinedIndexException instead of TajoInternalError.
        • AbstractDBStore.getIndexByColumns() should throw UndefinedIndexException instead of TajoInternalError.
        • AbstractDBStore.updateTableStats() should throw UndefinedTableException instead of TajoInternalError.
        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/680#issuecomment-130586950 Thanks for updating your patch. I have more comments. AbstractDBStore.getTableSpaceInfo() should throw UndefinedTablespaceException instead of TajoInternalError. AbstractDBStore.getTableName() should throw UndefinedTableException instead of TajoInternalError. AbstractDBStore.getIndexByName() should throw UndefinedIndexException instead of TajoInternalError. AbstractDBStore.getIndexByColumns() should throw UndefinedIndexException instead of TajoInternalError. AbstractDBStore.updateTableStats() should throw UndefinedTableException instead of TajoInternalError.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/680#issuecomment-130588527

        I reflected the comments. Thank you for careful review!

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/680#issuecomment-130588527 I reflected the comments. Thank you for careful review!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/680#issuecomment-130632994

        +1 thank you for the nice work!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/680#issuecomment-130632994 +1 thank you for the nice work!
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed this patch to master branch. Thank you for the reviews.

        Show
        hyunsik Hyunsik Choi added a comment - committed this patch to master branch. Thank you for the reviews.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/680

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/680
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #798 (See https://builds.apache.org/job/Tajo-master-build/798/)
        TAJO-1748: Refine client APIs to throw specific exceptions. (hyunsik: rev 903151eadc457ed7f29e96ca3acf46e73324d844)

        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestJoinQuery.java
        • tajo-core/src/test/java/org/apache/tajo/client/TestQueryClientExceptions.java
        • tajo-common/src/main/java/org/apache/tajo/exception/UnknownDataTypeException.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/ResolverBySubExprsAndRels.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/MetadataProvider.java
        • tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseScanner.java
        • tajo-common/src/main/java/org/apache/tajo/exception/TajoError.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedPartitionMethodException.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/LinkedMetadataManager.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicateTableException.java
        • tajo-core/src/test/java/org/apache/tajo/client/TestTajoClient.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/Repartitioner.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/expr/AggregationFunctionCallEval.java
        • tajo-common/src/main/java/org/apache/tajo/exception/TajoExceptionInterface.java
        • tajo-client/src/main/java/org/apache/tajo/client/v2/exception/ClientUnableToConnectException.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java
        • tajo-core/src/test/resources/queries/TestTruncateTable/table1_ddl.sql
        • tajo-client/src/main/java/org/apache/tajo/storage/RowStoreUtil.java
        • CHANGES
        • tajo-common/src/main/java/org/apache/tajo/exception/InvalidOperationException.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/PostgreSQLStore.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedFunctionException.java
        • tajo-core/src/test/java/org/apache/tajo/client/TestTajoClientFailures.java
        • tajo-common/src/main/java/org/apache/tajo/exception/AmbiguousTableException.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java
        • tajo-common/src/main/java/org/apache/tajo/exception/UnimplementedException.java
        • tajo-catalog/tajo-catalog-client/src/main/proto/CatalogProtocol.proto
        • tajo-core/src/test/resources/results/TestTajoCli/testAlterTableAddDropPartition.result
        • tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedPartitionKeyException.java
        • tajo-common/src/main/java/org/apache/tajo/storage/VTuple.java
        • tajo-common/src/main/java/org/apache/tajo/exception/UndefinedColumnException.java
        • tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/TablesResource.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/InvalidNameException.java
        • tajo-client/src/main/java/org/apache/tajo/client/TajoClientImpl.java
        • tajo-common/src/main/java/org/apache/tajo/exception/DuplicateTableException.java
        • tajo-common/src/main/java/org/apache/tajo/exception/InsufficientPrivilegeException.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/json/JsonLineSerializer.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/FileTablespace.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/text/DelimitedLineReader.java
        • tajo-common/src/main/java/org/apache/tajo/exception/DuplicateDatabaseException.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/ResolverByRels.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/CatalogException.java
        • tajo-common/src/main/java/org/apache/tajo/exception/InvalidNameException.java
        • tajo-core/src/test/java/org/apache/tajo/engine/function/TestConditionalExpressions.java
        • tajo-common/src/main/java/org/apache/tajo/exception/ErrorMessages.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MariaDBStore.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/function/FunctionInvoke.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/TajoCli.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicateFunctionException.java
        • tajo-common/src/main/java/org/apache/tajo/exception/DuplicatePartitionException.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedColumnException.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/AmbiguousTableException.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/serder/EvalNodeDeserializer.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/serder/LogicalNodeDeserializer.java
        • tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java
        • tajo-common/src/main/java/org/apache/tajo/exception/InvalidDataTypeException.java
        • tajo-common/src/main/java/org/apache/tajo/exception/UndefinedTableException.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicateColumnException.java
        • tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogUtil.java
        • tajo-common/src/main/java/org/apache/tajo/exception/QueryKilledException.java
        • tajo-core/src/main/java/org/apache/tajo/webapp/QueryExecutorServlet.java
        • tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseTextSerializerDeserializer.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/MetadataConnectionException.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanPreprocessor.java
        • tajo-client/src/main/java/org/apache/tajo/jdbc/WaitingResultSet.java
        • tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestFunctionDesc.java
        • tajo-common/src/main/java/org/apache/tajo/exception/TajoException.java
        • tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java
        • tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/DatabasesResource.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogService.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/serder/LogicalNodeSerializer.java
        • tajo-common/src/main/java/org/apache/tajo/exception/DuplicateTablespaceException.java
        • tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/XMLCatalogSchemaManager.java
        • tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestSchema.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMasterTask.java
        • tajo-common/src/main/java/org/apache/tajo/exception/UnknownDataFormatException.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/expr/EvalTreeUtil.java
        • tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestLinkedMetadataManager.java
        • tajo-common/src/main/java/org/apache/tajo/exception/UnavailableTableLocationException.java
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestHBaseTable.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/ResolverByLegacy.java
        • tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto
        • tajo-common/src/main/java/org/apache/tajo/exception/ExceptionUtil.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlanner.java
        • tajo-core/src/test/resources/results/TestTajoCliNegatives/testQueryFailure.result
        • tajo-common/src/main/java/org/apache/tajo/exception/MetadataConnectionException.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/TypeDeterminant.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
        • tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java
        • tajo-common/src/main/java/org/apache/tajo/exception/ReturnStateUtil.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/util/PlannerUtil.java
        • tajo-core/src/test/resources/results/TestTajoCliNegatives/testQuerySyntax.result
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java
        • tajo-common/src/main/java/org/apache/tajo/exception/UndefinedPartitionKeyException.java
        • tajo-common/src/main/java/org/apache/tajo/exception/DuplicateFunctionException.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/json/JsonLineDeserializer.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/OracleStore.java
        • tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseBinarySerializerDeserializer.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/verifier/PreLogicalPlanVerifier.java
        • tajo-common/src/main/java/org/apache/tajo/exception/UndefinedTablespaceException.java
        • tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
        • tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/TajoShellCommand.java
        • tajo-common/src/main/java/org/apache/tajo/exception/UnsupportedDataTypeException.java
        • tajo-common/src/main/java/org/apache/tajo/exception/DataTypeMismatchException.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java
        • tajo-core/src/test/java/org/apache/tajo/cli/tsql/TestTajoCliNegatives.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/verifier/VerificationState.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java
        • tajo-client/src/main/java/org/apache/tajo/client/ClientExceptionUtil.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/function/ClassBasedScalarFunctionInvoke.java
        • tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClient.java
        • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/AbstractScanner.java
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestTruncateTable.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java
        • tajo-core/src/test/java/org/apache/tajo/engine/eval/TestEvalTreeUtil.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicateDatabaseException.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/Query.java
        • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/Tablespace.java
        • tajo-common/src/main/java/org/apache/tajo/exception/AmbiguousPartitionDirectoryExistException.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/AmbiguousPartitionDirectoryExistException.java
        • tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java
        • tajo-common/src/main/java/org/apache/tajo/exception/UndefinedPartitionException.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedTableException.java
        • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/RowStoreUtil.java
        • tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/AbstractHBaseAppender.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/ExprAnnotator.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/CatalogExceptionUtil.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java
        • tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java
        • tajo-common/src/main/java/org/apache/tajo/exception/UndefinedFunctionException.java
        • tajo-common/src/main/java/org/apache/tajo/exception/InvalidTablePropertyException.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/orc/ORCScanner.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicatePartitionException.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicateIndexException.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/ResolverByRelsAndSubExprs.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/CreateTableExecutor.java
        • tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/ColumnMapping.java
        • tajo-core/src/test/java/org/apache/tajo/engine/eval/TestSQLExpression.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedTablespaceException.java
        • tajo-common/src/main/java/org/apache/tajo/exception/TajoRuntimeException.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java
        • tajo-client/src/main/java/org/apache/tajo/client/QueryClient.java
        • tajo-common/src/main/java/org/apache/tajo/exception/CatalogUpgradeRequiredException.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedDatabaseException.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/ExprNormalizer.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TajoQueryEngine.java
        • tajo-core/src/test/java/org/apache/tajo/client/v2/TestTajoClientV2.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/ConnectDatabaseCommand.java
        • tajo-common/src/main/java/org/apache/tajo/exception/QueryFailedException.java
        • tajo-common/src/main/java/org/apache/tajo/exception/SQLSyntaxError.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
        • tajo-common/src/main/java/org/apache/tajo/exception/TajoInternalError.java
        • tajo-core/src/main/java/org/apache/tajo/engine/parser/SQLSyntaxError.java
        • tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/SortedInsertRewriter.java
        • tajo-common/src/main/java/org/apache/tajo/exception/SQLExceptionUtil.java
        • tajo-common/src/main/java/org/apache/tajo/exception/InternalException.java
        • tajo-core/src/test/java/org/apache/tajo/client/TestCatalogAdminClientExceptions.java
        • tajo-common/src/main/java/org/apache/tajo/exception/QueryNotFoundException.java
        • tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClientImpl.java
        • tajo-common/src/main/java/org/apache/tajo/exception/DuplicateColumnException.java
        • tajo-client/src/main/java/org/apache/tajo/client/v2/LegacyClientDelegate.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/DDLExecutor.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/dictionary/InfoSchemaMetadataDictionary.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/function/AggFunctionInvoke.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/ProjectionPushDownRule.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicateTablespaceException.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/FunctionDesc.java
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestAlterTablespace.java
        • tajo-common/src/main/java/org/apache/tajo/exception/DefaultTajoException.java
        • tajo-core/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java
        • tajo-common/src/main/java/org/apache/tajo/exception/AmbiguousFunctionException.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/AmbiguousFunctionException.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/DescTableCommand.java
        • tajo-client/src/main/java/org/apache/tajo/client/TajoClientUtil.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/function/ClassBasedAggFunctionInvoke.java
        • tajo-core/src/main/java/org/apache/tajo/engine/function/FailFunction.java
        • tajo-common/src/main/java/org/apache/tajo/exception/MissingTablePropertyException.java
        • tajo-common/src/main/java/org/apache/tajo/exception/LMDNoMatchedDatatypeException.java
        • tajo-common/src/main/java/org/apache/tajo/exception/NotImplementedException.java
        • tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseTablespace.java
        • tajo-common/src/main/java/org/apache/tajo/exception/UndefinedDatabaseException.java
        • tajo-common/src/main/java/org/apache/tajo/exception/UndefinedIndexException.java
        • tajo-common/src/main/java/org/apache/tajo/exception/UndefinedPartitionMethodException.java
        • tajo-common/src/main/java/org/apache/tajo/exception/DuplicateIndexException.java
        • tajo-client/src/main/java/org/apache/tajo/client/v2/TajoClient.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedPartitionException.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/InsufficientPrivilegeException.java
        • tajo-client/src/main/java/org/apache/tajo/client/v2/ClientDelegate.java
        • tajo-common/src/main/proto/errors.proto
        • tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/NameResolver.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedIndexException.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #798 (See https://builds.apache.org/job/Tajo-master-build/798/ ) TAJO-1748 : Refine client APIs to throw specific exceptions. (hyunsik: rev 903151eadc457ed7f29e96ca3acf46e73324d844) tajo-core/src/test/java/org/apache/tajo/engine/query/TestJoinQuery.java tajo-core/src/test/java/org/apache/tajo/client/TestQueryClientExceptions.java tajo-common/src/main/java/org/apache/tajo/exception/UnknownDataTypeException.java tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/ResolverBySubExprsAndRels.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/MetadataProvider.java tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseScanner.java tajo-common/src/main/java/org/apache/tajo/exception/TajoError.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedPartitionMethodException.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/LinkedMetadataManager.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicateTableException.java tajo-core/src/test/java/org/apache/tajo/client/TestTajoClient.java tajo-core/src/main/java/org/apache/tajo/querymaster/Repartitioner.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/AggregationFunctionCallEval.java tajo-common/src/main/java/org/apache/tajo/exception/TajoExceptionInterface.java tajo-client/src/main/java/org/apache/tajo/client/v2/exception/ClientUnableToConnectException.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java tajo-core/src/test/resources/queries/TestTruncateTable/table1_ddl.sql tajo-client/src/main/java/org/apache/tajo/storage/RowStoreUtil.java CHANGES tajo-common/src/main/java/org/apache/tajo/exception/InvalidOperationException.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/PostgreSQLStore.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedFunctionException.java tajo-core/src/test/java/org/apache/tajo/client/TestTajoClientFailures.java tajo-common/src/main/java/org/apache/tajo/exception/AmbiguousTableException.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java tajo-common/src/main/java/org/apache/tajo/exception/UnimplementedException.java tajo-catalog/tajo-catalog-client/src/main/proto/CatalogProtocol.proto tajo-core/src/test/resources/results/TestTajoCli/testAlterTableAddDropPartition.result tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedPartitionKeyException.java tajo-common/src/main/java/org/apache/tajo/storage/VTuple.java tajo-common/src/main/java/org/apache/tajo/exception/UndefinedColumnException.java tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/TablesResource.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/InvalidNameException.java tajo-client/src/main/java/org/apache/tajo/client/TajoClientImpl.java tajo-common/src/main/java/org/apache/tajo/exception/DuplicateTableException.java tajo-common/src/main/java/org/apache/tajo/exception/InsufficientPrivilegeException.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/json/JsonLineSerializer.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/FileTablespace.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/text/DelimitedLineReader.java tajo-common/src/main/java/org/apache/tajo/exception/DuplicateDatabaseException.java tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/ResolverByRels.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/CatalogException.java tajo-common/src/main/java/org/apache/tajo/exception/InvalidNameException.java tajo-core/src/test/java/org/apache/tajo/engine/function/TestConditionalExpressions.java tajo-common/src/main/java/org/apache/tajo/exception/ErrorMessages.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MariaDBStore.java tajo-plan/src/main/java/org/apache/tajo/plan/function/FunctionInvoke.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/TajoCli.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicateFunctionException.java tajo-common/src/main/java/org/apache/tajo/exception/DuplicatePartitionException.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedColumnException.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/AmbiguousTableException.java tajo-plan/src/main/java/org/apache/tajo/plan/serder/EvalNodeDeserializer.java tajo-plan/src/main/java/org/apache/tajo/plan/serder/LogicalNodeDeserializer.java tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java tajo-common/src/main/java/org/apache/tajo/exception/InvalidDataTypeException.java tajo-common/src/main/java/org/apache/tajo/exception/UndefinedTableException.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicateColumnException.java tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogUtil.java tajo-common/src/main/java/org/apache/tajo/exception/QueryKilledException.java tajo-core/src/main/java/org/apache/tajo/webapp/QueryExecutorServlet.java tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseTextSerializerDeserializer.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/MetadataConnectionException.java tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanPreprocessor.java tajo-client/src/main/java/org/apache/tajo/jdbc/WaitingResultSet.java tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestFunctionDesc.java tajo-common/src/main/java/org/apache/tajo/exception/TajoException.java tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/DatabasesResource.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogService.java tajo-plan/src/main/java/org/apache/tajo/plan/serder/LogicalNodeSerializer.java tajo-common/src/main/java/org/apache/tajo/exception/DuplicateTablespaceException.java tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/XMLCatalogSchemaManager.java tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestSchema.java tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMasterTask.java tajo-common/src/main/java/org/apache/tajo/exception/UnknownDataFormatException.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/EvalTreeUtil.java tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestLinkedMetadataManager.java tajo-common/src/main/java/org/apache/tajo/exception/UnavailableTableLocationException.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestHBaseTable.java tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/ResolverByLegacy.java tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto tajo-common/src/main/java/org/apache/tajo/exception/ExceptionUtil.java tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlanner.java tajo-core/src/test/resources/results/TestTajoCliNegatives/testQueryFailure.result tajo-common/src/main/java/org/apache/tajo/exception/MetadataConnectionException.java tajo-plan/src/main/java/org/apache/tajo/plan/TypeDeterminant.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java tajo-common/src/main/java/org/apache/tajo/exception/ReturnStateUtil.java tajo-plan/src/main/java/org/apache/tajo/plan/util/PlannerUtil.java tajo-core/src/test/resources/results/TestTajoCliNegatives/testQuerySyntax.result tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java tajo-common/src/main/java/org/apache/tajo/exception/UndefinedPartitionKeyException.java tajo-common/src/main/java/org/apache/tajo/exception/DuplicateFunctionException.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/json/JsonLineDeserializer.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/OracleStore.java tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseBinarySerializerDeserializer.java tajo-plan/src/main/java/org/apache/tajo/plan/verifier/PreLogicalPlanVerifier.java tajo-common/src/main/java/org/apache/tajo/exception/UndefinedTablespaceException.java tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/TajoShellCommand.java tajo-common/src/main/java/org/apache/tajo/exception/UnsupportedDataTypeException.java tajo-common/src/main/java/org/apache/tajo/exception/DataTypeMismatchException.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java tajo-core/src/test/java/org/apache/tajo/cli/tsql/TestTajoCliNegatives.java tajo-plan/src/main/java/org/apache/tajo/plan/verifier/VerificationState.java tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java tajo-client/src/main/java/org/apache/tajo/client/ClientExceptionUtil.java tajo-plan/src/main/java/org/apache/tajo/plan/function/ClassBasedScalarFunctionInvoke.java tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClient.java tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/AbstractScanner.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestTruncateTable.java tajo-core/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java tajo-core/src/test/java/org/apache/tajo/engine/eval/TestEvalTreeUtil.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicateDatabaseException.java tajo-core/src/main/java/org/apache/tajo/querymaster/Query.java tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/Tablespace.java tajo-common/src/main/java/org/apache/tajo/exception/AmbiguousPartitionDirectoryExistException.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/AmbiguousPartitionDirectoryExistException.java tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java tajo-common/src/main/java/org/apache/tajo/exception/UndefinedPartitionException.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedTableException.java tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/RowStoreUtil.java tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/AbstractHBaseAppender.java tajo-plan/src/main/java/org/apache/tajo/plan/ExprAnnotator.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/CatalogExceptionUtil.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java tajo-common/src/main/java/org/apache/tajo/exception/UndefinedFunctionException.java tajo-common/src/main/java/org/apache/tajo/exception/InvalidTablePropertyException.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/orc/ORCScanner.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicatePartitionException.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicateIndexException.java tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/ResolverByRelsAndSubExprs.java tajo-core/src/main/java/org/apache/tajo/master/exec/CreateTableExecutor.java tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/ColumnMapping.java tajo-core/src/test/java/org/apache/tajo/engine/eval/TestSQLExpression.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedTablespaceException.java tajo-common/src/main/java/org/apache/tajo/exception/TajoRuntimeException.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java tajo-client/src/main/java/org/apache/tajo/client/QueryClient.java tajo-common/src/main/java/org/apache/tajo/exception/CatalogUpgradeRequiredException.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedDatabaseException.java tajo-plan/src/main/java/org/apache/tajo/plan/ExprNormalizer.java tajo-core/src/main/java/org/apache/tajo/worker/TajoQueryEngine.java tajo-core/src/test/java/org/apache/tajo/client/v2/TestTajoClientV2.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/ConnectDatabaseCommand.java tajo-common/src/main/java/org/apache/tajo/exception/QueryFailedException.java tajo-common/src/main/java/org/apache/tajo/exception/SQLSyntaxError.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java tajo-common/src/main/java/org/apache/tajo/exception/TajoInternalError.java tajo-core/src/main/java/org/apache/tajo/engine/parser/SQLSyntaxError.java tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/SortedInsertRewriter.java tajo-common/src/main/java/org/apache/tajo/exception/SQLExceptionUtil.java tajo-common/src/main/java/org/apache/tajo/exception/InternalException.java tajo-core/src/test/java/org/apache/tajo/client/TestCatalogAdminClientExceptions.java tajo-common/src/main/java/org/apache/tajo/exception/QueryNotFoundException.java tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClientImpl.java tajo-common/src/main/java/org/apache/tajo/exception/DuplicateColumnException.java tajo-client/src/main/java/org/apache/tajo/client/v2/LegacyClientDelegate.java tajo-core/src/main/java/org/apache/tajo/master/exec/DDLExecutor.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/dictionary/InfoSchemaMetadataDictionary.java tajo-plan/src/main/java/org/apache/tajo/plan/function/AggFunctionInvoke.java tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/ProjectionPushDownRule.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicateTablespaceException.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/FunctionDesc.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestAlterTablespace.java tajo-common/src/main/java/org/apache/tajo/exception/DefaultTajoException.java tajo-core/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java tajo-common/src/main/java/org/apache/tajo/exception/AmbiguousFunctionException.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/AmbiguousFunctionException.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/DescTableCommand.java tajo-client/src/main/java/org/apache/tajo/client/TajoClientUtil.java tajo-plan/src/main/java/org/apache/tajo/plan/function/ClassBasedAggFunctionInvoke.java tajo-core/src/main/java/org/apache/tajo/engine/function/FailFunction.java tajo-common/src/main/java/org/apache/tajo/exception/MissingTablePropertyException.java tajo-common/src/main/java/org/apache/tajo/exception/LMDNoMatchedDatatypeException.java tajo-common/src/main/java/org/apache/tajo/exception/NotImplementedException.java tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseTablespace.java tajo-common/src/main/java/org/apache/tajo/exception/UndefinedDatabaseException.java tajo-common/src/main/java/org/apache/tajo/exception/UndefinedIndexException.java tajo-common/src/main/java/org/apache/tajo/exception/UndefinedPartitionMethodException.java tajo-common/src/main/java/org/apache/tajo/exception/DuplicateIndexException.java tajo-client/src/main/java/org/apache/tajo/client/v2/TajoClient.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedPartitionException.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/InsufficientPrivilegeException.java tajo-client/src/main/java/org/apache/tajo/client/v2/ClientDelegate.java tajo-common/src/main/proto/errors.proto tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/NameResolver.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedIndexException.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #436 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/436/)
        TAJO-1748: Refine client APIs to throw specific exceptions. (hyunsik: rev 903151eadc457ed7f29e96ca3acf46e73324d844)

        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedTablespaceException.java
        • tajo-core/src/test/java/org/apache/tajo/engine/eval/TestEvalTreeUtil.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java
        • tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClient.java
        • tajo-common/src/main/java/org/apache/tajo/exception/UnknownDataFormatException.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/serder/LogicalNodeDeserializer.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedColumnException.java
        • tajo-common/src/main/java/org/apache/tajo/exception/DefaultTajoException.java
        • tajo-common/src/main/java/org/apache/tajo/exception/UndefinedIndexException.java
        • tajo-common/src/main/java/org/apache/tajo/exception/InvalidNameException.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanPreprocessor.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/MetadataProvider.java
        • tajo-common/src/main/java/org/apache/tajo/exception/SQLExceptionUtil.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/function/FunctionInvoke.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/dictionary/InfoSchemaMetadataDictionary.java
        • tajo-common/src/main/java/org/apache/tajo/exception/UndefinedFunctionException.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/function/ClassBasedAggFunctionInvoke.java
        • tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedFunctionException.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/ResolverByLegacy.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java
        • tajo-core/src/test/resources/results/TestTajoCliNegatives/testQueryFailure.result
        • tajo-common/src/main/java/org/apache/tajo/exception/InvalidDataTypeException.java
        • tajo-common/src/main/java/org/apache/tajo/exception/DuplicateTableException.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/ResolverByRelsAndSubExprs.java
        • tajo-core/src/test/java/org/apache/tajo/client/TestQueryClientExceptions.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/InsufficientPrivilegeException.java
        • tajo-common/src/main/java/org/apache/tajo/exception/InvalidTablePropertyException.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/AmbiguousTableException.java
        • tajo-common/src/main/java/org/apache/tajo/exception/UndefinedPartitionKeyException.java
        • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/RowStoreUtil.java
        • tajo-common/src/main/java/org/apache/tajo/exception/DuplicateFunctionException.java
        • tajo-core/src/test/java/org/apache/tajo/engine/eval/TestSQLExpression.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedPartitionException.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicateFunctionException.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/json/JsonLineSerializer.java
        • tajo-core/src/test/resources/queries/TestTruncateTable/table1_ddl.sql
        • tajo-common/src/main/java/org/apache/tajo/exception/DuplicateIndexException.java
        • tajo-common/src/main/java/org/apache/tajo/exception/InvalidOperationException.java
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestAlterTablespace.java
        • tajo-common/src/main/java/org/apache/tajo/exception/DuplicateDatabaseException.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMasterTask.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java
        • tajo-common/src/main/java/org/apache/tajo/exception/InternalException.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/function/AggFunctionInvoke.java
        • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/AbstractScanner.java
        • tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java
        • tajo-common/src/main/java/org/apache/tajo/exception/CatalogUpgradeRequiredException.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedIndexException.java
        • tajo-common/src/main/java/org/apache/tajo/exception/QueryNotFoundException.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/AmbiguousFunctionException.java
        • tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java
        • tajo-client/src/main/java/org/apache/tajo/client/v2/ClientDelegate.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedDatabaseException.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlanner.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/FunctionDesc.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java
        • tajo-common/src/main/java/org/apache/tajo/exception/UndefinedTableException.java
        • tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/DatabasesResource.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/serder/EvalNodeDeserializer.java
        • tajo-common/src/main/java/org/apache/tajo/exception/TajoException.java
        • tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/TablesResource.java
        • tajo-core/src/test/java/org/apache/tajo/engine/function/TestConditionalExpressions.java
        • tajo-core/src/main/java/org/apache/tajo/webapp/QueryExecutorServlet.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedPartitionKeyException.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/TypeDeterminant.java
        • tajo-common/src/main/java/org/apache/tajo/exception/SQLSyntaxError.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/NameResolver.java
        • tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/AbstractHBaseAppender.java
        • tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogUtil.java
        • tajo-common/src/main/java/org/apache/tajo/exception/ReturnStateUtil.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MariaDBStore.java
        • tajo-common/src/main/java/org/apache/tajo/exception/UndefinedDatabaseException.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/json/JsonLineDeserializer.java
        • tajo-common/src/main/java/org/apache/tajo/exception/QueryKilledException.java
        • tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
        • tajo-common/src/main/java/org/apache/tajo/exception/AmbiguousFunctionException.java
        • tajo-client/src/main/java/org/apache/tajo/storage/RowStoreUtil.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java
        • tajo-common/src/main/java/org/apache/tajo/exception/ExceptionUtil.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/util/PlannerUtil.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/ProjectionPushDownRule.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/DescTableCommand.java
        • tajo-core/src/test/resources/results/TestTajoCli/testAlterTableAddDropPartition.result
        • tajo-core/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicateTableException.java
        • tajo-common/src/main/java/org/apache/tajo/exception/DuplicateColumnException.java
        • tajo-client/src/main/java/org/apache/tajo/client/v2/TajoClient.java
        • tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TajoQueryEngine.java
        • tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseScanner.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java
        • tajo-core/src/main/java/org/apache/tajo/engine/parser/SQLSyntaxError.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/verifier/VerificationState.java
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestTruncateTable.java
        • tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClientImpl.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicateDatabaseException.java
        • tajo-common/src/main/java/org/apache/tajo/exception/UndefinedTablespaceException.java
        • tajo-catalog/tajo-catalog-client/src/main/proto/CatalogProtocol.proto
        • tajo-common/src/main/java/org/apache/tajo/exception/DuplicateTablespaceException.java
        • tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/PostgreSQLStore.java
        • tajo-common/src/main/java/org/apache/tajo/exception/NotImplementedException.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/Repartitioner.java
        • tajo-common/src/main/java/org/apache/tajo/exception/TajoInternalError.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicateIndexException.java
        • tajo-common/src/main/java/org/apache/tajo/exception/UndefinedPartitionException.java
        • tajo-client/src/main/java/org/apache/tajo/client/TajoClientUtil.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/LinkedMetadataManager.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/ResolverBySubExprsAndRels.java
        • tajo-core/src/main/java/org/apache/tajo/engine/function/FailFunction.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/AmbiguousPartitionDirectoryExistException.java
        • tajo-core/src/test/java/org/apache/tajo/client/TestTajoClient.java
        • tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/SortedInsertRewriter.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/serder/LogicalNodeSerializer.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java
        • tajo-common/src/main/java/org/apache/tajo/exception/MetadataConnectionException.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/expr/AggregationFunctionCallEval.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogService.java
        • tajo-core/src/test/java/org/apache/tajo/client/v2/TestTajoClientV2.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/verifier/PreLogicalPlanVerifier.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/ExprNormalizer.java
        • tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestFunctionDesc.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/CatalogExceptionUtil.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicateTablespaceException.java
        • tajo-core/src/test/java/org/apache/tajo/client/TestTajoClientFailures.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedTableException.java
        • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/Tablespace.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicateColumnException.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/MetadataConnectionException.java
        • tajo-common/src/main/java/org/apache/tajo/exception/UnknownDataTypeException.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/TajoCli.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/XMLCatalogSchemaManager.java
        • CHANGES
        • tajo-plan/src/main/java/org/apache/tajo/plan/function/ClassBasedScalarFunctionInvoke.java
        • tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestSchema.java
        • tajo-client/src/main/java/org/apache/tajo/client/v2/LegacyClientDelegate.java
        • tajo-common/src/main/java/org/apache/tajo/exception/TajoExceptionInterface.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/CreateTableExecutor.java
        • tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseTablespace.java
        • tajo-common/src/main/java/org/apache/tajo/exception/DataTypeMismatchException.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/InvalidNameException.java
        • tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestJoinQuery.java
        • tajo-common/src/main/java/org/apache/tajo/exception/AmbiguousPartitionDirectoryExistException.java
        • tajo-common/src/main/java/org/apache/tajo/exception/LMDNoMatchedDatatypeException.java
        • tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestLinkedMetadataManager.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/ExprAnnotator.java
        • tajo-common/src/main/java/org/apache/tajo/exception/InsufficientPrivilegeException.java
        • tajo-common/src/main/java/org/apache/tajo/exception/TajoError.java
        • tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestHBaseTable.java
        • tajo-client/src/main/java/org/apache/tajo/client/TajoClientImpl.java
        • tajo-common/src/main/java/org/apache/tajo/exception/UnimplementedException.java
        • tajo-client/src/main/java/org/apache/tajo/client/QueryClient.java
        • tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/OracleStore.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/ConnectDatabaseCommand.java
        • tajo-common/src/main/java/org/apache/tajo/exception/QueryFailedException.java
        • tajo-common/src/main/java/org/apache/tajo/exception/MissingTablePropertyException.java
        • tajo-common/src/main/java/org/apache/tajo/exception/ErrorMessages.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/CatalogException.java
        • tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseTextSerializerDeserializer.java
        • tajo-common/src/main/java/org/apache/tajo/exception/UndefinedPartitionMethodException.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/TajoShellCommand.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/ResolverByRels.java
        • tajo-common/src/main/java/org/apache/tajo/exception/DuplicatePartitionException.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/FileTablespace.java
        • tajo-common/src/main/java/org/apache/tajo/exception/TajoRuntimeException.java
        • tajo-core/src/test/java/org/apache/tajo/cli/tsql/TestTajoCliNegatives.java
        • tajo-core/src/test/java/org/apache/tajo/client/TestCatalogAdminClientExceptions.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/DDLExecutor.java
        • tajo-common/src/main/java/org/apache/tajo/exception/UnavailableTableLocationException.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java
        • tajo-common/src/main/java/org/apache/tajo/storage/VTuple.java
        • tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java
        • tajo-client/src/main/java/org/apache/tajo/client/ClientExceptionUtil.java
        • tajo-common/src/main/java/org/apache/tajo/exception/UnsupportedDataTypeException.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/orc/ORCScanner.java
        • tajo-client/src/main/java/org/apache/tajo/jdbc/WaitingResultSet.java
        • tajo-common/src/main/java/org/apache/tajo/exception/AmbiguousTableException.java
        • tajo-common/src/main/proto/errors.proto
        • tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/ColumnMapping.java
        • tajo-client/src/main/java/org/apache/tajo/client/v2/exception/ClientUnableToConnectException.java
        • tajo-common/src/main/java/org/apache/tajo/exception/UndefinedColumnException.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/text/DelimitedLineReader.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicatePartitionException.java
        • tajo-plan/src/main/java/org/apache/tajo/plan/expr/EvalTreeUtil.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedPartitionMethodException.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/Query.java
        • tajo-core/src/test/resources/results/TestTajoCliNegatives/testQuerySyntax.result
        • tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseBinarySerializerDeserializer.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #436 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/436/ ) TAJO-1748 : Refine client APIs to throw specific exceptions. (hyunsik: rev 903151eadc457ed7f29e96ca3acf46e73324d844) tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedTablespaceException.java tajo-core/src/test/java/org/apache/tajo/engine/eval/TestEvalTreeUtil.java tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClient.java tajo-common/src/main/java/org/apache/tajo/exception/UnknownDataFormatException.java tajo-plan/src/main/java/org/apache/tajo/plan/serder/LogicalNodeDeserializer.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedColumnException.java tajo-common/src/main/java/org/apache/tajo/exception/DefaultTajoException.java tajo-common/src/main/java/org/apache/tajo/exception/UndefinedIndexException.java tajo-common/src/main/java/org/apache/tajo/exception/InvalidNameException.java tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanPreprocessor.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/MetadataProvider.java tajo-common/src/main/java/org/apache/tajo/exception/SQLExceptionUtil.java tajo-plan/src/main/java/org/apache/tajo/plan/function/FunctionInvoke.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/dictionary/InfoSchemaMetadataDictionary.java tajo-common/src/main/java/org/apache/tajo/exception/UndefinedFunctionException.java tajo-plan/src/main/java/org/apache/tajo/plan/function/ClassBasedAggFunctionInvoke.java tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedFunctionException.java tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/ResolverByLegacy.java tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java tajo-core/src/test/resources/results/TestTajoCliNegatives/testQueryFailure.result tajo-common/src/main/java/org/apache/tajo/exception/InvalidDataTypeException.java tajo-common/src/main/java/org/apache/tajo/exception/DuplicateTableException.java tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/ResolverByRelsAndSubExprs.java tajo-core/src/test/java/org/apache/tajo/client/TestQueryClientExceptions.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/InsufficientPrivilegeException.java tajo-common/src/main/java/org/apache/tajo/exception/InvalidTablePropertyException.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/AmbiguousTableException.java tajo-common/src/main/java/org/apache/tajo/exception/UndefinedPartitionKeyException.java tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/RowStoreUtil.java tajo-common/src/main/java/org/apache/tajo/exception/DuplicateFunctionException.java tajo-core/src/test/java/org/apache/tajo/engine/eval/TestSQLExpression.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedPartitionException.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicateFunctionException.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/json/JsonLineSerializer.java tajo-core/src/test/resources/queries/TestTruncateTable/table1_ddl.sql tajo-common/src/main/java/org/apache/tajo/exception/DuplicateIndexException.java tajo-common/src/main/java/org/apache/tajo/exception/InvalidOperationException.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestAlterTablespace.java tajo-common/src/main/java/org/apache/tajo/exception/DuplicateDatabaseException.java tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMasterTask.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java tajo-common/src/main/java/org/apache/tajo/exception/InternalException.java tajo-plan/src/main/java/org/apache/tajo/plan/function/AggFunctionInvoke.java tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/AbstractScanner.java tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java tajo-common/src/main/java/org/apache/tajo/exception/CatalogUpgradeRequiredException.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedIndexException.java tajo-common/src/main/java/org/apache/tajo/exception/QueryNotFoundException.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/AmbiguousFunctionException.java tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java tajo-client/src/main/java/org/apache/tajo/client/v2/ClientDelegate.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedDatabaseException.java tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlanner.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/FunctionDesc.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java tajo-common/src/main/java/org/apache/tajo/exception/UndefinedTableException.java tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/DatabasesResource.java tajo-plan/src/main/java/org/apache/tajo/plan/serder/EvalNodeDeserializer.java tajo-common/src/main/java/org/apache/tajo/exception/TajoException.java tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/TablesResource.java tajo-core/src/test/java/org/apache/tajo/engine/function/TestConditionalExpressions.java tajo-core/src/main/java/org/apache/tajo/webapp/QueryExecutorServlet.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedPartitionKeyException.java tajo-plan/src/main/java/org/apache/tajo/plan/TypeDeterminant.java tajo-common/src/main/java/org/apache/tajo/exception/SQLSyntaxError.java tajo-core/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/NameResolver.java tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/AbstractHBaseAppender.java tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogUtil.java tajo-common/src/main/java/org/apache/tajo/exception/ReturnStateUtil.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MariaDBStore.java tajo-common/src/main/java/org/apache/tajo/exception/UndefinedDatabaseException.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/json/JsonLineDeserializer.java tajo-common/src/main/java/org/apache/tajo/exception/QueryKilledException.java tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java tajo-common/src/main/java/org/apache/tajo/exception/AmbiguousFunctionException.java tajo-client/src/main/java/org/apache/tajo/storage/RowStoreUtil.java tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java tajo-common/src/main/java/org/apache/tajo/exception/ExceptionUtil.java tajo-plan/src/main/java/org/apache/tajo/plan/util/PlannerUtil.java tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/ProjectionPushDownRule.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/DescTableCommand.java tajo-core/src/test/resources/results/TestTajoCli/testAlterTableAddDropPartition.result tajo-core/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicateTableException.java tajo-common/src/main/java/org/apache/tajo/exception/DuplicateColumnException.java tajo-client/src/main/java/org/apache/tajo/client/v2/TajoClient.java tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java tajo-core/src/main/java/org/apache/tajo/worker/TajoQueryEngine.java tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseScanner.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java tajo-core/src/main/java/org/apache/tajo/engine/parser/SQLSyntaxError.java tajo-plan/src/main/java/org/apache/tajo/plan/verifier/VerificationState.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestTruncateTable.java tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClientImpl.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicateDatabaseException.java tajo-common/src/main/java/org/apache/tajo/exception/UndefinedTablespaceException.java tajo-catalog/tajo-catalog-client/src/main/proto/CatalogProtocol.proto tajo-common/src/main/java/org/apache/tajo/exception/DuplicateTablespaceException.java tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/PostgreSQLStore.java tajo-common/src/main/java/org/apache/tajo/exception/NotImplementedException.java tajo-core/src/main/java/org/apache/tajo/querymaster/Repartitioner.java tajo-common/src/main/java/org/apache/tajo/exception/TajoInternalError.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicateIndexException.java tajo-common/src/main/java/org/apache/tajo/exception/UndefinedPartitionException.java tajo-client/src/main/java/org/apache/tajo/client/TajoClientUtil.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/LinkedMetadataManager.java tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/ResolverBySubExprsAndRels.java tajo-core/src/main/java/org/apache/tajo/engine/function/FailFunction.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/AmbiguousPartitionDirectoryExistException.java tajo-core/src/test/java/org/apache/tajo/client/TestTajoClient.java tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/SortedInsertRewriter.java tajo-plan/src/main/java/org/apache/tajo/plan/serder/LogicalNodeSerializer.java tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java tajo-common/src/main/java/org/apache/tajo/exception/MetadataConnectionException.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/AggregationFunctionCallEval.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogService.java tajo-core/src/test/java/org/apache/tajo/client/v2/TestTajoClientV2.java tajo-plan/src/main/java/org/apache/tajo/plan/verifier/PreLogicalPlanVerifier.java tajo-plan/src/main/java/org/apache/tajo/plan/ExprNormalizer.java tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestFunctionDesc.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/CatalogExceptionUtil.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicateTablespaceException.java tajo-core/src/test/java/org/apache/tajo/client/TestTajoClientFailures.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedTableException.java tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/Tablespace.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicateColumnException.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/MetadataConnectionException.java tajo-common/src/main/java/org/apache/tajo/exception/UnknownDataTypeException.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/TajoCli.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/XMLCatalogSchemaManager.java CHANGES tajo-plan/src/main/java/org/apache/tajo/plan/function/ClassBasedScalarFunctionInvoke.java tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestSchema.java tajo-client/src/main/java/org/apache/tajo/client/v2/LegacyClientDelegate.java tajo-common/src/main/java/org/apache/tajo/exception/TajoExceptionInterface.java tajo-core/src/main/java/org/apache/tajo/master/exec/CreateTableExecutor.java tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseTablespace.java tajo-common/src/main/java/org/apache/tajo/exception/DataTypeMismatchException.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/InvalidNameException.java tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestJoinQuery.java tajo-common/src/main/java/org/apache/tajo/exception/AmbiguousPartitionDirectoryExistException.java tajo-common/src/main/java/org/apache/tajo/exception/LMDNoMatchedDatatypeException.java tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestLinkedMetadataManager.java tajo-plan/src/main/java/org/apache/tajo/plan/ExprAnnotator.java tajo-common/src/main/java/org/apache/tajo/exception/InsufficientPrivilegeException.java tajo-common/src/main/java/org/apache/tajo/exception/TajoError.java tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestHBaseTable.java tajo-client/src/main/java/org/apache/tajo/client/TajoClientImpl.java tajo-common/src/main/java/org/apache/tajo/exception/UnimplementedException.java tajo-client/src/main/java/org/apache/tajo/client/QueryClient.java tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/OracleStore.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/ConnectDatabaseCommand.java tajo-common/src/main/java/org/apache/tajo/exception/QueryFailedException.java tajo-common/src/main/java/org/apache/tajo/exception/MissingTablePropertyException.java tajo-common/src/main/java/org/apache/tajo/exception/ErrorMessages.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/CatalogException.java tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseTextSerializerDeserializer.java tajo-common/src/main/java/org/apache/tajo/exception/UndefinedPartitionMethodException.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/TajoShellCommand.java tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/ResolverByRels.java tajo-common/src/main/java/org/apache/tajo/exception/DuplicatePartitionException.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/FileTablespace.java tajo-common/src/main/java/org/apache/tajo/exception/TajoRuntimeException.java tajo-core/src/test/java/org/apache/tajo/cli/tsql/TestTajoCliNegatives.java tajo-core/src/test/java/org/apache/tajo/client/TestCatalogAdminClientExceptions.java tajo-core/src/main/java/org/apache/tajo/master/exec/DDLExecutor.java tajo-common/src/main/java/org/apache/tajo/exception/UnavailableTableLocationException.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java tajo-common/src/main/java/org/apache/tajo/storage/VTuple.java tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java tajo-client/src/main/java/org/apache/tajo/client/ClientExceptionUtil.java tajo-common/src/main/java/org/apache/tajo/exception/UnsupportedDataTypeException.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/orc/ORCScanner.java tajo-client/src/main/java/org/apache/tajo/jdbc/WaitingResultSet.java tajo-common/src/main/java/org/apache/tajo/exception/AmbiguousTableException.java tajo-common/src/main/proto/errors.proto tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/ColumnMapping.java tajo-client/src/main/java/org/apache/tajo/client/v2/exception/ClientUnableToConnectException.java tajo-common/src/main/java/org/apache/tajo/exception/UndefinedColumnException.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/text/DelimitedLineReader.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicatePartitionException.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/EvalTreeUtil.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedPartitionMethodException.java tajo-core/src/main/java/org/apache/tajo/querymaster/Query.java tajo-core/src/test/resources/results/TestTajoCliNegatives/testQuerySyntax.result tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseBinarySerializerDeserializer.java

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development