Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1729

No handling of default case in DDLExecutor

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0, 0.12.0
    • Component/s: TajoMaster
    • Labels:

      Description

      As you can see, there is no handling code of default case in alterTable in DDLExecutor.java. It potentially may cause a bug because additional cases will be ignored.

      alterTable() in DDLExecutor.java
      break;
          default:
            //TODO
      

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user dkhwangbo opened a pull request:

        https://github.com/apache/tajo/pull/742

        TAJO-1729: No handling of default case in DDLExecutor

        As you can see, there is no handling code of default case in alterTable in DDLExecutor.java.
        so add line like execute() in same file.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/dkhwangbo/tajo TAJO-1729

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/742.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #742


        commit 96952d52950fde2a6b84661794838d68dab8b792
        Author: Dongkyu Hwangbo <dkhwangbo@gruter.com>
        Date: 2015-09-07T07:53:33Z

        reset

        commit 04f240b5aa594c35084a081442284da96362005f
        Author: Dongkyu Hwangbo <dkhwangbo@gruter.com>
        Date: 2015-09-07T08:00:43Z

        reset

        commit 13fbe052d66af951b030188f3602e1bf5cfa7ebb
        Author: Dongkyu Hwangbo <dkhwangbo@gruter.com>
        Date: 2015-09-08T00:58:34Z

        Merge remote-tracking branch 'upstream/master'

        commit 0b5c1de2fe17af4fb3c8d3e774c20efd74c753f9
        Author: Dongkyu Hwangbo <dkhwangbo@gruter.com>
        Date: 2015-09-08T04:48:46Z

        Merge remote-tracking branch 'upstream/master'

        commit 8ebc7d7e4af88b0dbd8cf803aeece62419c419f1
        Author: Dongkyu Hwangbo <dkhwangbo@gruter.com>
        Date: 2015-09-08T04:52:47Z

        initial commit


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user dkhwangbo opened a pull request: https://github.com/apache/tajo/pull/742 TAJO-1729 : No handling of default case in DDLExecutor As you can see, there is no handling code of default case in alterTable in DDLExecutor.java. so add line like execute() in same file. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dkhwangbo/tajo TAJO-1729 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/742.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #742 commit 96952d52950fde2a6b84661794838d68dab8b792 Author: Dongkyu Hwangbo <dkhwangbo@gruter.com> Date: 2015-09-07T07:53:33Z reset commit 04f240b5aa594c35084a081442284da96362005f Author: Dongkyu Hwangbo <dkhwangbo@gruter.com> Date: 2015-09-07T08:00:43Z reset commit 13fbe052d66af951b030188f3602e1bf5cfa7ebb Author: Dongkyu Hwangbo <dkhwangbo@gruter.com> Date: 2015-09-08T00:58:34Z Merge remote-tracking branch 'upstream/master' commit 0b5c1de2fe17af4fb3c8d3e774c20efd74c753f9 Author: Dongkyu Hwangbo <dkhwangbo@gruter.com> Date: 2015-09-08T04:48:46Z Merge remote-tracking branch 'upstream/master' commit 8ebc7d7e4af88b0dbd8cf803aeece62419c419f1 Author: Dongkyu Hwangbo <dkhwangbo@gruter.com> Date: 2015-09-08T04:52:47Z initial commit
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/742#issuecomment-138484593

        +1
        Thanks for your contribution!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/742#issuecomment-138484593 +1 Thanks for your contribution!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/742

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/742
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #489 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/489/)
        TAJO-1729: No handling of default case in DDLExecutor. (Contributed by Dongkyu Hwangbo, committed by Jinho) (jhkim: rev a460978d996f95259b2935d479ccfc676b141e05)

        • tajo-core/src/main/java/org/apache/tajo/master/exec/DDLExecutor.java
        • CHANGES
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #489 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/489/ ) TAJO-1729 : No handling of default case in DDLExecutor. (Contributed by Dongkyu Hwangbo, committed by Jinho) (jhkim: rev a460978d996f95259b2935d479ccfc676b141e05) tajo-core/src/main/java/org/apache/tajo/master/exec/DDLExecutor.java CHANGES
        Hide
        jhkim Jinho Kim added a comment -

        committed it

        Show
        jhkim Jinho Kim added a comment - committed it
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #847 (See https://builds.apache.org/job/Tajo-master-build/847/)
        TAJO-1729: No handling of default case in DDLExecutor. (Contributed by Dongkyu Hwangbo, committed by Jinho) (jhkim: rev a460978d996f95259b2935d479ccfc676b141e05)

        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/master/exec/DDLExecutor.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #847 (See https://builds.apache.org/job/Tajo-master-build/847/ ) TAJO-1729 : No handling of default case in DDLExecutor. (Contributed by Dongkyu Hwangbo, committed by Jinho) (jhkim: rev a460978d996f95259b2935d479ccfc676b141e05) CHANGES tajo-core/src/main/java/org/apache/tajo/master/exec/DDLExecutor.java
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-0.11.0-build #24 (See https://builds.apache.org/job/Tajo-0.11.0-build/24/)
        TAJO-1729: No handling of default case in DDLExecutor. (Contributed by Dongkyu Hwangbo. Committed by jinho) (jhkim: rev cae8e56f05bf55e438f6d253ca130bb85c5da945)

        • tajo-core/src/main/java/org/apache/tajo/master/exec/DDLExecutor.java
        • CHANGES
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-0.11.0-build #24 (See https://builds.apache.org/job/Tajo-0.11.0-build/24/ ) TAJO-1729 : No handling of default case in DDLExecutor. (Contributed by Dongkyu Hwangbo. Committed by jinho) (jhkim: rev cae8e56f05bf55e438f6d253ca130bb85c5da945) tajo-core/src/main/java/org/apache/tajo/master/exec/DDLExecutor.java CHANGES

          People

          • Assignee:
            dkhwangbo Dongkyu Hwangbo
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development