Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1707

Rack local count can be more than actual number of tasks.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0, 0.12.0
    • Component/s: TajoMaster, Web UI
    • Labels:
      None

      Description

      See the title. I can see the wrong count of rack local at http://host:port/querytasks.jsp in TajoMaster. The count is greater than actual number of tasks.

      # Tasks:	23 (Local Tasks: 0, Rack Local Tasks: 27)
      

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jinossy opened a pull request:

        https://github.com/apache/tajo/pull/717

        TAJO-1707: Rack local count can be more than actual number of tasks.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jinossy/tajo TAJO-1707

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/717.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #717


        commit 5043f23a764d43e7b2ceab67001b79cda272486c
        Author: Jinho Kim <jhkim@apache.org>
        Date: 2015-09-02T03:19:25Z

        TAJO-1707: Rack local count can be more than actual number of tasks.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/717 TAJO-1707 : Rack local count can be more than actual number of tasks. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-1707 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/717.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #717 commit 5043f23a764d43e7b2ceab67001b79cda272486c Author: Jinho Kim <jhkim@apache.org> Date: 2015-09-02T03:19:25Z TAJO-1707 : Rack local count can be more than actual number of tasks.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/717#issuecomment-136925591

        I've remove the cancellation count

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/717#issuecomment-136925591 I've remove the cancellation count
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12753674/TAJO-1707.patch
        against master revision release-0.9.0-rc0-434-g2c9305a.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to cause Findbugs (version 2.0.3) to fail.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/830//testReport/
        Findbugs results: https://builds.apache.org/job/PreCommit-TAJO-Build/830//findbugsResult
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/830//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12753674/TAJO-1707.patch against master revision release-0.9.0-rc0-434-g2c9305a. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to cause Findbugs (version 2.0.3) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/830//testReport/ Findbugs results: https://builds.apache.org/job/PreCommit-TAJO-Build/830//findbugsResult Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/830//console This message is automatically generated.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/717#issuecomment-136953058

        This patch looks good, but totalAssigned is the sum of only hostLocalAssigned and rackLocalAssigned. How about adding a new variable to keep the total number of attempts including cancelled attempts?

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/717#issuecomment-136953058 This patch looks good, but totalAssigned is the sum of only hostLocalAssigned and rackLocalAssigned. How about adding a new variable to keep the total number of attempts including cancelled attempts?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/717#issuecomment-136956371

        Good idea. I'm going to add totalAttempts

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/717#issuecomment-136956371 Good idea. I'm going to add totalAttempts
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/717#issuecomment-136963971

        +1 LGTM!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/717#issuecomment-136963971 +1 LGTM!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/717

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/717
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #468 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/468/)
        TAJO-1707: Rack local count can be more than actual number of tasks. (jhkim: rev f2c434332822fbf53d9b22810509baf5c9718e56)

        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/querymaster/AbstractTaskScheduler.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/DefaultTaskScheduler.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #468 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/468/ ) TAJO-1707 : Rack local count can be more than actual number of tasks. (jhkim: rev f2c434332822fbf53d9b22810509baf5c9718e56) CHANGES tajo-core/src/main/java/org/apache/tajo/querymaster/AbstractTaskScheduler.java tajo-core/src/main/java/org/apache/tajo/querymaster/DefaultTaskScheduler.java
        Hide
        jhkim Jinho Kim added a comment -

        committed it
        Thanks

        Show
        jhkim Jinho Kim added a comment - committed it Thanks
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #824 (See https://builds.apache.org/job/Tajo-master-build/824/)
        TAJO-1707: Rack local count can be more than actual number of tasks. (jhkim: rev f2c434332822fbf53d9b22810509baf5c9718e56)

        • tajo-core/src/main/java/org/apache/tajo/querymaster/AbstractTaskScheduler.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/DefaultTaskScheduler.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #824 (See https://builds.apache.org/job/Tajo-master-build/824/ ) TAJO-1707 : Rack local count can be more than actual number of tasks. (jhkim: rev f2c434332822fbf53d9b22810509baf5c9718e56) tajo-core/src/main/java/org/apache/tajo/querymaster/AbstractTaskScheduler.java tajo-core/src/main/java/org/apache/tajo/querymaster/DefaultTaskScheduler.java CHANGES
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.11.0-build #5 (See https://builds.apache.org/job/Tajo-0.11.0-build/5/)
        TAJO-1707: Rack local count can be more than actual number of tasks. (jhkim: rev d12f7251b752a7bc7ac97d93303b7bd8d2e4c94c)

        • tajo-core/src/main/java/org/apache/tajo/querymaster/DefaultTaskScheduler.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/querymaster/AbstractTaskScheduler.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.11.0-build #5 (See https://builds.apache.org/job/Tajo-0.11.0-build/5/ ) TAJO-1707 : Rack local count can be more than actual number of tasks. (jhkim: rev d12f7251b752a7bc7ac97d93303b7bd8d2e4c94c) tajo-core/src/main/java/org/apache/tajo/querymaster/DefaultTaskScheduler.java CHANGES tajo-core/src/main/java/org/apache/tajo/querymaster/AbstractTaskScheduler.java

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development