Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1701

Remove forward or non-forward query concept in TajoClient

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: Java Client, TajoMaster
    • Labels:
      None

      Description

      So far, TajoMaster and TajoClient have a protocol about forward or non-forward queries. For each case, TajoClient executes a different code path. But, now, there is no separation because all query results come through TajoMaster. This patch will remove the legacy code of them.

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-build #773 (See https://builds.apache.org/job/Tajo-master-build/773/)
          TAJO-1701: Remove forward or non-forward query concept in TajoClient. (hyunsik: rev c294d88e12216a0ccee695957d01b51d57edeb87)

          • tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoStatement.java
          • tajo-core/src/main/java/org/apache/tajo/master/QueryManager.java
          • tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java
          • tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java
          • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/TajoCli.java
          • tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java
          • tajo-core/src/main/java/org/apache/tajo/webapp/QueryExecutorServlet.java
          • CHANGES
          • tajo-client/src/main/java/org/apache/tajo/client/TajoClientUtil.java
          • tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java
          • tajo-client/src/main/proto/ClientProtos.proto
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #773 (See https://builds.apache.org/job/Tajo-master-build/773/ ) TAJO-1701 : Remove forward or non-forward query concept in TajoClient. (hyunsik: rev c294d88e12216a0ccee695957d01b51d57edeb87) tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoStatement.java tajo-core/src/main/java/org/apache/tajo/master/QueryManager.java tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/TajoCli.java tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java tajo-core/src/main/java/org/apache/tajo/webapp/QueryExecutorServlet.java CHANGES tajo-client/src/main/java/org/apache/tajo/client/TajoClientUtil.java tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java tajo-client/src/main/proto/ClientProtos.proto
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Tajo-master-CODEGEN-build #410 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/410/)
          TAJO-1701: Remove forward or non-forward query concept in TajoClient. (hyunsik: rev c294d88e12216a0ccee695957d01b51d57edeb87)

          • tajo-core/src/main/java/org/apache/tajo/webapp/QueryExecutorServlet.java
          • tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java
          • tajo-client/src/main/proto/ClientProtos.proto
          • tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java
          • tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoStatement.java
          • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/TajoCli.java
          • tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java
          • tajo-core/src/main/java/org/apache/tajo/master/QueryManager.java
          • CHANGES
          • tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java
          • tajo-client/src/main/java/org/apache/tajo/client/TajoClientUtil.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #410 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/410/ ) TAJO-1701 : Remove forward or non-forward query concept in TajoClient. (hyunsik: rev c294d88e12216a0ccee695957d01b51d57edeb87) tajo-core/src/main/java/org/apache/tajo/webapp/QueryExecutorServlet.java tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java tajo-client/src/main/proto/ClientProtos.proto tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoStatement.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/TajoCli.java tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java tajo-core/src/main/java/org/apache/tajo/master/QueryManager.java CHANGES tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java tajo-client/src/main/java/org/apache/tajo/client/TajoClientUtil.java
          Hide
          hyunsik Hyunsik Choi added a comment -

          committed.

          Show
          hyunsik Hyunsik Choi added a comment - committed.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tajo/pull/645

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/645
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jinossy commented on the pull request:

          https://github.com/apache/tajo/pull/645#issuecomment-124349690

          +1 LGTM!!

          Show
          githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/645#issuecomment-124349690 +1 LGTM!!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik commented on the pull request:

          https://github.com/apache/tajo/pull/645#issuecomment-124344288

          I just rebased. It was just a conflict in changelog. You can review it now

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/645#issuecomment-124344288 I just rebased. It was just a conflict in changelog. You can review it now
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jinossy commented on the pull request:

          https://github.com/apache/tajo/pull/645#issuecomment-124337831

          @hyunsik rebase please?

          Show
          githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/645#issuecomment-124337831 @hyunsik rebase please?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik commented on the pull request:

          https://github.com/apache/tajo/pull/645#issuecomment-124310452

          I just rebased against the latest revision.

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/645#issuecomment-124310452 I just rebased against the latest revision.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik commented on the pull request:

          https://github.com/apache/tajo/pull/645#issuecomment-124154799

          This patch simplified the code path to fetch query result data. This patch is ready to be reviewed.

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/645#issuecomment-124154799 This patch simplified the code path to fetch query result data. This patch is ready to be reviewed.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user hyunsik opened a pull request:

          https://github.com/apache/tajo/pull/645

          TAJO-1701: Remove forward or non-forward query concept in TajoClient.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/hyunsik/tajo TAJO-1701

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tajo/pull/645.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #645


          commit f59736a795836c4020cd6105056c8ebb024cb754
          Author: Hyunsik Choi <hyunsik@apache.org>
          Date: 2015-07-23T08:15:46Z

          TAJO-1701: Remove forward or non-forward query concept in TajoClient.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/645 TAJO-1701 : Remove forward or non-forward query concept in TajoClient. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1701 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/645.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #645 commit f59736a795836c4020cd6105056c8ebb024cb754 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-07-23T08:15:46Z TAJO-1701 : Remove forward or non-forward query concept in TajoClient.

            People

            • Assignee:
              hyunsik Hyunsik Choi
              Reporter:
              hyunsik Hyunsik Choi
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development