Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1697

RCFile progress causes NPE occasionally

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.10.0, 0.10.1
    • Fix Version/s: 0.11.0
    • Component/s: Storage
    • Labels:
      None

      Description

      The progress updater can invoke before RCFile.init()

      2015-07-21 14:19:13,102 ERROR org.apache.tajo.worker.ExecutionBlockContext:
      java.lang.NullPointerException
             at org.apache.tajo.storage.rcfile.RCFile$RCFileScanner.getPosition(RCFile.java:1401)
             at org.apache.tajo.storage.rcfile.RCFile$RCFileScanner.getProgress(RCFile.java:1655)
             at org.apache.tajo.engine.planner.physical.SeqScanExec.getProgress(SeqScanExec.java:301)
             at org.apache.tajo.engine.planner.physical.UnaryPhysicalExec.getProgress(UnaryPhysicalExec.java:87)
             at org.apache.tajo.worker.TaskImpl.updateProgress(TaskImpl.java:305)
             at org.apache.tajo.worker.ExecutionBlockContext$Reporter$1.run(ExecutionBlockContext.java:409)
             at java.lang.Thread.run(Thread.java:745)
      

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jinossy opened a pull request:

        https://github.com/apache/tajo/pull/641

        TAJO-1697: RCFile progress causes NPE occasionally

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jinossy/tajo TAJO-1697

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/641.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #641


        commit 8bbe2dbaa00ed2a4f0c0da7ac3076b40caa961be
        Author: Jinho Kim <jhkim@apache.org>
        Date: 2015-07-22T08:46:39Z

        TAJO-1697: RCFile progress causes NPE occasionally


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/641 TAJO-1697 : RCFile progress causes NPE occasionally You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-1697 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/641.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #641 commit 8bbe2dbaa00ed2a4f0c0da7ac3076b40caa961be Author: Jinho Kim <jhkim@apache.org> Date: 2015-07-22T08:46:39Z TAJO-1697 : RCFile progress causes NPE occasionally
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/641#issuecomment-123634093

        +1 ship it!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/641#issuecomment-123634093 +1 ship it!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/641

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/641
        Hide
        jhkim Jinho Kim added a comment -

        Committed it.
        Thank you for your quick review!!

        Show
        jhkim Jinho Kim added a comment - Committed it. Thank you for your quick review!!
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-master-CODEGEN-build #402 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/402/)
        TAJO-1697: RCFile progress causes NPE occasionally. (jinho) (jhkim: rev 83228ce670370e7a8b2fa74c8683b8f1bd7b0ae3)

        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/text/DelimitedTextFile.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/rcfile/RCFile.java
        • CHANGES
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-CODEGEN-build #402 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/402/ ) TAJO-1697 : RCFile progress causes NPE occasionally. (jinho) (jhkim: rev 83228ce670370e7a8b2fa74c8683b8f1bd7b0ae3) tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/text/DelimitedTextFile.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/rcfile/RCFile.java CHANGES
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #763 (See https://builds.apache.org/job/Tajo-master-build/763/)
        TAJO-1697: RCFile progress causes NPE occasionally. (jinho) (jhkim: rev 83228ce670370e7a8b2fa74c8683b8f1bd7b0ae3)

        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/rcfile/RCFile.java
        • CHANGES
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/text/DelimitedTextFile.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #763 (See https://builds.apache.org/job/Tajo-master-build/763/ ) TAJO-1697 : RCFile progress causes NPE occasionally. (jinho) (jhkim: rev 83228ce670370e7a8b2fa74c8683b8f1bd7b0ae3) tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/rcfile/RCFile.java CHANGES tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/text/DelimitedTextFile.java

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development