Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1689

Metrics file reporter prints histogram metric without group name.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: Worker
    • Labels:
      None

      Description

      See the title.

      Other metic types prints like $

      {histogram type}

      $

      {group name}

      . The below example are the normal case.

      1436950011080 127.0.0.1:26001 guage tajomaster-jvm.File=0.0408203125
      1436950011080 127.0.0.1:26001 guage tajomaster-jvm.Thread terminated.count=0,timed_waiting.count=11,count=30,blocked.count=1,new.count=0,deadlocks=[],runnable.count=11,daemon.count=12,waiting.count=7
      

      But, the histogram type omits group name.

      1437039285473 tajo-h03.gruter.com:28091 histo running.count=293|running.min=1|running.max=8|running.mean=3.67|running.stddev=1.34|running.median=4.00|running.75%=4.00|running.95%=7.00|running.98%=8.00|running.99%=8.00|running.999%=8.00
      

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/633

        TAJO-1689: Metrics file reporter prints histogram metric without group name.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-1689

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/633.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #633


        commit 1e62a9ccf6caf9bcba647db754197045ffd5cdfe
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-07-17T09:28:37Z

        TAJO-1689: Metrics file reporter prints histogram metric without group name.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/633 TAJO-1689 : Metrics file reporter prints histogram metric without group name. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1689 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/633.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #633 commit 1e62a9ccf6caf9bcba647db754197045ffd5cdfe Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-07-17T09:28:37Z TAJO-1689 : Metrics file reporter prints histogram metric without group name.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/633#issuecomment-122840617

        +1 Ship it!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/633#issuecomment-122840617 +1 Ship it!
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed.

        Show
        hyunsik Hyunsik Choi added a comment - committed.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/633

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/633
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-master-CODEGEN-build #396 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/396/)
        TAJO-1689: Metrics file reporter prints histogram metric without group name. (hyunsik: rev 008940ccbd8eb85365c37767581e427d4ea6400c)

        • tajo-core/src/main/java/org/apache/tajo/util/metrics/reporter/TajoMetricsReporter.java
        • CHANGES
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-CODEGEN-build #396 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/396/ ) TAJO-1689 : Metrics file reporter prints histogram metric without group name. (hyunsik: rev 008940ccbd8eb85365c37767581e427d4ea6400c) tajo-core/src/main/java/org/apache/tajo/util/metrics/reporter/TajoMetricsReporter.java CHANGES
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #757 (See https://builds.apache.org/job/Tajo-master-build/757/)
        TAJO-1689: Metrics file reporter prints histogram metric without group name. (hyunsik: rev 008940ccbd8eb85365c37767581e427d4ea6400c)

        • tajo-core/src/main/java/org/apache/tajo/util/metrics/reporter/TajoMetricsReporter.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #757 (See https://builds.apache.org/job/Tajo-master-build/757/ ) TAJO-1689 : Metrics file reporter prints histogram metric without group name. (hyunsik: rev 008940ccbd8eb85365c37767581e427d4ea6400c) tajo-core/src/main/java/org/apache/tajo/util/metrics/reporter/TajoMetricsReporter.java CHANGES

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development