Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1638

Remove offset parameter from rest api result/{cacheId}

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: None
    • Labels:
      None

      Description

      in result/

      {cacheId}

      rest api.
      offset parameter can make user confused.
      because offset can't go back.
      It's only set forward(not backward)

      and add 3 new header for result response.
      X-Tajo-Offset : from start offset
      X-Tajo-Count: fetch count
      X-Tajo-EOS: if there is end stream. it sets EOS true

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user charsyam opened a pull request:

        https://github.com/apache/tajo/pull/599

        TAJO-1638 Remove offset parameter from rest api result/

        {cacheId}

        in result/{cacheId}

        rest api.
        offset parameter can make user confused.
        because offset can't go back.
        It's only set forward(not backward)
        and add 3 new header for result response.
        X-Tajo-Offset : from start offset
        X-Tajo-Count: fetch count
        X-Tajo-EOS: if there is end stream. it sets EOS true

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/charsyam/tajo feature/rest-api-remove-offset

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/599.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #599


        commit d58f48fddf8485621d914bcb45cf64cca0285eb7
        Author: clark.kang <clark.kang@kakao.com>
        Date: 2015-06-05T13:56:42Z

        remove-offset


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user charsyam opened a pull request: https://github.com/apache/tajo/pull/599 TAJO-1638 Remove offset parameter from rest api result/ {cacheId} in result/{cacheId} rest api. offset parameter can make user confused. because offset can't go back. It's only set forward(not backward) and add 3 new header for result response. X-Tajo-Offset : from start offset X-Tajo-Count: fetch count X-Tajo-EOS: if there is end stream. it sets EOS true You can merge this pull request into a Git repository by running: $ git pull https://github.com/charsyam/tajo feature/rest-api-remove-offset Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/599.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #599 commit d58f48fddf8485621d914bcb45cf64cca0285eb7 Author: clark.kang <clark.kang@kakao.com> Date: 2015-06-05T13:56:42Z remove-offset
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/599#issuecomment-112221427

        @charsyam

        Thanks for your contribution.
        But I failed to merge this patch as following

        ```
        Auto-merging tajo-core/src/test/java/org/apache/tajo/ws/rs/resources/TestQueryResultResource.java
        Auto-merging tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/QueryResultResource.java
        CONFLICT (content): Merge conflict in tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/QueryResultResource.java
        Automatic merge failed; fix conflicts and then commit the result.
        ```

        Could you check it ?

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/599#issuecomment-112221427 @charsyam Thanks for your contribution. But I failed to merge this patch as following ``` Auto-merging tajo-core/src/test/java/org/apache/tajo/ws/rs/resources/TestQueryResultResource.java Auto-merging tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/QueryResultResource.java CONFLICT (content): Merge conflict in tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/QueryResultResource.java Automatic merge failed; fix conflicts and then commit the result. ``` Could you check it ?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user charsyam commented on the pull request:

        https://github.com/apache/tajo/pull/599#issuecomment-112310132

        @blrunner
        HI, Thanks. I rebased it

        Show
        githubbot ASF GitHub Bot added a comment - Github user charsyam commented on the pull request: https://github.com/apache/tajo/pull/599#issuecomment-112310132 @blrunner HI, Thanks. I rebased it
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/599#issuecomment-116374970

        +1

        Thank you for your contribution.

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/599#issuecomment-116374970 +1 Thank you for your contribution.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/599

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/599
        Hide
        blrunner Jaehwa Jung added a comment -

        I've just committed to the master branch.

        Show
        blrunner Jaehwa Jung added a comment - I've just committed to the master branch.
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-master-CODEGEN-build #384 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/384/)
        TAJO-1638: Remove offset parameter from rest api result/

        {cacheId}

        . (blrunner: rev 773c3eb94ad3c3a6bc3b8db7692a9a38a5f3e8af)

        • tajo-core/src/test/java/org/apache/tajo/ws/rs/resources/TestQueryResultResource.java
        • tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/QueryResultResource.java
        • CHANGES
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-CODEGEN-build #384 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/384/ ) TAJO-1638 : Remove offset parameter from rest api result/ {cacheId} . (blrunner: rev 773c3eb94ad3c3a6bc3b8db7692a9a38a5f3e8af) tajo-core/src/test/java/org/apache/tajo/ws/rs/resources/TestQueryResultResource.java tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/QueryResultResource.java CHANGES
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #744 (See https://builds.apache.org/job/Tajo-master-build/744/)
        TAJO-1638: Remove offset parameter from rest api result/

        {cacheId}

        . (blrunner: rev 773c3eb94ad3c3a6bc3b8db7692a9a38a5f3e8af)

        • tajo-core/src/test/java/org/apache/tajo/ws/rs/resources/TestQueryResultResource.java
        • tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/QueryResultResource.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #744 (See https://builds.apache.org/job/Tajo-master-build/744/ ) TAJO-1638 : Remove offset parameter from rest api result/ {cacheId} . (blrunner: rev 773c3eb94ad3c3a6bc3b8db7692a9a38a5f3e8af) tajo-core/src/test/java/org/apache/tajo/ws/rs/resources/TestQueryResultResource.java tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/QueryResultResource.java CHANGES

          People

          • Assignee:
            charsyam DaeMyung Kang
            Reporter:
            charsyam DaeMyung Kang
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development