Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: TajoMaster
    • Labels:
      None

      Description

      This patch removes some "system.out.println" statements and change some APIs of TajoMasterClientServiceProtocol to use SessionedStringProto.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/594

        TAJO-1633: Cleanup TajoMasterClientService.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-1633

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/594.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #594


        commit 48ac2aa4880e3763c4896e41fabd281d06bb44e9
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-05-31T08:02:53Z

        TAJO-1633: Cleanup TajoMasterClientService.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/594 TAJO-1633 : Cleanup TajoMasterClientService. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1633 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/594.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #594 commit 48ac2aa4880e3763c4896e41fabd281d06bb44e9 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-05-31T08:02:53Z TAJO-1633 : Cleanup TajoMasterClientService.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/594#issuecomment-109517882

        +1

        It looks good to me and all unit test case passed successfully.
        Ship it!

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/594#issuecomment-109517882 +1 It looks good to me and all unit test case passed successfully. Ship it!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/594

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/594
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed.

        Show
        hyunsik Hyunsik Choi added a comment - committed.
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-master-CODEGEN-build #370 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/370/)
        TAJO-1633: Cleanup TajoMasterClientService. (hyunsik: rev d926247dcaba0af8d810c54a7c668272c3c86ea5)

        • tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java
        • tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java
        • tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClientImpl.java
        • tajo-client/src/main/proto/TajoMasterClientProtocol.proto
        • tajo-client/src/main/proto/ClientProtos.proto
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-CODEGEN-build #370 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/370/ ) TAJO-1633 : Cleanup TajoMasterClientService. (hyunsik: rev d926247dcaba0af8d810c54a7c668272c3c86ea5) tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClientImpl.java tajo-client/src/main/proto/TajoMasterClientProtocol.proto tajo-client/src/main/proto/ClientProtos.proto
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #731 (See https://builds.apache.org/job/Tajo-master-build/731/)
        TAJO-1633: Cleanup TajoMasterClientService. (hyunsik: rev d926247dcaba0af8d810c54a7c668272c3c86ea5)

        • tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java
        • tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClientImpl.java
        • tajo-client/src/main/proto/ClientProtos.proto
        • tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java
        • tajo-client/src/main/proto/TajoMasterClientProtocol.proto
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #731 (See https://builds.apache.org/job/Tajo-master-build/731/ ) TAJO-1633 : Cleanup TajoMasterClientService. (hyunsik: rev d926247dcaba0af8d810c54a7c668272c3c86ea5) tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClientImpl.java tajo-client/src/main/proto/ClientProtos.proto tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java tajo-client/src/main/proto/TajoMasterClientProtocol.proto

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development