Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1626

JdbcConnection::setAutoCommit() should not throw an exception.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0, 0.10.1, 0.10.2
    • Component/s: JDBC Driver
    • Labels:
      None

      Description

      See the title. JdbcConnection::setAutoCommit() is likely to be frequently invoked in many JDBC-based applications without special purpose. So, the current implementation that throws an SQLFeatureNotSupportedException causes errors in many applications.

      This patch removes the exception and instead adds log message.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/589

        TAJO-1626: JdbcConnection::setAutoCommit() should not throw an except…

        …ion.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-1626

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/589.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #589


        commit 652aa31c4f20727f2c2853368a819e52a9a7df91
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-05-27T09:30:20Z

        TAJO-1626: JdbcConnection::setAutoCommit() should not throw an exception.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/589 TAJO-1626 : JdbcConnection::setAutoCommit() should not throw an except… …ion. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1626 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/589.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #589 commit 652aa31c4f20727f2c2853368a819e52a9a7df91 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-05-27T09:30:20Z TAJO-1626 : JdbcConnection::setAutoCommit() should not throw an exception.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/589#issuecomment-105875984

        +1 ship it!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/589#issuecomment-105875984 +1 ship it!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/589

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/589
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed.

        Show
        hyunsik Hyunsik Choi added a comment - committed.
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-master-CODEGEN-build #364 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/364/)
        TAJO-1626: JdbcConnection::setAutoCommit() should not throw an exception. (hyunsik: rev 39fdadcf760729e3b933a033aec52aaeadd7ec03)

        • tajo-jdbc/src/main/java/org/apache/tajo/jdbc/JdbcConnection.java
        • CHANGES
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-CODEGEN-build #364 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/364/ ) TAJO-1626 : JdbcConnection::setAutoCommit() should not throw an exception. (hyunsik: rev 39fdadcf760729e3b933a033aec52aaeadd7ec03) tajo-jdbc/src/main/java/org/apache/tajo/jdbc/JdbcConnection.java CHANGES
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #724 (See https://builds.apache.org/job/Tajo-master-build/724/)
        TAJO-1626: JdbcConnection::setAutoCommit() should not throw an exception. (hyunsik: rev 39fdadcf760729e3b933a033aec52aaeadd7ec03)

        • CHANGES
        • tajo-jdbc/src/main/java/org/apache/tajo/jdbc/JdbcConnection.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #724 (See https://builds.apache.org/job/Tajo-master-build/724/ ) TAJO-1626 : JdbcConnection::setAutoCommit() should not throw an exception. (hyunsik: rev 39fdadcf760729e3b933a033aec52aaeadd7ec03) CHANGES tajo-jdbc/src/main/java/org/apache/tajo/jdbc/JdbcConnection.java

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development