Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1607

Tajo Rest Cache-Id should be bigger than zero

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: None
    • Labels:
      None

      Description

      currently, tajo rest api can return cache-id that is smaller than 0.
      but it is not beautiful, so I think it is better cache id is begger than 0

      ```

      {'link': 'http://127.0.0.1:26880/rest/databases/default/queries/q_1431795664397_0008/result/-2197002215675989303', 'id': -2197002215675989303}

      ```

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #710 (See https://builds.apache.org/job/Tajo-master-build/710/)
        TAJO-1607: Tajo Rest Cache-Id should be bigger than zero. (hyunsik: rev 3870a61b228f7c2dd3e3073dc033b03c248fab39)

        • tajo-core/src/main/java/org/apache/tajo/ws/rs/ClientApplication.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #710 (See https://builds.apache.org/job/Tajo-master-build/710/ ) TAJO-1607 : Tajo Rest Cache-Id should be bigger than zero. (hyunsik: rev 3870a61b228f7c2dd3e3073dc033b03c248fab39) tajo-core/src/main/java/org/apache/tajo/ws/rs/ClientApplication.java CHANGES
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #349 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/349/)
        TAJO-1607: Tajo Rest Cache-Id should be bigger than zero. (hyunsik: rev 3870a61b228f7c2dd3e3073dc033b03c248fab39)

        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/ws/rs/ClientApplication.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #349 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/349/ ) TAJO-1607 : Tajo Rest Cache-Id should be bigger than zero. (hyunsik: rev 3870a61b228f7c2dd3e3073dc033b03c248fab39) CHANGES tajo-core/src/main/java/org/apache/tajo/ws/rs/ClientApplication.java
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user charsyam closed the pull request at:

        https://github.com/apache/tajo/pull/572

        Show
        githubbot ASF GitHub Bot added a comment - Github user charsyam closed the pull request at: https://github.com/apache/tajo/pull/572
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/572#issuecomment-103007089

        @charsyam I've just committed it to master branch. I missed to add an github command to close this issue. Could you please close this ticket?

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/572#issuecomment-103007089 @charsyam I've just committed it to master branch. I missed to add an github command to close this issue. Could you please close this ticket?
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed.

        Show
        hyunsik Hyunsik Choi added a comment - committed.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/572#issuecomment-103005840

        +1

        the change looks straightforward.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/572#issuecomment-103005840 +1 the change looks straightforward.
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user charsyam opened a pull request:

        https://github.com/apache/tajo/pull/572

        TAJO-1607 Tajo Rest Cache-Id should be bigger than zero

        currently, tajo rest api can return cache-id that is smaller than 0.
        but it is not beautiful, so I think it is better cache id is begger than 0
        ```

        {'link': 'http://127.0.0.1:26880/rest/databases/default/queries/q_1431795664397_0008/result/-2197002215675989303', 'id': -2197002215675989303}

        ```

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/charsyam/tajo feature/create-cache-id-overzero

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/572.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #572


        commit 592be400c1a523bbb2ccd6ad9837151e571429b4
        Author: clark.kang <clark.kang@kakao.com>
        Date: 2015-05-16T17:09:27Z

        cache-id should be unsigned


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user charsyam opened a pull request: https://github.com/apache/tajo/pull/572 TAJO-1607 Tajo Rest Cache-Id should be bigger than zero currently, tajo rest api can return cache-id that is smaller than 0. but it is not beautiful, so I think it is better cache id is begger than 0 ``` {'link': 'http://127.0.0.1:26880/rest/databases/default/queries/q_1431795664397_0008/result/-2197002215675989303', 'id': -2197002215675989303} ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/charsyam/tajo feature/create-cache-id-overzero Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/572.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #572 commit 592be400c1a523bbb2ccd6ad9837151e571429b4 Author: clark.kang <clark.kang@kakao.com> Date: 2015-05-16T17:09:27Z cache-id should be unsigned

          People

          • Assignee:
            charsyam DaeMyung Kang
            Reporter:
            charsyam DaeMyung Kang
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development