Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1605

Fix master build failure on jdk 1.6

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0, 0.10.1
    • Component/s: Build
    • Labels:
      None

      Description

      java.net.Socket does not use the Closeable interface on jdk 1.6

      [ERROR] COMPILATION ERROR : 
      [INFO] -------------------------------------------------------------
      [ERROR] /home/jenkins/jenkins-slave/workspace/Tajo-master-build/tajo-common/src/main/java/org/apache/tajo/service/HAServiceTracker.java:[62,14] cleanup(org.apache.commons.logging.Log,java.io.Closeable...) in org.apache.tajo.util.FileUtil cannot be applied to (org.apache.commons.logging.Log,java.net.Socket)
      [INFO] 19 errors 
      
      1. TAJO-1605_2.patch
        2 kB
        Jinho Kim
      2. TAJO-1605.patch
        1 kB
        Jinho Kim

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jinossy opened a pull request:

        https://github.com/apache/tajo/pull/569

        TAJO-1605: Fix master build failure on jdk 1.6

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jinossy/tajo TAJO-1605

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/569.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #569


        commit 04f03713fc78056b6f90b3edcfc157cf9e4967f7
        Author: Jinho Kim <jhkim@apache.org>
        Date: 2015-05-15T01:28:23Z

        TAJO-1605: Fix master build failure on jdk 1.6


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/569 TAJO-1605 : Fix master build failure on jdk 1.6 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-1605 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/569.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #569 commit 04f03713fc78056b6f90b3edcfc157cf9e4967f7 Author: Jinho Kim <jhkim@apache.org> Date: 2015-05-15T01:28:23Z TAJO-1605 : Fix master build failure on jdk 1.6
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/569#issuecomment-102217503

        +1 thanks for quick fix!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/569#issuecomment-102217503 +1 thanks for quick fix!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/569#issuecomment-102225091

        @jihoonson
        Thank you for your quick review.
        I've update the patch. Could you review again?

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/569#issuecomment-102225091 @jihoonson Thank you for your quick review. I've update the patch. Could you review again?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/569#issuecomment-102231932

        +1 LGTM!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/569#issuecomment-102231932 +1 LGTM!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/569

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/569
        Hide
        jhkim Jinho Kim added a comment -

        committed it.
        Thanks

        Show
        jhkim Jinho Kim added a comment - committed it. Thanks
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-master-CODEGEN-build #346 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/346/)
        TAJO-1605: Fix master build failure on jdk 1.6. (jinho) (jhkim: rev f3acbdf5c69e7cf5a892ea2c07b9548c648cd64f)

        • tajo-common/src/main/java/org/apache/tajo/service/HAServiceTracker.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/worker/WorkerHeartbeatService.java
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-CODEGEN-build #346 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/346/ ) TAJO-1605 : Fix master build failure on jdk 1.6. (jinho) (jhkim: rev f3acbdf5c69e7cf5a892ea2c07b9548c648cd64f) tajo-common/src/main/java/org/apache/tajo/service/HAServiceTracker.java CHANGES tajo-core/src/main/java/org/apache/tajo/worker/WorkerHeartbeatService.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #706 (See https://builds.apache.org/job/Tajo-master-build/706/)
        TAJO-1605: Fix master build failure on jdk 1.6. (jinho) (jhkim: rev f3acbdf5c69e7cf5a892ea2c07b9548c648cd64f)

        • tajo-core/src/main/java/org/apache/tajo/worker/WorkerHeartbeatService.java
        • CHANGES
        • tajo-common/src/main/java/org/apache/tajo/service/HAServiceTracker.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #706 (See https://builds.apache.org/job/Tajo-master-build/706/ ) TAJO-1605 : Fix master build failure on jdk 1.6. (jinho) (jhkim: rev f3acbdf5c69e7cf5a892ea2c07b9548c648cd64f) tajo-core/src/main/java/org/apache/tajo/worker/WorkerHeartbeatService.java CHANGES tajo-common/src/main/java/org/apache/tajo/service/HAServiceTracker.java

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development