Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: Storage
    • Labels:
      None

      Description

      This patch refactors StorageManager. Especially, it apparently separates multiple roles into different classes.

      • Static methods which handle registered store types are moved to TableSpaceManager.
      • All methods related for file store types are moved to FileStorageManager.
      • I created TableSpace, an interface for tablespace and I modified StorageManager to inherit TableSpace.
      • Later, StorageManager will be changed to AbstractTableSpace.
      1. TAJO-1603.patch
        182 kB
        Hyunsik Choi

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #708 (See https://builds.apache.org/job/Tajo-master-build/708/)
        TAJO-1603: Refactor StorageManager. (hyunsik) (hyunsik: rev 5491f0e7507c7efa1b2306d4c1f1d25240e482a9)

        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/BSTIndexScanExec.java
        • tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestSortExec.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestLeftOuterHashJoinExec.java
        • tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/index/TestSingleCSVFileBSTIndex.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestHashJoinExec.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestFileStorageManager.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestHashAntiJoinExec.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestNLJoinExec.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/NonForwardQueryResultFileScanner.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestFullOuterMergeJoinExec.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestCompressionStorages.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ColPartitionStoreExec.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestBSTIndexExec.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestStorages.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SeqScanExec.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestExternalSortExec.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/FileStorageManager.java
        • tajo-core/src/test/java/org/apache/tajo/BackendTestingUtil.java
        • tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBasePutAppender.java
        • tajo-core/src/test/java/org/apache/tajo/jdbc/TestResultSet.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMasterTask.java
        • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/TableSpace.java
        • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/StorageManager.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestLineReader.java
        • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/MergeScanner.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/FileAppender.java
        • tajo-storage/tajo-storage-hbase/src/test/java/org/apache/tajo/storage/hbase/TestHBaseStorageManager.java
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestJoinBroadcast.java
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestHBaseTable.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestMergeJoinExec.java
        • tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseScanner.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestFullOuterHashJoinExec.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/index/TestBSTIndex.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestHashSemiJoinExec.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestBNLJoinExec.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/DDLExecutor.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java
        • tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseStorageManager.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/StoreTableExec.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestDelimitedTextFile.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/json/TestJsonSerDe.java
        • CHANGES
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestRightOuterMergeJoinExec.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestFileSystems.java
        • tajo-core/src/main/java/org/apache/tajo/worker/Task.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/Repartitioner.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestProgressExternalSortExec.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestMergeScanner.java
        • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/TableSpaceManager.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/Query.java
        • tajo-core/src/test/java/org/apache/tajo/master/TestExecutionBlockCursor.java
        • tajo-core/src/test/java/org/apache/tajo/storage/TestRowFile.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/RangeShuffleFileWriteExec.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestRightOuterHashJoinExec.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/global/TestBroadcastJoinPlan.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/HashShuffleAppenderManager.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #708 (See https://builds.apache.org/job/Tajo-master-build/708/ ) TAJO-1603 : Refactor StorageManager. (hyunsik) (hyunsik: rev 5491f0e7507c7efa1b2306d4c1f1d25240e482a9) tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/BSTIndexScanExec.java tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestSortExec.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestLeftOuterHashJoinExec.java tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/index/TestSingleCSVFileBSTIndex.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestHashJoinExec.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestFileStorageManager.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestHashAntiJoinExec.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestNLJoinExec.java tajo-core/src/main/java/org/apache/tajo/master/exec/NonForwardQueryResultFileScanner.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestFullOuterMergeJoinExec.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestCompressionStorages.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ColPartitionStoreExec.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestBSTIndexExec.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestStorages.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SeqScanExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestExternalSortExec.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/FileStorageManager.java tajo-core/src/test/java/org/apache/tajo/BackendTestingUtil.java tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBasePutAppender.java tajo-core/src/test/java/org/apache/tajo/jdbc/TestResultSet.java tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMasterTask.java tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/TableSpace.java tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/StorageManager.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestLineReader.java tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/MergeScanner.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/FileAppender.java tajo-storage/tajo-storage-hbase/src/test/java/org/apache/tajo/storage/hbase/TestHBaseStorageManager.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestJoinBroadcast.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestHBaseTable.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestMergeJoinExec.java tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseScanner.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestFullOuterHashJoinExec.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/index/TestBSTIndex.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestHashSemiJoinExec.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestBNLJoinExec.java tajo-core/src/main/java/org/apache/tajo/master/exec/DDLExecutor.java tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseStorageManager.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/StoreTableExec.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestDelimitedTextFile.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/json/TestJsonSerDe.java CHANGES tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestRightOuterMergeJoinExec.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestFileSystems.java tajo-core/src/main/java/org/apache/tajo/worker/Task.java tajo-core/src/main/java/org/apache/tajo/querymaster/Repartitioner.java tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestProgressExternalSortExec.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestMergeScanner.java tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/TableSpaceManager.java tajo-core/src/main/java/org/apache/tajo/querymaster/Query.java tajo-core/src/test/java/org/apache/tajo/master/TestExecutionBlockCursor.java tajo-core/src/test/java/org/apache/tajo/storage/TestRowFile.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/RangeShuffleFileWriteExec.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestRightOuterHashJoinExec.java tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java tajo-core/src/test/java/org/apache/tajo/engine/planner/global/TestBroadcastJoinPlan.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/HashShuffleAppenderManager.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #348 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/348/)
        TAJO-1603: Refactor StorageManager. (hyunsik) (hyunsik: rev 5491f0e7507c7efa1b2306d4c1f1d25240e482a9)

        • CHANGES
        • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/TableSpaceManager.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestHashAntiJoinExec.java
        • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/TableSpace.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestBSTIndexExec.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestMergeScanner.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/NonForwardQueryResultFileScanner.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java
        • tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
        • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/MergeScanner.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/StoreTableExec.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SeqScanExec.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestRightOuterMergeJoinExec.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestLineReader.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestHashSemiJoinExec.java
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestHBaseTable.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestFileSystems.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMasterTask.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestLeftOuterHashJoinExec.java
        • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/StorageManager.java
        • tajo-core/src/test/java/org/apache/tajo/storage/TestRowFile.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/index/TestBSTIndex.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/HashShuffleAppenderManager.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestHashJoinExec.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestMergeJoinExec.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/global/TestBroadcastJoinPlan.java
        • tajo-core/src/test/java/org/apache/tajo/master/TestExecutionBlockCursor.java
        • tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBasePutAppender.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/DDLExecutor.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestDelimitedTextFile.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/RangeShuffleFileWriteExec.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestRightOuterHashJoinExec.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestFullOuterHashJoinExec.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestProgressExternalSortExec.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestNLJoinExec.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/Query.java
        • tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseScanner.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/Repartitioner.java
        • tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java
        • tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseStorageManager.java
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestJoinBroadcast.java
        • tajo-core/src/main/java/org/apache/tajo/worker/Task.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/json/TestJsonSerDe.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/BSTIndexScanExec.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/FileStorageManager.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestSortExec.java
        • tajo-core/src/test/java/org/apache/tajo/jdbc/TestResultSet.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ColPartitionStoreExec.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/FileAppender.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestExternalSortExec.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestStorages.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestBNLJoinExec.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestFileStorageManager.java
        • tajo-core/src/test/java/org/apache/tajo/BackendTestingUtil.java
        • tajo-storage/tajo-storage-hbase/src/test/java/org/apache/tajo/storage/hbase/TestHBaseStorageManager.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestFullOuterMergeJoinExec.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/index/TestSingleCSVFileBSTIndex.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestCompressionStorages.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #348 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/348/ ) TAJO-1603 : Refactor StorageManager. (hyunsik) (hyunsik: rev 5491f0e7507c7efa1b2306d4c1f1d25240e482a9) CHANGES tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/TableSpaceManager.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestHashAntiJoinExec.java tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/TableSpace.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestBSTIndexExec.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestMergeScanner.java tajo-core/src/main/java/org/apache/tajo/master/exec/NonForwardQueryResultFileScanner.java tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/MergeScanner.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/StoreTableExec.java tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SeqScanExec.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestRightOuterMergeJoinExec.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestLineReader.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestHashSemiJoinExec.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestHBaseTable.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestFileSystems.java tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMasterTask.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestLeftOuterHashJoinExec.java tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/StorageManager.java tajo-core/src/test/java/org/apache/tajo/storage/TestRowFile.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/index/TestBSTIndex.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/HashShuffleAppenderManager.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestHashJoinExec.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestMergeJoinExec.java tajo-core/src/test/java/org/apache/tajo/engine/planner/global/TestBroadcastJoinPlan.java tajo-core/src/test/java/org/apache/tajo/master/TestExecutionBlockCursor.java tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBasePutAppender.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java tajo-core/src/main/java/org/apache/tajo/master/exec/DDLExecutor.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestDelimitedTextFile.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/RangeShuffleFileWriteExec.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestRightOuterHashJoinExec.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestFullOuterHashJoinExec.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestProgressExternalSortExec.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestNLJoinExec.java tajo-core/src/main/java/org/apache/tajo/querymaster/Query.java tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseScanner.java tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java tajo-core/src/main/java/org/apache/tajo/querymaster/Repartitioner.java tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseStorageManager.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestJoinBroadcast.java tajo-core/src/main/java/org/apache/tajo/worker/Task.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/json/TestJsonSerDe.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/BSTIndexScanExec.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/FileStorageManager.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestSortExec.java tajo-core/src/test/java/org/apache/tajo/jdbc/TestResultSet.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ColPartitionStoreExec.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/FileAppender.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestExternalSortExec.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestStorages.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestBNLJoinExec.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestFileStorageManager.java tajo-core/src/test/java/org/apache/tajo/BackendTestingUtil.java tajo-storage/tajo-storage-hbase/src/test/java/org/apache/tajo/storage/hbase/TestHBaseStorageManager.java tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestFullOuterMergeJoinExec.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/index/TestSingleCSVFileBSTIndex.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestCompressionStorages.java
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/570

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/570
        Hide
        hyunsik Hyunsik Choi added a comment -

        I've just committed to master branch.

        Show
        hyunsik Hyunsik Choi added a comment - I've just committed to master branch.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/570#issuecomment-102320462

        +1 ship it!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/570#issuecomment-102320462 +1 ship it!
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12733062/TAJO-1603.patch
        against master revision release-0.9.0-rc0-299-g36a703c.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 34 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 9 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core tajo-storage/tajo-storage-common tajo-storage/tajo-storage-hbase tajo-storage/tajo-storage-hdfs.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/788//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/788//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/788//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage-hbase.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/788//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12733062/TAJO-1603.patch against master revision release-0.9.0-rc0-299-g36a703c. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 34 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 9 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core tajo-storage/tajo-storage-common tajo-storage/tajo-storage-hbase tajo-storage/tajo-storage-hdfs. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/788//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/788//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/788//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage-hbase.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/788//console This message is automatically generated.
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/570

        TAJO-1603: Refactor StorageManager.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-1603

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/570.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #570


        commit f67099791bc991b4d553dfb223e1a5dec1c1c5dc
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-05-13T21:18:10Z

        Add some interfaces.

        commit 5837d3326faeb891847f06a32c5cc5ca25d07663
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-05-14T00:39:48Z

        Separate StorageManager into Tablespace and specific StorageManager.

        commit 8a50535708668290ec5edac3d2449ae17bf89eca
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-05-14T01:21:04Z

        Revert "Separate StorageManager into Tablespace and specific StorageManager."

        This reverts commit 5837d3326faeb891847f06a32c5cc5ca25d07663.

        commit d9677f2f195a3ca9807f7df5ca3cf5da96d3f008
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-05-14T01:30:09Z

        Separate StorageManager into Tablespace and specific StorageManager.

        commit 8396fc4744c1b2f20e5015e11c236bc1c6cb1995
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-05-14T01:33:24Z

        Change the signature of commitOutputdir.

        commit b9f1151605dace8ac656cf383339e55d1fd72f65
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-05-14T02:50:43Z

        Removed unused method.

        commit 27a803ed9311fc179d7bc4174b6bf1ca20a25e2f
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-05-14T04:07:33Z

        Move commitOutputdir to FileStorageManager.

        commit 702431a5bc675068c1bd66561deec67d63a686eb
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-05-15T04:00:22Z

        Removed some comments.

        commit 9a9f01ac1c62b18902c8f07bcca7789a9360c1d6
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2015-05-15T04:05:06Z

        Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into StorageRefactor

        Conflicts:
        tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestLeftOuterNLJoinExec.java


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/570 TAJO-1603 : Refactor StorageManager. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1603 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/570.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #570 commit f67099791bc991b4d553dfb223e1a5dec1c1c5dc Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-05-13T21:18:10Z Add some interfaces. commit 5837d3326faeb891847f06a32c5cc5ca25d07663 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-05-14T00:39:48Z Separate StorageManager into Tablespace and specific StorageManager. commit 8a50535708668290ec5edac3d2449ae17bf89eca Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-05-14T01:21:04Z Revert "Separate StorageManager into Tablespace and specific StorageManager." This reverts commit 5837d3326faeb891847f06a32c5cc5ca25d07663. commit d9677f2f195a3ca9807f7df5ca3cf5da96d3f008 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-05-14T01:30:09Z Separate StorageManager into Tablespace and specific StorageManager. commit 8396fc4744c1b2f20e5015e11c236bc1c6cb1995 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-05-14T01:33:24Z Change the signature of commitOutputdir. commit b9f1151605dace8ac656cf383339e55d1fd72f65 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-05-14T02:50:43Z Removed unused method. commit 27a803ed9311fc179d7bc4174b6bf1ca20a25e2f Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-05-14T04:07:33Z Move commitOutputdir to FileStorageManager. commit 702431a5bc675068c1bd66561deec67d63a686eb Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-05-15T04:00:22Z Removed some comments. commit 9a9f01ac1c62b18902c8f07bcca7789a9360c1d6 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-05-15T04:05:06Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into StorageRefactor Conflicts: tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestLeftOuterNLJoinExec.java

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development