Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1598

TableMeta should change equals mechanism

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0, 0.10.1
    • Component/s: None
    • Labels:
      None

      Description

      In TableMeta equals, it compares Proto Data.
      but TableMetaProto has params as KeyValueSetProto.
      It has a KeyValue Data as List.
      but it can cause comparison error. becuase list type compare items' order and value. but we should compare params like map.

      so this patch change compare machanism. compare storeType and Options

      1. TAJO-1598.patch
        3 kB
        DaeMyung Kang

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user charsyam opened a pull request:

        https://github.com/apache/tajo/pull/565

        TAJO-1598 TableMeta should change equals mechanism

        In TableMeta equals, it compares Proto Data.
        but TableMetaProto has params as KeyValueSetProto.
        It has a KeyValue Data as List.
        but it can cause comparison error. becuase list type compare items' order and value. but we should compare params like map.
        so this patch change compare machanism. compare storeType and Options

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/charsyam/tajo feature/fix_option_creation_order

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/565.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #565


        commit 3a75ec45946ed2b5e3c1941405da313b379012a2
        Author: clark.kang <clark.kang@kakao.com>
        Date: 2015-05-10T14:48:19Z

        feature/fix_option_creation_order

        restore protected to private

        change TableMeta equals code


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user charsyam opened a pull request: https://github.com/apache/tajo/pull/565 TAJO-1598 TableMeta should change equals mechanism In TableMeta equals, it compares Proto Data. but TableMetaProto has params as KeyValueSetProto. It has a KeyValue Data as List. but it can cause comparison error. becuase list type compare items' order and value. but we should compare params like map. so this patch change compare machanism. compare storeType and Options You can merge this pull request into a Git repository by running: $ git pull https://github.com/charsyam/tajo feature/fix_option_creation_order Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/565.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #565 commit 3a75ec45946ed2b5e3c1941405da313b379012a2 Author: clark.kang <clark.kang@kakao.com> Date: 2015-05-10T14:48:19Z feature/fix_option_creation_order restore protected to private change TableMeta equals code
        Hide
        charsyam DaeMyung Kang added a comment -

        patch.

        Show
        charsyam DaeMyung Kang added a comment - patch.
        Hide
        tajoqa Tajo QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12732243/TAJO-1598.patch
        against master revision release-0.9.0-rc0-294-g53ed1c3.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-common.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/781//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/781//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12732243/TAJO-1598.patch against master revision release-0.9.0-rc0-294-g53ed1c3. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-common. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/781//testReport/ Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/781//console This message is automatically generated.
        Hide
        jihoonson Jihoon Son added a comment -

        +1. LGTM!
        I'll commit shortly.

        Show
        jihoonson Jihoon Son added a comment - +1. LGTM! I'll commit shortly.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/565

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/565
        Hide
        jihoonson Jihoon Son added a comment -

        Committed to master and 0.10.1 branches.
        Thanks for your contribution!

        Show
        jihoonson Jihoon Son added a comment - Committed to master and 0.10.1 branches. Thanks for your contribution!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #342 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/342/)
        TAJO-1598: TableMeta should change equals mechanism. (jihoonson: rev 6977471e486ec9f77c24e17b51eef71f99978f13)

        • CHANGES
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableMeta.java
        • tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestTableMeta.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #342 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/342/ ) TAJO-1598 : TableMeta should change equals mechanism. (jihoonson: rev 6977471e486ec9f77c24e17b51eef71f99978f13) CHANGES tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableMeta.java tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestTableMeta.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #703 (See https://builds.apache.org/job/Tajo-master-build/703/)
        TAJO-1598: TableMeta should change equals mechanism. (jihoonson: rev 6977471e486ec9f77c24e17b51eef71f99978f13)

        • CHANGES
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableMeta.java
        • tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestTableMeta.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #703 (See https://builds.apache.org/job/Tajo-master-build/703/ ) TAJO-1598 : TableMeta should change equals mechanism. (jihoonson: rev 6977471e486ec9f77c24e17b51eef71f99978f13) CHANGES tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableMeta.java tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestTableMeta.java

          People

          • Assignee:
            charsyam DaeMyung Kang
            Reporter:
            charsyam DaeMyung Kang
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development