[TAJO-1581] Does not update last state of query stage in non-hash shuffle - ASF JIRA

Details

Type: Bug
Status: Resolved
Priority: Minor
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 0.11.0, 0.10.1
Component/s: QueryMaster, Web UI
Labels:
None

Description

Stage event should send to dispatcher

eb_1429774432104_0021_000005	SUCCEEDED	2015-04-23 16:34:07	2015-04-23 16:34:20	13.0 sec	100%	1186 / 1186	0 / 0
eb_1429774432104_0021_000006	FINALIZING	2015-04-23 16:34:20	2015-04-23 16:34:27	6.0 sec	100%	1 / 1	0 / 0
eb_1429774432104_0021_000007	FINALIZING	2015-04-23 16:34:27	2015-04-23 16:34:29	1.0 sec	100%	1 / 1	0 / 0

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending

Attachments

TAJO-1581_2.patch

27/Apr/15 02:18

7 kB

Jinho Kim
TAJO-1581.patch

24/Apr/15 15:14

6 kB

Jinho Kim

Issue Links

relates to

TAJO-1560 HashShuffle report should be ignored when a succeed tasks are not included

Resolved

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

ASF GitHub Bot added a comment - 24/Apr/15 15:15

GitHub user jinossy opened a pull request:

https://github.com/apache/tajo/pull/553

~~TAJO-1581~~: Does not update last stage state in range shuffle

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jinossy/tajo ~~TAJO-1581~~

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tajo/pull/553.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #553

commit 20eacb7af3e37674ca4a0e77859b13fcc6ca0222
Author: Jinho Kim <jhkim@apache.org>
Date: 2015-04-24T15:10:15Z

~~TAJO-1581~~: Does not update last stage state in range shuffle

Show

ASF GitHub Bot added a comment - 24/Apr/15 15:15 GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/553 TAJO-1581 : Does not update last stage state in range shuffle You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-1581 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/553.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #553 commit 20eacb7af3e37674ca4a0e77859b13fcc6ca0222 Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-24T15:10:15Z TAJO-1581 : Does not update last stage state in range shuffle

Hide

Permalink

Tajo QA added a comment - 24/Apr/15 15:57

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12727933/TAJO-1581.patch
against master revision release-0.9.0-rc0-272-g1434072.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 1 new or modified test files.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 javadoc. The applied patch does not increase the total number of javadoc warnings.

+1 checkstyle. The patch generated 0 code style errors.

-1 findbugs. The patch appears to introduce 18 new Findbugs (version 2.0.3) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

-1 core tests. The patch failed these unit tests in tajo-core:
org.apache.tajo.querymaster.TestQueryState

Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/757//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/757//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/757//console

This message is automatically generated.

Show

Tajo QA added a comment - 24/Apr/15 15:57 -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12727933/TAJO-1581.patch against master revision release-0.9.0-rc0-272-g1434072. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 18 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in tajo-core: org.apache.tajo.querymaster.TestQueryState Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/757//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/757//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/757//console This message is automatically generated.

Hide

Permalink

Jinho Kim added a comment - 27/Apr/15 02:18

I've fix broken test. I missed the heartbeat

Show

Jinho Kim added a comment - 27/Apr/15 02:18 I've fix broken test. I missed the heartbeat

Hide

Permalink

Tajo QA added a comment - 27/Apr/15 02:57

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12728290/TAJO-1581_2.patch
against master revision release-0.9.0-rc0-272-g1434072.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 1 new or modified test files.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 javadoc. The applied patch does not increase the total number of javadoc warnings.

+1 checkstyle. The patch generated 0 code style errors.

-1 findbugs. The patch appears to introduce 18 new Findbugs (version 2.0.3) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed unit tests in tajo-core.

Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/758//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/758//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/758//console

This message is automatically generated.

Show

Tajo QA added a comment - 27/Apr/15 02:57 -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12728290/TAJO-1581_2.patch against master revision release-0.9.0-rc0-272-g1434072. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 18 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/758//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/758//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/758//console This message is automatically generated.

Hide

Permalink

ASF GitHub Bot added a comment - 27/Apr/15 05:36

Github user jihoonson commented on a diff in the pull request:

https://github.com/apache/tajo/pull/553#discussion_r29121510

— Diff: tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java —
@@ -1405,14 +1405,14 @@ public void run()

{ stage.timeoutChecker.start(); }

} else {

stage.handle(new StageEvent(stage.getId(), StageEventType.SQ_STAGE_COMPLETED));
+ stage.getEventHandler().handle(new StageEvent(stage.getId(), StageEventType.SQ_STAGE_COMPLETED));
- - End diff –

nice finding.

Show

ASF GitHub Bot added a comment - 27/Apr/15 05:36 Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/553#discussion_r29121510 — Diff: tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java — @@ -1405,14 +1405,14 @@ public void run() { stage.timeoutChecker.start(); } } else { stage.handle(new StageEvent(stage.getId(), StageEventType.SQ_STAGE_COMPLETED)); + stage.getEventHandler().handle(new StageEvent(stage.getId(), StageEventType.SQ_STAGE_COMPLETED)); End diff – nice finding.

Hide

Permalink

ASF GitHub Bot added a comment - 27/Apr/15 05:36

Github user jihoonson commented on the pull request:

https://github.com/apache/tajo/pull/553#issuecomment-96512831

+1 ship it!

Show

ASF GitHub Bot added a comment - 27/Apr/15 05:36 Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/553#issuecomment-96512831 +1 ship it!

Hide

Permalink

ASF GitHub Bot added a comment - 27/Apr/15 05:48

Github user asfgit closed the pull request at:

https://github.com/apache/tajo/pull/553

Show

ASF GitHub Bot added a comment - 27/Apr/15 05:48 Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/553

Hide

Permalink

Jinho Kim added a comment - 27/Apr/15 05:49

committed it
Thanks

Show

Jinho Kim added a comment - 27/Apr/15 05:49 committed it Thanks

Hide

Permalink

Hudson added a comment - 27/Apr/15 06:08

FAILURE: Integrated in Tajo-master-CODEGEN-build #325 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/325/)
~~TAJO-1581~~: Does not update last state of query stage in non-hash shuffle. (jinho) (jhkim: rev 9acb3a63c455723651f2275c853a121c67824a0b)

CHANGES
tajo-core/src/test/java/org/apache/tajo/querymaster/TestQueryState.java
tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java

Show

Hudson added a comment - 27/Apr/15 06:08 FAILURE: Integrated in Tajo-master-CODEGEN-build #325 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/325/ ) TAJO-1581 : Does not update last state of query stage in non-hash shuffle. (jinho) (jhkim: rev 9acb3a63c455723651f2275c853a121c67824a0b) CHANGES tajo-core/src/test/java/org/apache/tajo/querymaster/TestQueryState.java tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java

Hide

Permalink

Hudson added a comment - 27/Apr/15 06:11

SUCCESS: Integrated in Tajo-master-build #687 (See https://builds.apache.org/job/Tajo-master-build/687/)
~~TAJO-1581~~: Does not update last state of query stage in non-hash shuffle. (jinho) (jhkim: rev 9acb3a63c455723651f2275c853a121c67824a0b)

tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java
CHANGES
tajo-core/src/test/java/org/apache/tajo/querymaster/TestQueryState.java

Show

Hudson added a comment - 27/Apr/15 06:11 SUCCESS: Integrated in Tajo-master-build #687 (See https://builds.apache.org/job/Tajo-master-build/687/ ) TAJO-1581 : Does not update last state of query stage in non-hash shuffle. (jinho) (jhkim: rev 9acb3a63c455723651f2275c853a121c67824a0b) tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java CHANGES tajo-core/src/test/java/org/apache/tajo/querymaster/TestQueryState.java

People

Assignee:

Jinho Kim

Reporter:

Jinho Kim

Votes:

0 Vote for this issue

Watchers:

3 Start watching this issue

Dates

Created:

24/Apr/15 10:02

Updated:

27/Apr/15 06:11

Resolved:

27/Apr/15 05:49

Development

Agile

View on Board