Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1578

User configuration for pull server port is ignored.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.12.0, 0.11.1
    • Component/s: None
    • Labels:

      Description

      See the title.
      When TajoPullServerService is initialized, it overwrites user-configured pull server port with the default value as follows.

      ...
      @Override
        public void init(Configuration conf) {
          try {
            manageOsCache = conf.getBoolean(SHUFFLE_MANAGE_OS_CACHE,
                DEFAULT_SHUFFLE_MANAGE_OS_CACHE);
      
            readaheadLength = conf.getInt(SHUFFLE_READAHEAD_BYTES,
                DEFAULT_SHUFFLE_READAHEAD_BYTES);
      
            int workerNum = conf.getInt("tajo.shuffle.rpc.server.worker-thread-num",
                Runtime.getRuntime().availableProcessors() * 2);
      
            selector = RpcChannelFactory.createServerChannelFactory("TajoPullServerService", workerNum)
                         .option(ChannelOption.TCP_NODELAY, true)
                         .childOption(ChannelOption.ALLOCATOR, PooledByteBufAllocator.DEFAULT)
                         .childOption(ChannelOption.TCP_NODELAY, true);
      
            localFS = new LocalFileSystem();
      
            conf.setInt(TajoConf.ConfVars.PULLSERVER_PORT.varname
                , TajoConf.ConfVars.PULLSERVER_PORT.defaultIntVal);
            super.init(conf);
            LOG.info("Tajo PullServer initialized: readaheadLength=" + readaheadLength);
          } catch (Throwable t) {
            LOG.error(t, t);
          }
        }
      ...
      

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #955 (See https://builds.apache.org/job/Tajo-master-build/955/)
        TAJO-1578: User configuration for pull server port is ignored. (jihoonson: rev 4189f91d78e01d2a9524b44990093db4c435dc17)

        • CHANGES
        • tajo-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #955 (See https://builds.apache.org/job/Tajo-master-build/955/ ) TAJO-1578 : User configuration for pull server port is ignored. (jihoonson: rev 4189f91d78e01d2a9524b44990093db4c435dc17) CHANGES tajo-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #579 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/579/)
        TAJO-1578: User configuration for pull server port is ignored. (jihoonson: rev 4189f91d78e01d2a9524b44990093db4c435dc17)

        • tajo-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java
        • CHANGES
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #579 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/579/ ) TAJO-1578 : User configuration for pull server port is ignored. (jihoonson: rev 4189f91d78e01d2a9524b44990093db4c435dc17) tajo-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java CHANGES
        Hide
        jihoonson Jihoon Son added a comment -

        Committed to master and 0.11.1

        Show
        jihoonson Jihoon Son added a comment - Committed to master and 0.11.1
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/820

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/820
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/820#issuecomment-152971466

        +1. This patch is straightforward.

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/820#issuecomment-152971466 +1. This patch is straightforward.
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user dkhwangbo opened a pull request:

        https://github.com/apache/tajo/pull/820

        TAJO-1578: User configuration for pull server port is ignored.

        When TajoPullServerService is initialized, it overwrites user-configured pull server port with the default value.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/dkhwangbo/tajo TAJO-1578

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/820.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #820


        commit 557441f6ec78078127290885a860d1cd7d1937d4
        Author: Dongkyu Hwangbo <hwangbodk@gmail.com>
        Date: 2015-10-13T02:22:20Z

        initial commit

        commit 904a83b4399823768fa80e2d495e85dcae7ee4d3
        Author: Dongkyu Hwangbo <hwangbodk@gmail.com>
        Date: 2015-10-13T02:24:41Z

        rollback unnecessarily changed


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user dkhwangbo opened a pull request: https://github.com/apache/tajo/pull/820 TAJO-1578 : User configuration for pull server port is ignored. When TajoPullServerService is initialized, it overwrites user-configured pull server port with the default value. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dkhwangbo/tajo TAJO-1578 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/820.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #820 commit 557441f6ec78078127290885a860d1cd7d1937d4 Author: Dongkyu Hwangbo <hwangbodk@gmail.com> Date: 2015-10-13T02:22:20Z initial commit commit 904a83b4399823768fa80e2d495e85dcae7ee4d3 Author: Dongkyu Hwangbo <hwangbodk@gmail.com> Date: 2015-10-13T02:24:41Z rollback unnecessarily changed

          People

          • Assignee:
            dkhwangbo Dongkyu Hwangbo
            Reporter:
            jihoonson Jihoon Son
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development