Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1575

HBASE_HOME guidance is duplicated in tajo-env.sh

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.10.0
    • Fix Version/s: 0.11.0
    • Component/s: conf and scripts
    • Labels:
      None

      Description

      There are two lines of HBASE_HOME explanation which are commented out.

      # HBase home. optional
      # export HBASE_HOME=

      # It must be required to use HBase
      # export HBASE_HOME=

      1. TAJO-1575.patch
        0.7 kB
        Jongyoung Park

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #684 (See https://builds.apache.org/job/Tajo-master-build/684/)
        TAJO-1575: HBASE_HOME guidance is duplicated in tajo-env.sh. (jihoonson: rev 4865a41141b6c79c35726369fd8422830ee73c2b)

        • tajo-dist/src/main/conf/tajo-env.sh
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #684 (See https://builds.apache.org/job/Tajo-master-build/684/ ) TAJO-1575 : HBASE_HOME guidance is duplicated in tajo-env.sh. (jihoonson: rev 4865a41141b6c79c35726369fd8422830ee73c2b) tajo-dist/src/main/conf/tajo-env.sh CHANGES
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #322 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/322/)
        TAJO-1575: HBASE_HOME guidance is duplicated in tajo-env.sh. (jihoonson: rev 4865a41141b6c79c35726369fd8422830ee73c2b)

        • CHANGES
        • tajo-dist/src/main/conf/tajo-env.sh
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #322 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/322/ ) TAJO-1575 : HBASE_HOME guidance is duplicated in tajo-env.sh. (jihoonson: rev 4865a41141b6c79c35726369fd8422830ee73c2b) CHANGES tajo-dist/src/main/conf/tajo-env.sh
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/549

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/549
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/549#issuecomment-95764832

        +1
        Thanks!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/549#issuecomment-95764832 +1 Thanks!
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12726773/TAJO-1575.patch
        against master revision release-0.9.0-rc0-270-g2a5d912.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-dist.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/754//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/754//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12726773/TAJO-1575.patch against master revision release-0.9.0-rc0-270-g2a5d912. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-dist. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/754//testReport/ Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/754//console This message is automatically generated.
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user eminency opened a pull request:

        https://github.com/apache/tajo/pull/549

        TAJO-1575: HBASE_HOME guidance is duplicated in tajo-env.sh

        Duplicated HBASE_HOME eliminated

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/eminency/tajo TAJO-1575

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/549.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #549


        commit 346192827e2a4b4a7c249ca2394b8aa7f21575a0
        Author: Jongyoung Park <eminency@gmail.com>
        Date: 2015-04-21T03:47:26Z

        Duplicated HBASE_HOME eliminated


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user eminency opened a pull request: https://github.com/apache/tajo/pull/549 TAJO-1575 : HBASE_HOME guidance is duplicated in tajo-env.sh Duplicated HBASE_HOME eliminated You can merge this pull request into a Git repository by running: $ git pull https://github.com/eminency/tajo TAJO-1575 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/549.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #549 commit 346192827e2a4b4a7c249ca2394b8aa7f21575a0 Author: Jongyoung Park <eminency@gmail.com> Date: 2015-04-21T03:47:26Z Duplicated HBASE_HOME eliminated

          People

          • Assignee:
            eminency Jongyoung Park
            Reporter:
            eminency Jongyoung Park
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development