[TAJO-1569] BlockingRpcClient can make other request fail

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.0, 0.10.0
• Fix Version/s: 0.11.0
• Component/s: Java Client, RPC
• Assignee: Jinho Kim
• Reporter: Jinho Kim
• Created: 18/Apr/15 05:11
• Updated: 18/Apr/15 08:37
• Resolved: 18/Apr/15 08:15

Description

A callback is set to fail but It rethrow exception and then other normal request is set to fail.

Tests run: 23, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 31.131 sec <<< FAILURE! - in org.apache.tajo.client.TestTajoClient
testSelectDatabaseToInvalidOne(org.apache.tajo.client.TestTajoClient)  Time elapsed: 0.034 sec  <<< ERROR!
com.google.protobuf.ServiceException: org.apache.tajo.rpc.TajoServiceException: org.apache.tajo.ipc.TajoMasterClientProtocol(127.0.0.1:33642): com.google.protobuf.ServiceException: org.apache.tajo.catalog.exception.NoSuchDatabaseException: ERROR: database "invaliddatabase" does not exist
	at org.apache.tajo.rpc.BlockingRpcClient$ProxyRpcChannel.callBlockingMethod(BlockingRpcClient.java:121)
	at org.apache.tajo.ipc.TajoMasterClientProtocol$TajoMasterClientProtocolService$BlockingStub.getAllDatabases(TajoMasterClientProtocol.java:2163)
	at org.apache.tajo.client.CatalogAdminClientImpl$4.call(CatalogAdminClientImpl.java:106)
	at org.apache.tajo.client.CatalogAdminClientImpl$4.call(CatalogAdminClientImpl.java:100)
	at org.apache.tajo.rpc.ServerCallable.withRetries(ServerCallable.java:86)
	at org.apache.tajo.client.CatalogAdminClientImpl.getAllDatabaseNames(CatalogAdminClientImpl.java:99)
	at org.apache.tajo.client.TajoClientImpl.getAllDatabaseNames(TajoClientImpl.java:194)
	at org.apache.tajo.client.TestTajoClient.testSelectDatabaseToInvalidOne(TestTajoClient.java:145)

Issue Links

• is required by: TAJO-1571 Merge TAJO-1497 and TAJO-1569 to 0.10.1
• relates to: TAJO-1563 Improve RPC error handling