Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1567

Update old license in some pom.xml files

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.10.0
    • Fix Version/s: 0.11.0, 0.10.1
    • Component/s: Documentation
    • Labels:
      None

      Description

      Some `pom.xml` files still have old license like the following. We just need to update.

      ```
      Copyright 2012 Database Lab., Korea Univ.
      ```

      1. TAJO-1567_0.10.1.patch
        10 kB
        Jinho Kim
      2. TAJO-1567.Hyun.150417.0.patch.txt
        6 kB
        Dongjoon Hyun
      3. TAJO-1567.Hyun.150418.0.patch.txt
        10 kB
        Dongjoon Hyun

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user dongjoon-hyun opened a pull request:

        https://github.com/apache/tajo/pull/539

        TAJO-1567: Update old license in some pom.xml files

        It would be better if `pom.xml` files also have the same license with the other source codes.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/dongjoon-hyun/tajo TAJO-1567

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/539.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #539


        commit 68535aa5b08751a92f1a67f149f15cd5fad7b68c
        Author: Dongjoon Hyun <dongjoon@apache.org>
        Date: 2015-04-17T13:24:49Z

        TAJO-1567: Update old license in some pom.xml files


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/tajo/pull/539 TAJO-1567 : Update old license in some pom.xml files It would be better if `pom.xml` files also have the same license with the other source codes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dongjoon-hyun/tajo TAJO-1567 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/539.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #539 commit 68535aa5b08751a92f1a67f149f15cd5fad7b68c Author: Dongjoon Hyun <dongjoon@apache.org> Date: 2015-04-17T13:24:49Z TAJO-1567 : Update old license in some pom.xml files
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12726155/TAJO-1567.Hyun.150417.0.patch.txt
        against master revision release-0.9.0-rc0-258-gd2a4f9b.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 6 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-algebra tajo-plan tajo-storage/tajo-storage-hbase tajo-storage/tajo-storage-hdfs.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/741//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/741//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage-hbase.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/741//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12726155/TAJO-1567.Hyun.150417.0.patch.txt against master revision release-0.9.0-rc0-258-gd2a4f9b. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 6 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-algebra tajo-plan tajo-storage/tajo-storage-hbase tajo-storage/tajo-storage-hdfs. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/741//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/741//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage-hbase.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/741//console This message is automatically generated.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/539#issuecomment-94144358

        Could you update other files in proto directory ?
        ```
        tajo-rpc/tajo-rpc-protobuf/src/main/proto
        ```

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/539#issuecomment-94144358 Could you update other files in proto directory ? ``` tajo-rpc/tajo-rpc-protobuf/src/main/proto ```
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user dongjoon-hyun commented on the pull request:

        https://github.com/apache/tajo/pull/539#issuecomment-94150640

        Oh, sure! Thank you, @jinossy

        Show
        githubbot ASF GitHub Bot added a comment - Github user dongjoon-hyun commented on the pull request: https://github.com/apache/tajo/pull/539#issuecomment-94150640 Oh, sure! Thank you, @jinossy
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user dongjoon-hyun commented on the pull request:

        https://github.com/apache/tajo/pull/539#issuecomment-94155825

        Hi, @jinossy . I finished updating according to your advice. Thank you!

        Show
        githubbot ASF GitHub Bot added a comment - Github user dongjoon-hyun commented on the pull request: https://github.com/apache/tajo/pull/539#issuecomment-94155825 Hi, @jinossy . I finished updating according to your advice. Thank you!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/539#issuecomment-94173676

        There still remains legacy licenses as follows. Would you mind updating together?
        ```
        $ find . -name "*.proto" -exec grep -H -n -i "korea" {} \;
        ./tajo-rpc/tajo-rpc-protobuf/src/main/proto/DummyProtos.proto:2: * Copyright 2012 Database Lab., Korea Univ.
        ./tajo-rpc/tajo-rpc-protobuf/src/main/proto/RpcProtos.proto:2: * Copyright 2012 Database Lab., Korea Univ.
        ./tajo-rpc/tajo-rpc-protobuf/src/main/proto/TestProtocol.proto:2: * Copyright 2012 Database Lab., Korea Univ.
        ./tajo-rpc/tajo-rpc-protobuf/src/main/proto/TestProtos.proto:2: * Copyright 2012 Database Lab., Korea Univ.
        ```

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/539#issuecomment-94173676 There still remains legacy licenses as follows. Would you mind updating together? ``` $ find . -name "*.proto" -exec grep -H -n -i "korea" {} \; ./tajo-rpc/tajo-rpc-protobuf/src/main/proto/DummyProtos.proto:2: * Copyright 2012 Database Lab., Korea Univ. ./tajo-rpc/tajo-rpc-protobuf/src/main/proto/RpcProtos.proto:2: * Copyright 2012 Database Lab., Korea Univ. ./tajo-rpc/tajo-rpc-protobuf/src/main/proto/TestProtocol.proto:2: * Copyright 2012 Database Lab., Korea Univ. ./tajo-rpc/tajo-rpc-protobuf/src/main/proto/TestProtos.proto:2: * Copyright 2012 Database Lab., Korea Univ. ```
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12726371/TAJO-1567.Hyun.150418.0.patch.txt
        against master revision release-0.9.0-rc0-262-g333b6f7.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 6 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-algebra tajo-plan tajo-rpc/tajo-rpc-protobuf tajo-storage/tajo-storage-hbase tajo-storage/tajo-storage-hdfs.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/744//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/744//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage-hbase.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/744//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12726371/TAJO-1567.Hyun.150418.0.patch.txt against master revision release-0.9.0-rc0-262-g333b6f7. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 6 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-algebra tajo-plan tajo-rpc/tajo-rpc-protobuf tajo-storage/tajo-storage-hbase tajo-storage/tajo-storage-hdfs. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/744//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/744//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage-hbase.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/744//console This message is automatically generated.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user dongjoon-hyun commented on the pull request:

        https://github.com/apache/tajo/pull/539#issuecomment-94243937

        Hi, @jihoonson . I think you are saying the same files mentioned by @jinossy .
        Those files are changed together in a second commit ( https://github.com/dongjoon-hyun/tajo/commit/41bee81a69da939e74fc45efaf708c4e59d67013 ) in this pull request. If you don't mind, could you check the second commit again?

        Show
        githubbot ASF GitHub Bot added a comment - Github user dongjoon-hyun commented on the pull request: https://github.com/apache/tajo/pull/539#issuecomment-94243937 Hi, @jihoonson . I think you are saying the same files mentioned by @jinossy . Those files are changed together in a second commit ( https://github.com/dongjoon-hyun/tajo/commit/41bee81a69da939e74fc45efaf708c4e59d67013 ) in this pull request. If you don't mind, could you check the second commit again?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/539#issuecomment-94251353

        @jihoonson @dongjoon-hyun
        I verified that it does not remain any more.
        Here is my +1

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/539#issuecomment-94251353 @jihoonson @dongjoon-hyun I verified that it does not remain any more. Here is my +1
        Hide
        jhkim Jinho Kim added a comment -

        I've upload the patch for branch-0.10.1

        Show
        jhkim Jinho Kim added a comment - I've upload the patch for branch-0.10.1
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12726426/TAJO-1567_0.10.1.patch
        against master revision release-0.9.0-rc0-262-g333b6f7.

        -1 patch. The patch command could not apply the patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/745//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12726426/TAJO-1567_0.10.1.patch against master revision release-0.9.0-rc0-262-g333b6f7. -1 patch. The patch command could not apply the patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/745//console This message is automatically generated.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/539

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/539
        Hide
        jhkim Jinho Kim added a comment -

        Committed it
        Thank you for your contribution.

        Show
        jhkim Jinho Kim added a comment - Committed it Thank you for your contribution.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #314 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/314/)
        TAJO-1567: Update old license in some pom.xml files. (jhkim: rev ad596bb1cf3948978a3233562638abdd34c969b7)

        • tajo-rpc/tajo-rpc-protobuf/src/main/proto/TestProtos.proto
        • tajo-storage/tajo-storage-hdfs/pom.xml
        • tajo-rpc/tajo-rpc-protobuf/src/main/proto/RpcProtos.proto
        • CHANGES
        • tajo-storage/pom.xml
        • tajo-storage/tajo-storage-hbase/pom.xml
        • tajo-rpc/tajo-rpc-protobuf/src/main/proto/DummyProtos.proto
        • tajo-algebra/pom.xml
        • tajo-rpc/tajo-rpc-protobuf/src/main/proto/TestProtocol.proto
        • tajo-plan/pom.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #314 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/314/ ) TAJO-1567 : Update old license in some pom.xml files. (jhkim: rev ad596bb1cf3948978a3233562638abdd34c969b7) tajo-rpc/tajo-rpc-protobuf/src/main/proto/TestProtos.proto tajo-storage/tajo-storage-hdfs/pom.xml tajo-rpc/tajo-rpc-protobuf/src/main/proto/RpcProtos.proto CHANGES tajo-storage/pom.xml tajo-storage/tajo-storage-hbase/pom.xml tajo-rpc/tajo-rpc-protobuf/src/main/proto/DummyProtos.proto tajo-algebra/pom.xml tajo-rpc/tajo-rpc-protobuf/src/main/proto/TestProtocol.proto tajo-plan/pom.xml
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #676 (See https://builds.apache.org/job/Tajo-master-build/676/)
        TAJO-1567: Update old license in some pom.xml files. (jhkim: rev ad596bb1cf3948978a3233562638abdd34c969b7)

        • tajo-rpc/tajo-rpc-protobuf/src/main/proto/TestProtos.proto
        • tajo-rpc/tajo-rpc-protobuf/src/main/proto/RpcProtos.proto
        • CHANGES
        • tajo-rpc/tajo-rpc-protobuf/src/main/proto/DummyProtos.proto
        • tajo-storage/tajo-storage-hdfs/pom.xml
        • tajo-algebra/pom.xml
        • tajo-plan/pom.xml
        • tajo-storage/pom.xml
        • tajo-storage/tajo-storage-hbase/pom.xml
        • tajo-rpc/tajo-rpc-protobuf/src/main/proto/TestProtocol.proto
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #676 (See https://builds.apache.org/job/Tajo-master-build/676/ ) TAJO-1567 : Update old license in some pom.xml files. (jhkim: rev ad596bb1cf3948978a3233562638abdd34c969b7) tajo-rpc/tajo-rpc-protobuf/src/main/proto/TestProtos.proto tajo-rpc/tajo-rpc-protobuf/src/main/proto/RpcProtos.proto CHANGES tajo-rpc/tajo-rpc-protobuf/src/main/proto/DummyProtos.proto tajo-storage/tajo-storage-hdfs/pom.xml tajo-algebra/pom.xml tajo-plan/pom.xml tajo-storage/pom.xml tajo-storage/tajo-storage-hbase/pom.xml tajo-rpc/tajo-rpc-protobuf/src/main/proto/TestProtocol.proto
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user dongjoon-hyun commented on the pull request:

        https://github.com/apache/tajo/pull/539#issuecomment-94275017

        Thank you for fast reviewing, @jinossy !

        Show
        githubbot ASF GitHub Bot added a comment - Github user dongjoon-hyun commented on the pull request: https://github.com/apache/tajo/pull/539#issuecomment-94275017 Thank you for fast reviewing, @jinossy !

          People

          • Assignee:
            dongjoon Dongjoon Hyun
            Reporter:
            dongjoon Dongjoon Hyun
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development