Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1559

Fix data model description (tinyint, smallint)

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.10.0
    • Fix Version/s: 0.11.0, 0.10.1
    • Component/s: Documentation
    • Labels:
      None

      Description

      Tajo supports tinyint (=int1), but there exists documentation error.

      • add tinyint description (splitted from smallint)
      • fix a typo in the maximum range of smallint

      http://mail-archives.apache.org/mod_mbox/tajo-dev/201504.mbox/%3CCAFu6yH2fkT5335Ys%2BvPvkuHJWG8tF4EWng7EyjovdVZm34rAmA%40mail.gmail.com%3E

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user dongjoon-hyun opened a pull request:

        https://github.com/apache/tajo/pull/536

        TAJO-1559: Fix data model description (tinyint, smallint)

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/dongjoon-hyun/tajo TAJO-1559

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/536.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #536


        commit c717902eee8ce1605a55ab2091e9edd0734c8d90
        Author: Dongjoon Hyun <dongjoon@apache.org>
        Date: 2015-04-16T23:22:37Z

        TAJO-1559: Fix data model description (tinyint, smallint)


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/tajo/pull/536 TAJO-1559 : Fix data model description (tinyint, smallint) You can merge this pull request into a Git repository by running: $ git pull https://github.com/dongjoon-hyun/tajo TAJO-1559 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/536.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #536 commit c717902eee8ce1605a55ab2091e9edd0734c8d90 Author: Dongjoon Hyun <dongjoon@apache.org> Date: 2015-04-16T23:22:37Z TAJO-1559 : Fix data model description (tinyint, smallint)
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12726013/TAJO-1559.Hyun.150417.0.patch.txt
        against master revision release-0.9.0-rc0-256-g7b78668.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/737//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/737//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12726013/TAJO-1559.Hyun.150417.0.patch.txt against master revision release-0.9.0-rc0-256-g7b78668. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/737//testReport/ Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/737//console This message is automatically generated.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user dongjoon-hyun commented on the pull request:

        https://github.com/apache/tajo/pull/536#issuecomment-94497142

        Although it's documentation patch, I rebased in order to trigger Travis CI build. (It failed before)

        Show
        githubbot ASF GitHub Bot added a comment - Github user dongjoon-hyun commented on the pull request: https://github.com/apache/tajo/pull/536#issuecomment-94497142 Although it's documentation patch, I rebased in order to trigger Travis CI build. (It failed before)
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/536#issuecomment-95764920

        +1 thanks!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/536#issuecomment-95764920 +1 thanks!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/536

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/536
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #323 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/323/)
        TAJO-1559: Fix data model description (tinyint, smallint). (jihoonson: rev 14340729b5039e20f170160ffe58b3c96a865c26)

        • tajo-docs/src/main/sphinx/sql_language/data_model.rst
        • CHANGES
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #323 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/323/ ) TAJO-1559 : Fix data model description (tinyint, smallint). (jihoonson: rev 14340729b5039e20f170160ffe58b3c96a865c26) tajo-docs/src/main/sphinx/sql_language/data_model.rst CHANGES
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #685 (See https://builds.apache.org/job/Tajo-master-build/685/)
        TAJO-1559: Fix data model description (tinyint, smallint). (jihoonson: rev 14340729b5039e20f170160ffe58b3c96a865c26)

        • tajo-docs/src/main/sphinx/sql_language/data_model.rst
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #685 (See https://builds.apache.org/job/Tajo-master-build/685/ ) TAJO-1559 : Fix data model description (tinyint, smallint). (jihoonson: rev 14340729b5039e20f170160ffe58b3c96a865c26) tajo-docs/src/main/sphinx/sql_language/data_model.rst CHANGES
        Hide
        jihoonson Jihoon Son added a comment -

        Committed to branch 0.10.1 and master.

        Show
        jihoonson Jihoon Son added a comment - Committed to branch 0.10.1 and master.

          People

          • Assignee:
            dongjoon Dongjoon Hyun
            Reporter:
            dongjoon Dongjoon Hyun
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development