Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1548

Refactoring condition code for CHAR into CatalogUtil

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: None
    • Labels:
      None

      Description

      Currently Schema's addColumn is this

      ```java
      public synchronized Schema addColumn(String name, Type type) {
      if (type == Type.CHAR)

      { return addColumn(name, CatalogUtil.newDataTypeWithLen(type, 1)); }

      return addColumn(name, CatalogUtil.newSimpleDataType(type));
      }
      ```

      I think it is better condition code into CatalogUtil.newSimpleDataType.
      because some testcode make columns just using CatalogUtil.

        Attachments

          Activity

            People

            • Assignee:
              charsyam DaeMyung Kang
              Reporter:
              charsyam DaeMyung Kang
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: