Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: Physical Operator
    • Labels:
      None

      Description

      It's not in condition to make some improvements. No offense.

      1. TAJO-1542.patch
        110 kB
        Hyunsik Choi

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-build #707 (See https://builds.apache.org/job/Tajo-master-build/707/)
          TAJO-1542 Refactoring of HashJoinExecs. (contributed by navis, committed by hyunsik) (hyunsik: rev 36a703c5dc2c2257dfd52232f204507fb4b79024)

          • CHANGES
          • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestLeftOuterNLJoinExec.java
          • tajo-common/src/main/java/org/apache/tajo/storage/EmptyTuple.java
          • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestLeftOuterHashJoinExec.java
          • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestHashSemiJoinExec.java
          • tajo-common/src/main/java/org/apache/tajo/storage/VTuple.java
          • tajo-core/src/main/java/org/apache/tajo/engine/utils/CacheHolder.java
          • tajo-core/src/test/resources/results/TestJoinQuery/testJoinFilterOfRowPreservedTable1.result
          • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/FrameTuple.java
          • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/CommonHashJoinExec.java
          • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/CommonJoinExec.java
          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/PatternMatchPredicateEval.java
          • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashJoinExec.java
          • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashLeftSemiJoinExec.java
          • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/BasicPhysicalExecutorVisitor.java
          • tajo-common/src/main/java/org/apache/tajo/storage/NullTuple.java
          • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/NLLeftOuterJoinExec.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/AggregationFunctionCallEval.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/WindowFunctionEval.java
          • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/PhysicalExecutorVisitor.java
          • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashLeftAntiJoinExec.java
          • tajo-core/src/test/resources/queries/TestJoinQuery/testJoinFilterOfRowPreservedTable1.sql
          • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/RightOuterMergeJoinExec.java
          • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashLeftOuterJoinExec.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/InEval.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/AlgebraicUtil.java
          • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashFullOuterJoinExec.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/EvalNode.java
          • tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #707 (See https://builds.apache.org/job/Tajo-master-build/707/ ) TAJO-1542 Refactoring of HashJoinExecs. (contributed by navis, committed by hyunsik) (hyunsik: rev 36a703c5dc2c2257dfd52232f204507fb4b79024) CHANGES tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestLeftOuterNLJoinExec.java tajo-common/src/main/java/org/apache/tajo/storage/EmptyTuple.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestLeftOuterHashJoinExec.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestHashSemiJoinExec.java tajo-common/src/main/java/org/apache/tajo/storage/VTuple.java tajo-core/src/main/java/org/apache/tajo/engine/utils/CacheHolder.java tajo-core/src/test/resources/results/TestJoinQuery/testJoinFilterOfRowPreservedTable1.result tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/FrameTuple.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/CommonHashJoinExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/CommonJoinExec.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/PatternMatchPredicateEval.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashJoinExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashLeftSemiJoinExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/BasicPhysicalExecutorVisitor.java tajo-common/src/main/java/org/apache/tajo/storage/NullTuple.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/NLLeftOuterJoinExec.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/AggregationFunctionCallEval.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/WindowFunctionEval.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/PhysicalExecutorVisitor.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashLeftAntiJoinExec.java tajo-core/src/test/resources/queries/TestJoinQuery/testJoinFilterOfRowPreservedTable1.sql tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/RightOuterMergeJoinExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashLeftOuterJoinExec.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/InEval.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/AlgebraicUtil.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashFullOuterJoinExec.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/EvalNode.java tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java
          Hide
          hudson Hudson added a comment -

          ABORTED: Integrated in Tajo-master-CODEGEN-build #347 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/347/)
          TAJO-1542 Refactoring of HashJoinExecs. (contributed by navis, committed by hyunsik) (hyunsik: rev 36a703c5dc2c2257dfd52232f204507fb4b79024)

          • tajo-common/src/main/java/org/apache/tajo/storage/EmptyTuple.java
          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java
          • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestLeftOuterNLJoinExec.java
          • tajo-core/src/test/resources/results/TestJoinQuery/testJoinFilterOfRowPreservedTable1.result
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/InEval.java
          • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestLeftOuterHashJoinExec.java
          • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/RightOuterMergeJoinExec.java
          • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestHashSemiJoinExec.java
          • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/PhysicalExecutorVisitor.java
          • tajo-core/src/main/java/org/apache/tajo/engine/utils/CacheHolder.java
          • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashFullOuterJoinExec.java
          • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashLeftOuterJoinExec.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/AlgebraicUtil.java
          • tajo-core/src/test/resources/queries/TestJoinQuery/testJoinFilterOfRowPreservedTable1.sql
          • CHANGES
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/PatternMatchPredicateEval.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/AggregationFunctionCallEval.java
          • tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java
          • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashLeftAntiJoinExec.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/WindowFunctionEval.java
          • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/CommonHashJoinExec.java
          • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/FrameTuple.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/EvalNode.java
          • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashJoinExec.java
          • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/CommonJoinExec.java
          • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/BasicPhysicalExecutorVisitor.java
          • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/NLLeftOuterJoinExec.java
          • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashLeftSemiJoinExec.java
          • tajo-common/src/main/java/org/apache/tajo/storage/VTuple.java
          • tajo-common/src/main/java/org/apache/tajo/storage/NullTuple.java
          Show
          hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-CODEGEN-build #347 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/347/ ) TAJO-1542 Refactoring of HashJoinExecs. (contributed by navis, committed by hyunsik) (hyunsik: rev 36a703c5dc2c2257dfd52232f204507fb4b79024) tajo-common/src/main/java/org/apache/tajo/storage/EmptyTuple.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestLeftOuterNLJoinExec.java tajo-core/src/test/resources/results/TestJoinQuery/testJoinFilterOfRowPreservedTable1.result tajo-plan/src/main/java/org/apache/tajo/plan/expr/InEval.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestLeftOuterHashJoinExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/RightOuterMergeJoinExec.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestHashSemiJoinExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/PhysicalExecutorVisitor.java tajo-core/src/main/java/org/apache/tajo/engine/utils/CacheHolder.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashFullOuterJoinExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashLeftOuterJoinExec.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/AlgebraicUtil.java tajo-core/src/test/resources/queries/TestJoinQuery/testJoinFilterOfRowPreservedTable1.sql CHANGES tajo-plan/src/main/java/org/apache/tajo/plan/expr/PatternMatchPredicateEval.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/AggregationFunctionCallEval.java tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashLeftAntiJoinExec.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/WindowFunctionEval.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/CommonHashJoinExec.java tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/FrameTuple.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/EvalNode.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashJoinExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/CommonJoinExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/BasicPhysicalExecutorVisitor.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/NLLeftOuterJoinExec.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashLeftSemiJoinExec.java tajo-common/src/main/java/org/apache/tajo/storage/VTuple.java tajo-common/src/main/java/org/apache/tajo/storage/NullTuple.java
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik closed the pull request at:

          https://github.com/apache/tajo/pull/567

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik closed the pull request at: https://github.com/apache/tajo/pull/567
          Hide
          hyunsik Hyunsik Choi added a comment -

          committed.

          Show
          hyunsik Hyunsik Choi added a comment - committed.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tajo/pull/529

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/529
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on the pull request:

          https://github.com/apache/tajo/pull/567#issuecomment-102022798

          +1. This patch looks good to me.
          I left only one trivial comment.
          Thanks for your work.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/567#issuecomment-102022798 +1. This patch looks good to me. I left only one trivial comment. Thanks for your work.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on the pull request:

          https://github.com/apache/tajo/pull/567#issuecomment-101994021

          <sup>**[tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java, line 496 \[r2\]](https://reviewable.io:443/reviews/apache/tajo/567#-JpGtvvX0rsY9XvdaCKx)** ([raw file](https://github.com/apache/tajo/blob/0554f9f8a10f9720e5c6e5da26183b7d37d34cf3/tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java#L496)):</sup>
          This line looks hard-coded.
          Would you explain your intention?

          Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/apache/tajo/567)
          <!-- Sent from Reviewable.io -->

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/567#issuecomment-101994021 <sup>** [tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java, line 496 \[r2\]] ( https://reviewable.io:443/reviews/apache/tajo/567#-JpGtvvX0rsY9XvdaCKx)** ( [raw file] ( https://github.com/apache/tajo/blob/0554f9f8a10f9720e5c6e5da26183b7d37d34cf3/tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java#L496)): </sup> This line looks hard-coded. Would you explain your intention? — Comments from the [review on Reviewable.io] ( https://reviewable.io:443/reviews/apache/tajo/567 ) <!-- Sent from Reviewable.io -->
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on the pull request:

          https://github.com/apache/tajo/pull/567#issuecomment-101992334

          <sup>**[tajo-common/src/main/java/org/apache/tajo/storage/NullTuple.java, line 28 \[r2\]](https://reviewable.io:443/reviews/apache/tajo/567#-JpGTPiOHTlpLVMLBGBA)** ([raw file](https://github.com/apache/tajo/blob/0554f9f8a10f9720e5c6e5da26183b7d37d34cf3/tajo-common/src/main/java/org/apache/tajo/storage/NullTuple.java#L28)):</sup>
          Very nice.

          Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/apache/tajo/567)
          <!-- Sent from Reviewable.io -->

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/567#issuecomment-101992334 <sup>** [tajo-common/src/main/java/org/apache/tajo/storage/NullTuple.java, line 28 \[r2\]] ( https://reviewable.io:443/reviews/apache/tajo/567#-JpGTPiOHTlpLVMLBGBA)** ( [raw file] ( https://github.com/apache/tajo/blob/0554f9f8a10f9720e5c6e5da26183b7d37d34cf3/tajo-common/src/main/java/org/apache/tajo/storage/NullTuple.java#L28)): </sup> Very nice. — Comments from the [review on Reviewable.io] ( https://reviewable.io:443/reviews/apache/tajo/567 ) <!-- Sent from Reviewable.io -->
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on the pull request:

          https://github.com/apache/tajo/pull/567#issuecomment-101960838

          @hyunsik sorry for late response. I'm reviewing your patch, and will finish asap.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/567#issuecomment-101960838 @hyunsik sorry for late response. I'm reviewing your patch, and will finish asap.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik commented on the pull request:

          https://github.com/apache/tajo/pull/567#issuecomment-101565010

          @jihoonson You recently refactored some join algorithms. So, I think that it would be great if you review this patch too.

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/567#issuecomment-101565010 @jihoonson You recently refactored some join algorithms. So, I think that it would be great if you review this patch too.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik commented on the pull request:

          https://github.com/apache/tajo/pull/529#issuecomment-101564504

          Actually, our join algorithms are very old ones. We should have refactored and optimized them, but we haven't. I appreciate your work. I like this change. I'm not sure if you can do further work for this patch. So, I just created another pull request with some modifications, more comments and removal of unused methods.

          https://github.com/apache/tajo/pull/567

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/529#issuecomment-101564504 Actually, our join algorithms are very old ones. We should have refactored and optimized them, but we haven't. I appreciate your work. I like this change. I'm not sure if you can do further work for this patch. So, I just created another pull request with some modifications, more comments and removal of unused methods. https://github.com/apache/tajo/pull/567
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user hyunsik opened a pull request:

          https://github.com/apache/tajo/pull/567

          TAJO-1542 Refactoring of HashJoinExecs.

          See this pull request.
          https://github.com/apache/tajo/pull/529

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/hyunsik/tajo TAJO-1542

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tajo/pull/567.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #567


          commit 14bd04e0e8b83b68d5fbba1f9a41eb2ca70ef1e1
          Author: Hyunsik Choi <hyunsik@apache.org>
          Date: 2015-05-13T07:54:35Z

          TAJO-1542 Refactoring of HashJoinExecs.

          • Navis's patch + some comments

          Show
          githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/567 TAJO-1542 Refactoring of HashJoinExecs. See this pull request. https://github.com/apache/tajo/pull/529 You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1542 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/567.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #567 commit 14bd04e0e8b83b68d5fbba1f9a41eb2ca70ef1e1 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2015-05-13T07:54:35Z TAJO-1542 Refactoring of HashJoinExecs. Navis's patch + some comments
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik commented on a diff in the pull request:

          https://github.com/apache/tajo/pull/529#discussion_r30209355

          — Diff: tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java —
          @@ -464,14 +464,14 @@ private PhysicalExec createLeftOuterJoinPlan(TaskAttemptContext context, JoinNod
          case IN_MEMORY_HASH_JOIN:
          LOG.info("Left Outer Join (" + plan.getPID() +") chooses [Hash Join].");
          return new HashLeftOuterJoinExec(context, plan, leftExec, rightExec);

          • case NESTED_LOOP_JOIN:
          • //the right operand is too large, so we opt for NL implementation of left outer join
          • LOG.info("Left Outer Join (" + plan.getPID() +") chooses [Nested Loop Join].");
          • return new NLLeftOuterJoinExec(context, plan, leftExec, rightExec);
            + case MERGE_JOIN:
              • End diff –

          Good job. It should have removed earlier.

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on a diff in the pull request: https://github.com/apache/tajo/pull/529#discussion_r30209355 — Diff: tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java — @@ -464,14 +464,14 @@ private PhysicalExec createLeftOuterJoinPlan(TaskAttemptContext context, JoinNod case IN_MEMORY_HASH_JOIN: LOG.info("Left Outer Join (" + plan.getPID() +") chooses [Hash Join] ."); return new HashLeftOuterJoinExec(context, plan, leftExec, rightExec); case NESTED_LOOP_JOIN: //the right operand is too large, so we opt for NL implementation of left outer join LOG.info("Left Outer Join (" + plan.getPID() +") chooses [Nested Loop Join] ."); return new NLLeftOuterJoinExec(context, plan, leftExec, rightExec); + case MERGE_JOIN: End diff – Good job. It should have removed earlier.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik commented on a diff in the pull request:

          https://github.com/apache/tajo/pull/529#discussion_r30209272

          — Diff: tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java —
          @@ -383,6 +392,17 @@ public SchemaProto getProto()

          { return builder.build(); }

          + public Set<String> getAliases() {
          — End diff –

          Is it only for debugging? It's not bad.

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on a diff in the pull request: https://github.com/apache/tajo/pull/529#discussion_r30209272 — Diff: tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java — @@ -383,6 +392,17 @@ public SchemaProto getProto() { return builder.build(); } + public Set<String> getAliases() { — End diff – Is it only for debugging? It's not bad.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik commented on the pull request:

          https://github.com/apache/tajo/pull/529#issuecomment-101556621

          I add some trivial comments, and removed PhysicalPlanner::newIterator, which is never used in this patch. For review, I'll make another pull request.

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/529#issuecomment-101556621 I add some trivial comments, and removed PhysicalPlanner::newIterator, which is never used in this patch. For review, I'll make another pull request.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik commented on the pull request:

          https://github.com/apache/tajo/pull/529#issuecomment-101505815

          Excellent work! This patch simplifies all hash-based join algorithms. I think that this patch seems to be ready to be committed.

          BTW, it would be better if we add more comments. BTW, you may have some time slots to do this work as far as I know. So, I'm going to add comments. If you have any opinion, feel free to suggest anything.

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/529#issuecomment-101505815 Excellent work! This patch simplifies all hash-based join algorithms. I think that this patch seems to be ready to be committed. BTW, it would be better if we add more comments. BTW, you may have some time slots to do this work as far as I know. So, I'm going to add comments. If you have any opinion, feel free to suggest anything.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hyunsik commented on the pull request:

          https://github.com/apache/tajo/pull/529#issuecomment-101067804

          Hi @navis,

          The patch looks good to me. Even though this patch is conflict with the latest master branch, the conflict is trivial. So, I could merge it without further work. I'm reviewing this patch, and I'll give comments soon.

          Show
          githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/529#issuecomment-101067804 Hi @navis, The patch looks good to me. Even though this patch is conflict with the latest master branch, the conflict is trivial. So, I could merge it without further work. I'm reviewing this patch, and I'll give comments soon.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user navis opened a pull request:

          https://github.com/apache/tajo/pull/529

          TAJO-1542 Refactoring of HashJoinExecs

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/navis/tajo TAJO-1542

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tajo/pull/529.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #529


          commit 3335147a8385262cced1b5971763491016a7326f
          Author: navis.ryu <navis@apache.org>
          Date: 2015-04-09T07:58:01Z

          TAJO-1542 Refactoring of HashJoinExecs


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user navis opened a pull request: https://github.com/apache/tajo/pull/529 TAJO-1542 Refactoring of HashJoinExecs You can merge this pull request into a Git repository by running: $ git pull https://github.com/navis/tajo TAJO-1542 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/529.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #529 commit 3335147a8385262cced1b5971763491016a7326f Author: navis.ryu <navis@apache.org> Date: 2015-04-09T07:58:01Z TAJO-1542 Refactoring of HashJoinExecs

            People

            • Assignee:
              navis Navis
              Reporter:
              navis Navis
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development