Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1541

Connection timeout in netty client is not working

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.11.0
    • Fix Version/s: 0.11.0
    • Component/s: RPC
    • Labels:
      None

      Description

      in RpcUtils.Timer#elapsed(), this part

      remaining -= (prev - current);
      

      should be inverted like this,

      remaining -= current - prev;
      

      my bad. just kill me

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user navis opened a pull request:

        https://github.com/apache/tajo/pull/528

        TAJO-1541 Connection timeout in netty client is not working

        It does not abandon retrying connection to master. I like that but it's a bug.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/navis/tajo TAJO-1541

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/528.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #528


        commit c25cbea92d6a5e63a8834d8cb2231b87208252ae
        Author: navis.ryu <navis@apache.org>
        Date: 2015-04-08T07:07:14Z

        TAJO-1541 Connection timeout in netty client is not working


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user navis opened a pull request: https://github.com/apache/tajo/pull/528 TAJO-1541 Connection timeout in netty client is not working It does not abandon retrying connection to master. I like that but it's a bug. You can merge this pull request into a Git repository by running: $ git pull https://github.com/navis/tajo TAJO-1541 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/528.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #528 commit c25cbea92d6a5e63a8834d8cb2231b87208252ae Author: navis.ryu <navis@apache.org> Date: 2015-04-08T07:07:14Z TAJO-1541 Connection timeout in netty client is not working
        Hide
        navis Navis added a comment -

        Is there anyone to review this? Without this, your tsql client will be hang on reconnection after master shutdown.

        Show
        navis Navis added a comment - Is there anyone to review this? Without this, your tsql client will be hang on reconnection after master shutdown.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user ykrips commented on the pull request:

        https://github.com/apache/tajo/pull/528#issuecomment-92162398

        +1
        Though Travis CI build system has an issue when running testcases, but this build issue is far from this patch. Local build on my laptop has passed testcases, and it runs with JDK 6.0.

        Show
        githubbot ASF GitHub Bot added a comment - Github user ykrips commented on the pull request: https://github.com/apache/tajo/pull/528#issuecomment-92162398 +1 Though Travis CI build system has an issue when running testcases, but this build issue is far from this patch. Local build on my laptop has passed testcases, and it runs with JDK 6.0.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/528

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/528
        Hide
        ykrips Jihun Kang added a comment -

        committed.

        Show
        ykrips Jihun Kang added a comment - committed.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #302 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/302/)
        TAJO-1541: Connection timeout in netty client is not working (jihun: rev daf55ea45572494d996dad7cb3e207fbc9489102)

        • CHANGES
        • tajo-rpc/tajo-rpc-common/src/main/java/org/apache/tajo/rpc/RpcUtils.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #302 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/302/ ) TAJO-1541 : Connection timeout in netty client is not working (jihun: rev daf55ea45572494d996dad7cb3e207fbc9489102) CHANGES tajo-rpc/tajo-rpc-common/src/main/java/org/apache/tajo/rpc/RpcUtils.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #664 (See https://builds.apache.org/job/Tajo-master-build/664/)
        TAJO-1541: Connection timeout in netty client is not working (jihun: rev daf55ea45572494d996dad7cb3e207fbc9489102)

        • CHANGES
        • tajo-rpc/tajo-rpc-common/src/main/java/org/apache/tajo/rpc/RpcUtils.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #664 (See https://builds.apache.org/job/Tajo-master-build/664/ ) TAJO-1541 : Connection timeout in netty client is not working (jihun: rev daf55ea45572494d996dad7cb3e207fbc9489102) CHANGES tajo-rpc/tajo-rpc-common/src/main/java/org/apache/tajo/rpc/RpcUtils.java

          People

          • Assignee:
            navis Navis
            Reporter:
            navis Navis
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development