Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1523

ClassSize should consider compressed oops

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: None
    • Labels:
      None

      Description

      For JVMs under 32G memory, compressed oops can be enabled, halving size of java references. This should be considered not to over-estimate size of object.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user navis opened a pull request:

        https://github.com/apache/tajo/pull/508

        TAJO-1523 ClassSize should consider compressed oops

        afaik, java object is 4xreference (which is 2 in ClassSize). There should be some debate on this.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/navis/tajo TAJO-1523

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/508.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #508


        commit 14451969b616f7904daa549fd6963074753034ed
        Author: navis.ryu <navis@apache.org>
        Date: 2015-04-04T07:56:05Z

        TAJO-1523 ClassSize should consider compressed oops


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user navis opened a pull request: https://github.com/apache/tajo/pull/508 TAJO-1523 ClassSize should consider compressed oops afaik, java object is 4xreference (which is 2 in ClassSize). There should be some debate on this. You can merge this pull request into a Git repository by running: $ git pull https://github.com/navis/tajo TAJO-1523 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/508.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #508 commit 14451969b616f7904daa549fd6963074753034ed Author: navis.ryu <navis@apache.org> Date: 2015-04-04T07:56:05Z TAJO-1523 ClassSize should consider compressed oops
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/508#issuecomment-100038314

        +1
        This change is reasonable and looks good to me.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/508#issuecomment-100038314 +1 This change is reasonable and looks good to me.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/508

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/508
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed this patch to master branch. Thank you!

        Show
        hyunsik Hyunsik Choi added a comment - committed this patch to master branch. Thank you!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #335 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/335/)
        TAJO-1523 ClassSize should consider compressed oops (hyunsik: rev 2b4c1610d2e60dfc9c50fbfdac22e12870c17163)

        • tajo-common/src/main/java/org/apache/tajo/util/ClassSize.java
        • tajo-common/src/main/java/org/apache/tajo/util/UnsafeUtil.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #335 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/335/ ) TAJO-1523 ClassSize should consider compressed oops (hyunsik: rev 2b4c1610d2e60dfc9c50fbfdac22e12870c17163) tajo-common/src/main/java/org/apache/tajo/util/ClassSize.java tajo-common/src/main/java/org/apache/tajo/util/UnsafeUtil.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #695 (See https://builds.apache.org/job/Tajo-master-build/695/)
        TAJO-1523 ClassSize should consider compressed oops (hyunsik: rev 2b4c1610d2e60dfc9c50fbfdac22e12870c17163)

        • tajo-common/src/main/java/org/apache/tajo/util/ClassSize.java
        • tajo-common/src/main/java/org/apache/tajo/util/UnsafeUtil.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #695 (See https://builds.apache.org/job/Tajo-master-build/695/ ) TAJO-1523 ClassSize should consider compressed oops (hyunsik: rev 2b4c1610d2e60dfc9c50fbfdac22e12870c17163) tajo-common/src/main/java/org/apache/tajo/util/ClassSize.java tajo-common/src/main/java/org/apache/tajo/util/UnsafeUtil.java

          People

          • Assignee:
            navis Navis
            Reporter:
            navis Navis
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development