Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1501

Too many log message of HashShuffleAppenderManager.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.10.0
    • Fix Version/s: 0.11.0, 0.10.1
    • Component/s: None
    • Labels:
      None

      Description

      HashShuffleAppenderManager generates too many log message if there is large number of partitions.
      This message should be changed to DEBUG level.

      1. TAJO-1501.patch
        0.9 kB
        Jongyoung Park

        Activity

        Hide
        hjkim Hyoungjun Kim added a comment -

        Here is the sample message.

        2015-04-01 15:27:01,777 INFO org.apache.tajo.storage.HashShuffleAppenderManager: Create Hash shuffle file(partId=0): file:/data6/tmp/tajo-localdir/q_1427869790388_0001/output/6/hash-shuffle/0/0
        
        Show
        hjkim Hyoungjun Kim added a comment - Here is the sample message. 2015-04-01 15:27:01,777 INFO org.apache.tajo.storage.HashShuffleAppenderManager: Create Hash shuffle file(partId=0): file:/data6/tmp/tajo-localdir/q_1427869790388_0001/output/6/hash-shuffle/0/0
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user eminency opened a pull request:

        https://github.com/apache/tajo/pull/498

        TAJO-1501: Too many log message of HashShuffleAppenderManager

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/eminency/tajo TAJO-1501

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/498.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #498


        commit 066a0894f1caf156f771dfa8f05277b551020cab
        Author: Jongyoung Park <eminency@gmail.com>
        Date: 2015-04-02T09:32:13Z

        The log message level is decreased as DEBUG


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user eminency opened a pull request: https://github.com/apache/tajo/pull/498 TAJO-1501 : Too many log message of HashShuffleAppenderManager You can merge this pull request into a Git repository by running: $ git pull https://github.com/eminency/tajo TAJO-1501 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/498.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #498 commit 066a0894f1caf156f771dfa8f05277b551020cab Author: Jongyoung Park <eminency@gmail.com> Date: 2015-04-02T09:32:13Z The log message level is decreased as DEBUG
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12708956/TAJO-1501.patch
        against master revision release-0.9.0-rc0-233-gbda2d62.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 2 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-storage/tajo-storage-hdfs.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/691//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/691//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage-hdfs.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/691//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12708956/TAJO-1501.patch against master revision release-0.9.0-rc0-233-gbda2d62. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-storage/tajo-storage-hdfs. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/691//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/691//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage-hdfs.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/691//console This message is automatically generated.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/498#issuecomment-89117803

        +1

        Thanks for your contribution.
        I'll commit this soon.

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/498#issuecomment-89117803 +1 Thanks for your contribution. I'll commit this soon.
        Hide
        blrunner Jaehwa Jung added a comment -

        I've just committed this to the master branch and the 0.10.1 branch.

        Show
        blrunner Jaehwa Jung added a comment - I've just committed this to the master branch and the 0.10.1 branch.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user eminency closed the pull request at:

        https://github.com/apache/tajo/pull/498

        Show
        githubbot ASF GitHub Bot added a comment - Github user eminency closed the pull request at: https://github.com/apache/tajo/pull/498
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #287 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/287/)
        TAJO-1501: Too many log message of HashShuffleAppenderManager. (blrunner: rev 70d5fdf86b14ea4242b3c98f8da826f80b4f4f40)

        • CHANGES
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/HashShuffleAppenderManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #287 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/287/ ) TAJO-1501 : Too many log message of HashShuffleAppenderManager. (blrunner: rev 70d5fdf86b14ea4242b3c98f8da826f80b4f4f40) CHANGES tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/HashShuffleAppenderManager.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #649 (See https://builds.apache.org/job/Tajo-master-build/649/)
        TAJO-1501: Too many log message of HashShuffleAppenderManager. (blrunner: rev 70d5fdf86b14ea4242b3c98f8da826f80b4f4f40)

        • CHANGES
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/HashShuffleAppenderManager.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #649 (See https://builds.apache.org/job/Tajo-master-build/649/ ) TAJO-1501 : Too many log message of HashShuffleAppenderManager. (blrunner: rev 70d5fdf86b14ea4242b3c98f8da826f80b4f4f40) CHANGES tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/HashShuffleAppenderManager.java

          People

          • Assignee:
            eminency Jongyoung Park
            Reporter:
            hjkim Hyoungjun Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development