Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1499

Check the bind status when EvalNode::eval() is called

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: Expression
    • Labels:
      None

      Description

      The bind() function must be called before eval(). So, we should add a routine to check the binding state.
      Please refer to the discussion at https://github.com/apache/tajo/pull/456.

      1. TAJO-1499_2.patch
        29 kB
        Jihoon Son
      2. TAJO-1499_3.patch
        32 kB
        Jihoon Son
      3. TAJO-1499.patch
        25 kB
        Jihoon Son

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user blrunner commented on the pull request:

          https://github.com/apache/tajo/pull/500#issuecomment-89735832

          Thanks for your contribution.

          I would like it more valuable if you add more unit test case for verifying the message for IllegalStateException. And could you trigger this for Travis CI build or could you add the patch to JIRA?

          Show
          githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/500#issuecomment-89735832 Thanks for your contribution. I would like it more valuable if you add more unit test case for verifying the message for IllegalStateException. And could you trigger this for Travis CI build or could you add the patch to JIRA?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on the pull request:

          https://github.com/apache/tajo/pull/500#issuecomment-89813209

          Thanks. I added an unit test.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/500#issuecomment-89813209 Thanks. I added an unit test.
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12709478/TAJO-1499_2.patch
          against master revision release-0.9.0-rc0-239-g696d2aa.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          -1 findbugs. The patch appears to introduce 2 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in tajo-core tajo-plan.

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/708//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/708//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/708//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12709478/TAJO-1499_2.patch against master revision release-0.9.0-rc0-239-g696d2aa. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core tajo-plan. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/708//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/708//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/708//console This message is automatically generated.
          Hide
          jihoonson Jihoon Son added a comment -

          Fixed findbugs warnings.

          Show
          jihoonson Jihoon Son added a comment - Fixed findbugs warnings.
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12723284/TAJO-1499_3.patch
          against master revision release-0.9.0-rc0-241-g4eb8713.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          -1 findbugs. The patch appears to introduce 17 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in tajo-core tajo-plan.

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/711//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/711//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/711//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12723284/TAJO-1499_3.patch against master revision release-0.9.0-rc0-241-g4eb8713. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 17 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core tajo-plan. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/711//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/711//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/711//console This message is automatically generated.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user blrunner commented on the pull request:

          https://github.com/apache/tajo/pull/500#issuecomment-89913375

          +1

          Ship it.

          Show
          githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/500#issuecomment-89913375 +1 Ship it.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tajo/pull/500

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/500
          Hide
          jihoonson Jihoon Son added a comment -

          Thanks Jaehwa Jung for the review.
          Committed to the master branch.

          Show
          jihoonson Jihoon Son added a comment - Thanks Jaehwa Jung for the review. Committed to the master branch.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Tajo-master-CODEGEN-build #293 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/293/)
          TAJO-1499: Check the bind status when EvalNode::eval() is called. (jihoonson: rev 72948b63a79cd8902381c3443699c887b2740491)

          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/IsNullEval.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/SignedEval.java
          • tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java
          • tajo-core/src/main/java/org/apache/tajo/engine/utils/TupleUtil.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/UnaryEval.java
          • CHANGES
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/GeneralFunctionEval.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/NotEval.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/RowConstantEval.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/FieldEval.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/CastEval.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/FunctionEval.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/InEval.java
          • tajo-core/src/test/java/org/apache/tajo/engine/eval/TestEvalTree.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/AggregationFunctionCallEval.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/WindowFunctionEval.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/CaseWhenEval.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/BinaryEval.java
          • tajo-core/src/test/java/org/apache/tajo/engine/eval/TestEvalTreeUtil.java
          • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ComparableVector.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/ConstEval.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/BetweenPredicateEval.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/PatternMatchPredicateEval.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/AlgebraicUtil.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/EvalNode.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #293 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/293/ ) TAJO-1499 : Check the bind status when EvalNode::eval() is called. (jihoonson: rev 72948b63a79cd8902381c3443699c887b2740491) tajo-plan/src/main/java/org/apache/tajo/plan/expr/IsNullEval.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/SignedEval.java tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java tajo-core/src/main/java/org/apache/tajo/engine/utils/TupleUtil.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/UnaryEval.java CHANGES tajo-plan/src/main/java/org/apache/tajo/plan/expr/GeneralFunctionEval.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/NotEval.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/RowConstantEval.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/FieldEval.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/CastEval.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/FunctionEval.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/InEval.java tajo-core/src/test/java/org/apache/tajo/engine/eval/TestEvalTree.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/AggregationFunctionCallEval.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/WindowFunctionEval.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/CaseWhenEval.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/BinaryEval.java tajo-core/src/test/java/org/apache/tajo/engine/eval/TestEvalTreeUtil.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ComparableVector.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/ConstEval.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/BetweenPredicateEval.java tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/PatternMatchPredicateEval.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/AlgebraicUtil.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/EvalNode.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-build #655 (See https://builds.apache.org/job/Tajo-master-build/655/)
          TAJO-1499: Check the bind status when EvalNode::eval() is called. (jihoonson: rev 72948b63a79cd8902381c3443699c887b2740491)

          • tajo-core/src/test/java/org/apache/tajo/engine/eval/TestEvalTreeUtil.java
          • tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java
          • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ComparableVector.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/IsNullEval.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/BinaryEval.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/CaseWhenEval.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/InEval.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/FieldEval.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/BetweenPredicateEval.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/WindowFunctionEval.java
          • CHANGES
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/EvalNode.java
          • tajo-core/src/main/java/org/apache/tajo/engine/utils/TupleUtil.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/GeneralFunctionEval.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/FunctionEval.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/UnaryEval.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/RowConstantEval.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/AggregationFunctionCallEval.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/PatternMatchPredicateEval.java
          • tajo-core/src/test/java/org/apache/tajo/engine/eval/TestEvalTree.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/ConstEval.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/AlgebraicUtil.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/SignedEval.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/CastEval.java
          • tajo-plan/src/main/java/org/apache/tajo/plan/expr/NotEval.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #655 (See https://builds.apache.org/job/Tajo-master-build/655/ ) TAJO-1499 : Check the bind status when EvalNode::eval() is called. (jihoonson: rev 72948b63a79cd8902381c3443699c887b2740491) tajo-core/src/test/java/org/apache/tajo/engine/eval/TestEvalTreeUtil.java tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ComparableVector.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/IsNullEval.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/BinaryEval.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/CaseWhenEval.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/InEval.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/FieldEval.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/BetweenPredicateEval.java tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/WindowFunctionEval.java CHANGES tajo-plan/src/main/java/org/apache/tajo/plan/expr/EvalNode.java tajo-core/src/main/java/org/apache/tajo/engine/utils/TupleUtil.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/GeneralFunctionEval.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/FunctionEval.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/UnaryEval.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/RowConstantEval.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/AggregationFunctionCallEval.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/PatternMatchPredicateEval.java tajo-core/src/test/java/org/apache/tajo/engine/eval/TestEvalTree.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/ConstEval.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/AlgebraicUtil.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/SignedEval.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/CastEval.java tajo-plan/src/main/java/org/apache/tajo/plan/expr/NotEval.java

            People

            • Assignee:
              jihoonson Jihoon Son
              Reporter:
              jihoonson Jihoon Son
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development