Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1497

RPC client does not share a connection

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.9.0, 0.10.0
    • Fix Version/s: 0.11.0
    • Component/s: Java Client, RPC
    • Labels:
      None

      Description

      Currently, tajo client try to connect per client API call.
      ServerCallable request to server and then It close the channel. We should close only Idle connection.
      If a server throw the service exception, client and server always close the channel. we should fix it

      1. TAJO-1497_2.patch
        119 kB
        Jinho Kim
      2. TAJO-1497_3.patch
        133 kB
        Jinho Kim
      3. TAJO-1497_4.patch
        139 kB
        Jinho Kim
      4. TAJO-1497.patch
        119 kB
        Jinho Kim

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user jinossy opened a pull request:

          https://github.com/apache/tajo/pull/533

          TAJO-1497: TajoClient does not share a connection

          I've change RpcConnectionPool to RpcConnectionManager and remove the release codes.
          Because netty rpc does not need pooling.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/jinossy/tajo TAJO-1497

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tajo/pull/533.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #533


          commit a0ff031876f29c5d449916ffd13bb9c66636014b
          Author: Jinho Kim <jhkim@apache.org>
          Date: 2015-04-14T05:39:07Z

          TAJO-1497: TajoClient does not share a connection


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/533 TAJO-1497 : TajoClient does not share a connection I've change RpcConnectionPool to RpcConnectionManager and remove the release codes. Because netty rpc does not need pooling. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-1497 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/533.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #533 commit a0ff031876f29c5d449916ffd13bb9c66636014b Author: Jinho Kim <jhkim@apache.org> Date: 2015-04-14T05:39:07Z TAJO-1497 : TajoClient does not share a connection
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on the pull request:

          https://github.com/apache/tajo/pull/533#issuecomment-92621371

          I think this patch is very important to make Tajo more stable. So, I'll review it first.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/533#issuecomment-92621371 I think this patch is very important to make Tajo more stable. So, I'll review it first.
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12725157/TAJO-1497.patch
          against master revision release-0.9.0-rc0-253-g7d72088.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          -1 findbugs. The patch appears to introduce 18 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in tajo-catalog/tajo-catalog-client tajo-client tajo-core tajo-rpc/tajo-rpc-common tajo-rpc/tajo-rpc-protobuf:
          org.apache.tajo.client.TestTajoClient

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/729//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/729//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/729//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12725157/TAJO-1497.patch against master revision release-0.9.0-rc0-253-g7d72088. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 18 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in tajo-catalog/tajo-catalog-client tajo-client tajo-core tajo-rpc/tajo-rpc-common tajo-rpc/tajo-rpc-protobuf: org.apache.tajo.client.TestTajoClient Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/729//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/729//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/729//console This message is automatically generated.
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12725178/TAJO-1497_2.patch
          against master revision release-0.9.0-rc0-253-g7d72088.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          -1 findbugs. The patch appears to introduce 19 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-client tajo-client tajo-core tajo-rpc/tajo-rpc-common tajo-rpc/tajo-rpc-protobuf.

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/730//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/730//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-rpc-protobuf.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/730//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/730//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12725178/TAJO-1497_2.patch against master revision release-0.9.0-rc0-253-g7d72088. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 19 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-client tajo-client tajo-core tajo-rpc/tajo-rpc-common tajo-rpc/tajo-rpc-protobuf. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/730//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/730//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-rpc-protobuf.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/730//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/730//console This message is automatically generated.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jinossy commented on the pull request:

          https://github.com/apache/tajo/pull/533#issuecomment-93156036

          I've rename to RpcClientManager

          Show
          githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/533#issuecomment-93156036 I've rename to RpcClientManager
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12725525/TAJO-1497_3.patch
          against master revision release-0.9.0-rc0-254-gc42d4b3.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          -1 findbugs. The patch appears to introduce 18 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-client tajo-client tajo-core tajo-rpc/tajo-rpc-common tajo-rpc/tajo-rpc-protobuf.

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/731//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/731//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/731//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12725525/TAJO-1497_3.patch against master revision release-0.9.0-rc0-254-gc42d4b3. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 18 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-client tajo-client tajo-core tajo-rpc/tajo-rpc-common tajo-rpc/tajo-rpc-protobuf. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/731//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/731//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/731//console This message is automatically generated.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on a diff in the pull request:

          https://github.com/apache/tajo/pull/533#discussion_r28410201

          — Diff: tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java —
          @@ -286,13 +286,13 @@ public void close() {
          // remove session
          NettyClientBase client = null;
          try

          { - client = connPool.getConnection(getTajoMasterAddr(), TajoMasterClientProtocol.class, false); + client = manager.getConnection(getTajoMasterAddr(), TajoMasterClientProtocol.class, false); TajoMasterClientProtocolService.BlockingInterface tajoMaster = client.getStub(); tajoMaster.removeSession(null, sessionId); }

          catch (Throwable e)

          { // ignore }

          finally {

          • connPool.releaseConnection(client);
            + manager.cleanup(client);
              • End diff –

          This is a static function.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/533#discussion_r28410201 — Diff: tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java — @@ -286,13 +286,13 @@ public void close() { // remove session NettyClientBase client = null; try { - client = connPool.getConnection(getTajoMasterAddr(), TajoMasterClientProtocol.class, false); + client = manager.getConnection(getTajoMasterAddr(), TajoMasterClientProtocol.class, false); TajoMasterClientProtocolService.BlockingInterface tajoMaster = client.getStub(); tajoMaster.removeSession(null, sessionId); } catch (Throwable e) { // ignore } finally { connPool.releaseConnection(client); + manager.cleanup(client); End diff – This is a static function.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jinossy commented on a diff in the pull request:

          https://github.com/apache/tajo/pull/533#discussion_r28413814

          — Diff: tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java —
          @@ -286,13 +286,13 @@ public void close() {
          // remove session
          NettyClientBase client = null;
          try

          { - client = connPool.getConnection(getTajoMasterAddr(), TajoMasterClientProtocol.class, false); + client = manager.getConnection(getTajoMasterAddr(), TajoMasterClientProtocol.class, false); TajoMasterClientProtocolService.BlockingInterface tajoMaster = client.getStub(); tajoMaster.removeSession(null, sessionId); }

          catch (Throwable e)

          { // ignore }

          finally {

          • connPool.releaseConnection(client);
            + manager.cleanup(client);
              • End diff –

          Thank you for nice finding

          Show
          githubbot ASF GitHub Bot added a comment - Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/533#discussion_r28413814 — Diff: tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java — @@ -286,13 +286,13 @@ public void close() { // remove session NettyClientBase client = null; try { - client = connPool.getConnection(getTajoMasterAddr(), TajoMasterClientProtocol.class, false); + client = manager.getConnection(getTajoMasterAddr(), TajoMasterClientProtocol.class, false); TajoMasterClientProtocolService.BlockingInterface tajoMaster = client.getStub(); tajoMaster.removeSession(null, sessionId); } catch (Throwable e) { // ignore } finally { connPool.releaseConnection(client); + manager.cleanup(client); End diff – Thank you for nice finding
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on a diff in the pull request:

          https://github.com/apache/tajo/pull/533#discussion_r28428571

          — Diff: tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/ServerCallable.java —
          @@ -33,17 +33,17 @@
          protected Class<?> protocol;
          protected boolean asyncMode;
          protected boolean closeConn;

          • protected RpcConnectionPool connPool;
            + protected RpcClientManager manager;

          public abstract T call(NettyClientBase client) throws Exception;

          • public ServerCallable(RpcConnectionPool connPool, InetSocketAddress addr, Class<?> protocol, boolean asyncMode) {
            + public ServerCallable(RpcClientManager connPool, InetSocketAddress addr, Class<?> protocol, boolean asyncMode) { this(connPool, addr, protocol, asyncMode, false); }
          • public ServerCallable(RpcConnectionPool connPool, InetSocketAddress addr, Class<?> protocol,
            + public ServerCallable(RpcClientManager manager, InetSocketAddress addr, Class<?> protocol,
              • End diff –

          This constructor seems to be not used anymore. How about removing it?

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/533#discussion_r28428571 — Diff: tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/ServerCallable.java — @@ -33,17 +33,17 @@ protected Class<?> protocol; protected boolean asyncMode; protected boolean closeConn; protected RpcConnectionPool connPool; + protected RpcClientManager manager; public abstract T call(NettyClientBase client) throws Exception; public ServerCallable(RpcConnectionPool connPool, InetSocketAddress addr, Class<?> protocol, boolean asyncMode) { + public ServerCallable(RpcClientManager connPool, InetSocketAddress addr, Class<?> protocol, boolean asyncMode) { this(connPool, addr, protocol, asyncMode, false); } public ServerCallable(RpcConnectionPool connPool, InetSocketAddress addr, Class<?> protocol, + public ServerCallable(RpcClientManager manager, InetSocketAddress addr, Class<?> protocol, End diff – This constructor seems to be not used anymore. How about removing it?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jinossy commented on a diff in the pull request:

          https://github.com/apache/tajo/pull/533#discussion_r28486050

          — Diff: tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/ServerCallable.java —
          @@ -33,17 +33,17 @@
          protected Class<?> protocol;
          protected boolean asyncMode;
          protected boolean closeConn;

          • protected RpcConnectionPool connPool;
            + protected RpcClientManager manager;

          public abstract T call(NettyClientBase client) throws Exception;

          • public ServerCallable(RpcConnectionPool connPool, InetSocketAddress addr, Class<?> protocol, boolean asyncMode) {
            + public ServerCallable(RpcClientManager connPool, InetSocketAddress addr, Class<?> protocol, boolean asyncMode) { this(connPool, addr, protocol, asyncMode, false); }
          • public ServerCallable(RpcConnectionPool connPool, InetSocketAddress addr, Class<?> protocol,
            + public ServerCallable(RpcClientManager manager, InetSocketAddress addr, Class<?> protocol,
              • End diff –

          I've remove constructor

          Show
          githubbot ASF GitHub Bot added a comment - Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/533#discussion_r28486050 — Diff: tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/ServerCallable.java — @@ -33,17 +33,17 @@ protected Class<?> protocol; protected boolean asyncMode; protected boolean closeConn; protected RpcConnectionPool connPool; + protected RpcClientManager manager; public abstract T call(NettyClientBase client) throws Exception; public ServerCallable(RpcConnectionPool connPool, InetSocketAddress addr, Class<?> protocol, boolean asyncMode) { + public ServerCallable(RpcClientManager connPool, InetSocketAddress addr, Class<?> protocol, boolean asyncMode) { this(connPool, addr, protocol, asyncMode, false); } public ServerCallable(RpcConnectionPool connPool, InetSocketAddress addr, Class<?> protocol, + public ServerCallable(RpcClientManager manager, InetSocketAddress addr, Class<?> protocol, End diff – I've remove constructor
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jinossy commented on the pull request:

          https://github.com/apache/tajo/pull/533#issuecomment-93652982

          I've enable idle timeout. If all requests is done and client is idle state, client will be closed
          ```
          public static final int RPC_IDLE_TIMEOUT = 43200; // 12 hour
          ```

          Show
          githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/533#issuecomment-93652982 I've enable idle timeout. If all requests is done and client is idle state, client will be closed ``` public static final int RPC_IDLE_TIMEOUT = 43200; // 12 hour ```
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12725786/TAJO-1497_4.patch
          against master revision release-0.9.0-rc0-255-g338a2b7.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          -1 findbugs. The patch appears to introduce 18 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-client tajo-client tajo-core tajo-rpc/tajo-rpc-common tajo-rpc/tajo-rpc-protobuf.

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/735//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/735//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/735//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12725786/TAJO-1497_4.patch against master revision release-0.9.0-rc0-255-g338a2b7. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 18 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-client tajo-client tajo-core tajo-rpc/tajo-rpc-common tajo-rpc/tajo-rpc-protobuf. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/735//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/735//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/735//console This message is automatically generated.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on the pull request:

          https://github.com/apache/tajo/pull/533#issuecomment-93668470

          +1
          thanks for the nice patch!
          I think that we can make our rpc cleaner with this patch.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/533#issuecomment-93668470 +1 thanks for the nice patch! I think that we can make our rpc cleaner with this patch.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tajo/pull/533

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/533
          Hide
          jhkim Jinho Kim added a comment -

          Thank you for your review

          Show
          jhkim Jinho Kim added a comment - Thank you for your review
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Tajo-master-CODEGEN-build #307 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/307/)
          TAJO-1497: RPC client does not share a connection. (jinho) (jhkim: rev 7b78668b7d90d268bb6065586fe880cda08571c4)

          • tajo-core/src/main/java/org/apache/tajo/master/QueryInProgress.java
          • tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java
          • tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java
          • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/RpcConnectionPool.java
          • tajo-rpc/tajo-rpc-common/src/main/java/org/apache/tajo/rpc/RpcUtils.java
          • tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestBlockingRpc.java
          • tajo-core/src/main/java/org/apache/tajo/worker/WorkerHeartbeatService.java
          • tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMaster.java
          • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/RpcClientManager.java
          • tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java
          • tajo-core/src/main/java/org/apache/tajo/worker/Task.java
          • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/AsyncRpcClient.java
          • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/AsyncRpcServer.java
          • tajo-core/src/main/java/org/apache/tajo/master/TajoContainerProxy.java
          • tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClientImpl.java
          • CHANGES
          • tajo-core/src/main/java/org/apache/tajo/worker/ExecutionBlockContext.java
          • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/BlockingRpcServer.java
          • tajo-core/src/main/java/org/apache/tajo/worker/rule/ConnectivityCheckerRuleForTajoWorker.java
          • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/NettyClientBase.java
          • tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestRpcClientManager.java
          • tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestAsyncRpc.java
          • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/ServerCallable.java
          • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/BlockingRpcClient.java
          • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/ConnectionCloseFutureListener.java
          • tajo-core/src/main/java/org/apache/tajo/worker/TajoResourceAllocator.java
          • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/ProtoChannelInitializer.java
          • tajo-core/src/main/java/org/apache/tajo/worker/TaskRunner.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #307 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/307/ ) TAJO-1497 : RPC client does not share a connection. (jinho) (jhkim: rev 7b78668b7d90d268bb6065586fe880cda08571c4) tajo-core/src/main/java/org/apache/tajo/master/QueryInProgress.java tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/RpcConnectionPool.java tajo-rpc/tajo-rpc-common/src/main/java/org/apache/tajo/rpc/RpcUtils.java tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestBlockingRpc.java tajo-core/src/main/java/org/apache/tajo/worker/WorkerHeartbeatService.java tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMaster.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/RpcClientManager.java tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java tajo-core/src/main/java/org/apache/tajo/worker/Task.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/AsyncRpcClient.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/AsyncRpcServer.java tajo-core/src/main/java/org/apache/tajo/master/TajoContainerProxy.java tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClientImpl.java CHANGES tajo-core/src/main/java/org/apache/tajo/worker/ExecutionBlockContext.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/BlockingRpcServer.java tajo-core/src/main/java/org/apache/tajo/worker/rule/ConnectivityCheckerRuleForTajoWorker.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/NettyClientBase.java tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestRpcClientManager.java tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestAsyncRpc.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/ServerCallable.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/BlockingRpcClient.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/ConnectionCloseFutureListener.java tajo-core/src/main/java/org/apache/tajo/worker/TajoResourceAllocator.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/ProtoChannelInitializer.java tajo-core/src/main/java/org/apache/tajo/worker/TaskRunner.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Tajo-master-build #669 (See https://builds.apache.org/job/Tajo-master-build/669/)
          TAJO-1497: RPC client does not share a connection. (jinho) (jhkim: rev 7b78668b7d90d268bb6065586fe880cda08571c4)

          • tajo-core/src/main/java/org/apache/tajo/worker/Task.java
          • tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClientImpl.java
          • tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestAsyncRpc.java
          • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/AsyncRpcServer.java
          • tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java
          • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/AsyncRpcClient.java
          • tajo-core/src/main/java/org/apache/tajo/worker/TaskRunner.java
          • tajo-core/src/main/java/org/apache/tajo/master/QueryInProgress.java
          • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/ConnectionCloseFutureListener.java
          • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/ProtoChannelInitializer.java
          • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/BlockingRpcServer.java
          • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/NettyClientBase.java
          • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/RpcClientManager.java
          • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/ServerCallable.java
          • tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMaster.java
          • tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java
          • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/BlockingRpcClient.java
          • tajo-core/src/main/java/org/apache/tajo/worker/ExecutionBlockContext.java
          • tajo-core/src/main/java/org/apache/tajo/master/TajoContainerProxy.java
          • tajo-rpc/tajo-rpc-common/src/main/java/org/apache/tajo/rpc/RpcUtils.java
          • tajo-core/src/main/java/org/apache/tajo/worker/rule/ConnectivityCheckerRuleForTajoWorker.java
          • CHANGES
          • tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/RpcConnectionPool.java
          • tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java
          • tajo-core/src/main/java/org/apache/tajo/worker/TajoResourceAllocator.java
          • tajo-core/src/main/java/org/apache/tajo/worker/WorkerHeartbeatService.java
          • tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestBlockingRpc.java
          • tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestRpcClientManager.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-build #669 (See https://builds.apache.org/job/Tajo-master-build/669/ ) TAJO-1497 : RPC client does not share a connection. (jinho) (jhkim: rev 7b78668b7d90d268bb6065586fe880cda08571c4) tajo-core/src/main/java/org/apache/tajo/worker/Task.java tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClientImpl.java tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestAsyncRpc.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/AsyncRpcServer.java tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/AsyncRpcClient.java tajo-core/src/main/java/org/apache/tajo/worker/TaskRunner.java tajo-core/src/main/java/org/apache/tajo/master/QueryInProgress.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/ConnectionCloseFutureListener.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/ProtoChannelInitializer.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/BlockingRpcServer.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/NettyClientBase.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/RpcClientManager.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/ServerCallable.java tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMaster.java tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/BlockingRpcClient.java tajo-core/src/main/java/org/apache/tajo/worker/ExecutionBlockContext.java tajo-core/src/main/java/org/apache/tajo/master/TajoContainerProxy.java tajo-rpc/tajo-rpc-common/src/main/java/org/apache/tajo/rpc/RpcUtils.java tajo-core/src/main/java/org/apache/tajo/worker/rule/ConnectivityCheckerRuleForTajoWorker.java CHANGES tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/RpcConnectionPool.java tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java tajo-core/src/main/java/org/apache/tajo/worker/TajoResourceAllocator.java tajo-core/src/main/java/org/apache/tajo/worker/WorkerHeartbeatService.java tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestBlockingRpc.java tajo-rpc/tajo-rpc-protobuf/src/test/java/org/apache/tajo/rpc/TestRpcClientManager.java
          Hide
          navis Navis added a comment -

          pool.releaseConnection() supposed not to close the connection. I really cannot understand the problem to be fixed by this.

          Show
          navis Navis added a comment - pool.releaseConnection() supposed not to close the connection. I really cannot understand the problem to be fixed by this.
          Hide
          jhkim Jinho Kim added a comment -

          Navis
          Sorry for confusing you, main problem is ServerCallable closing. I was remove strange codes. because RpcConnectionPool are just rpc client manager. I will update the description.

          Show
          jhkim Jinho Kim added a comment - Navis Sorry for confusing you, main problem is ServerCallable closing. I was remove strange codes. because RpcConnectionPool are just rpc client manager. I will update the description.

            People

            • Assignee:
              jhkim Jinho Kim
              Reporter:
              jhkim Jinho Kim
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development