Details

      Description

      Currently, we does not support legacy yarn cluster mode. We should remove it

      • Remove Yarn mode
      • Remove QueryMaster mode
      • Remove related codes
      1. TAJO-1482_2.patch
        85 kB
        Jinho Kim
      2. TAJO-1482.patch
        81 kB
        Jinho Kim

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jinossy opened a pull request:

        https://github.com/apache/tajo/pull/484

        TAJO-1482: Cleanup the legacy cluster mode.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jinossy/tajo TAJO-1482

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/484.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #484


        commit 2ede49c6dee7b6a7098d42bba66c0d30a356328a
        Author: Jinho Kim <jhkim@apache.org>
        Date: 2015-03-31T04:46:11Z

        TAJO-1482: Cleanup the legacy cluster mode.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/484 TAJO-1482 : Cleanup the legacy cluster mode. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-1482 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/484.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #484 commit 2ede49c6dee7b6a7098d42bba66c0d30a356328a Author: Jinho Kim <jhkim@apache.org> Date: 2015-03-31T04:46:11Z TAJO-1482 : Cleanup the legacy cluster mode.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12708324/TAJO-1482.patch
        against master revision release-0.9.0-rc0-226-g652e4db.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 6 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-cli tajo-client tajo-common tajo-core tajo-dist tajo-pullserver.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/679//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/679//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/679//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-pullserver.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/679//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12708324/TAJO-1482.patch against master revision release-0.9.0-rc0-226-g652e4db. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 6 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-cli tajo-client tajo-common tajo-core tajo-dist tajo-pullserver. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/679//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/679//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/679//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-pullserver.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/679//console This message is automatically generated.
        Hide
        jhkim Jinho Kim added a comment -

        I've fix the findbug warnings in PullServer

        Show
        jhkim Jinho Kim added a comment - I've fix the findbug warnings in PullServer
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12708354/TAJO-1482_2.patch
        against master revision release-0.9.0-rc0-226-g652e4db.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-cli tajo-client tajo-common tajo-core tajo-dist tajo-pullserver.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/682//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/682//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/682//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12708354/TAJO-1482_2.patch against master revision release-0.9.0-rc0-226-g652e4db. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-cli tajo-client tajo-common tajo-core tajo-dist tajo-pullserver. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/682//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/682//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/682//console This message is automatically generated.
        Hide
        jihoonson Jihoon Son added a comment -

        I'll review today.

        Show
        jihoonson Jihoon Son added a comment - I'll review today.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jihoonson commented on the pull request:

        https://github.com/apache/tajo/pull/484#issuecomment-88360980

        +1
        This is definitely necessary work. Thanks!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/484#issuecomment-88360980 +1 This is definitely necessary work. Thanks!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/484

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/484
        Hide
        jhkim Jinho Kim added a comment -

        committed it to master.
        Thanks.

        Show
        jhkim Jinho Kim added a comment - committed it to master. Thanks.
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-master-CODEGEN-build #277 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/277/)
        TAJO-1482: Cleanup the legacy cluster mode. (jinho) (jhkim: rev 968633ff06b29101586286980a2099fc3dd4c534)

        • tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
        • tajo-core/src/main/resources/webapps/admin/index.jsp
        • tajo-pullserver/src/main/java/org/apache/tajo/pullserver/retriever/DirectoryRetriever.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TaskRunnerManager.java
        • tajo-core/src/main/java/org/apache/tajo/worker/WorkerHeartbeatService.java
        • tajo-core/src/main/resources/webapps/admin/cluster.jsp
        • tajo-dist/src/main/bin/start-tajo.sh
        • tajo-core/src/main/java/org/apache/tajo/master/rm/Worker.java
        • tajo-dist/src/main/conf/tajo-env.sh
        • tajo-core/src/test/java/org/apache/tajo/MiniTajoYarnCluster.java
        • tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java
        • tajo-core/src/test/java/org/apache/tajo/master/rm/TestTajoResourceManager.java
        • tajo-core/src/main/proto/QueryCoordinatorProtocol.proto
        • tajo-core/src/main/java/org/apache/tajo/master/rm/WorkerResource.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/NonForwardQueryResultSystemScanner.java
        • tajo-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServer.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tools/TajoAdmin.java
        • tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMaster.java
        • tajo-pullserver/src/main/java/org/apache/tajo/pullserver/PullServerAuxService.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java
        • tajo-core/src/main/resources/tajo-default.xml
        • tajo-client/src/main/proto/ClientProtos.proto
        • tajo-core/src/main/java/org/apache/tajo/master/rm/TajoResourceTracker.java
        • tajo-core/src/main/resources/webapps/worker/index.jsp
        • tajo-dist/src/main/bin/stop-tajo.sh
        • tajo-dist/src/main/bin/tajo
        • tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java
        • tajo-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java
        • CHANGES
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-CODEGEN-build #277 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/277/ ) TAJO-1482 : Cleanup the legacy cluster mode. (jinho) (jhkim: rev 968633ff06b29101586286980a2099fc3dd4c534) tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java tajo-core/src/main/resources/webapps/admin/index.jsp tajo-pullserver/src/main/java/org/apache/tajo/pullserver/retriever/DirectoryRetriever.java tajo-core/src/main/java/org/apache/tajo/worker/TaskRunnerManager.java tajo-core/src/main/java/org/apache/tajo/worker/WorkerHeartbeatService.java tajo-core/src/main/resources/webapps/admin/cluster.jsp tajo-dist/src/main/bin/start-tajo.sh tajo-core/src/main/java/org/apache/tajo/master/rm/Worker.java tajo-dist/src/main/conf/tajo-env.sh tajo-core/src/test/java/org/apache/tajo/MiniTajoYarnCluster.java tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java tajo-core/src/test/java/org/apache/tajo/master/rm/TestTajoResourceManager.java tajo-core/src/main/proto/QueryCoordinatorProtocol.proto tajo-core/src/main/java/org/apache/tajo/master/rm/WorkerResource.java tajo-core/src/main/java/org/apache/tajo/master/exec/NonForwardQueryResultSystemScanner.java tajo-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServer.java tajo-cli/src/main/java/org/apache/tajo/cli/tools/TajoAdmin.java tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMaster.java tajo-pullserver/src/main/java/org/apache/tajo/pullserver/PullServerAuxService.java tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java tajo-core/src/main/resources/tajo-default.xml tajo-client/src/main/proto/ClientProtos.proto tajo-core/src/main/java/org/apache/tajo/master/rm/TajoResourceTracker.java tajo-core/src/main/resources/webapps/worker/index.jsp tajo-dist/src/main/bin/stop-tajo.sh tajo-dist/src/main/bin/tajo tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java tajo-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java CHANGES
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #640 (See https://builds.apache.org/job/Tajo-master-build/640/)
        TAJO-1482: Cleanup the legacy cluster mode. (jinho) (jhkim: rev 968633ff06b29101586286980a2099fc3dd4c534)

        • tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java
        • tajo-core/src/test/java/org/apache/tajo/MiniTajoYarnCluster.java
        • tajo-core/src/main/resources/webapps/worker/index.jsp
        • tajo-dist/src/main/bin/tajo
        • tajo-pullserver/src/main/java/org/apache/tajo/pullserver/retriever/DirectoryRetriever.java
        • tajo-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java
        • tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java
        • tajo-client/src/main/proto/ClientProtos.proto
        • tajo-core/src/main/java/org/apache/tajo/worker/WorkerHeartbeatService.java
        • tajo-core/src/main/java/org/apache/tajo/master/rm/Worker.java
        • tajo-core/src/main/resources/webapps/admin/index.jsp
        • CHANGES
        • tajo-core/src/test/java/org/apache/tajo/master/rm/TestTajoResourceManager.java
        • tajo-core/src/main/java/org/apache/tajo/master/exec/NonForwardQueryResultSystemScanner.java
        • tajo-core/src/main/resources/webapps/admin/cluster.jsp
        • tajo-dist/src/main/conf/tajo-env.sh
        • tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMaster.java
        • tajo-core/src/main/proto/QueryCoordinatorProtocol.proto
        • tajo-core/src/main/java/org/apache/tajo/master/rm/TajoResourceTracker.java
        • tajo-core/src/main/java/org/apache/tajo/worker/TaskRunnerManager.java
        • tajo-dist/src/main/bin/start-tajo.sh
        • tajo-cli/src/main/java/org/apache/tajo/cli/tools/TajoAdmin.java
        • tajo-dist/src/main/bin/stop-tajo.sh
        • tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java
        • tajo-core/src/main/java/org/apache/tajo/master/rm/WorkerResource.java
        • tajo-pullserver/src/main/java/org/apache/tajo/pullserver/PullServerAuxService.java
        • tajo-core/src/main/resources/tajo-default.xml
        • tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
        • tajo-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServer.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #640 (See https://builds.apache.org/job/Tajo-master-build/640/ ) TAJO-1482 : Cleanup the legacy cluster mode. (jinho) (jhkim: rev 968633ff06b29101586286980a2099fc3dd4c534) tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java tajo-core/src/test/java/org/apache/tajo/MiniTajoYarnCluster.java tajo-core/src/main/resources/webapps/worker/index.jsp tajo-dist/src/main/bin/tajo tajo-pullserver/src/main/java/org/apache/tajo/pullserver/retriever/DirectoryRetriever.java tajo-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java tajo-client/src/main/proto/ClientProtos.proto tajo-core/src/main/java/org/apache/tajo/worker/WorkerHeartbeatService.java tajo-core/src/main/java/org/apache/tajo/master/rm/Worker.java tajo-core/src/main/resources/webapps/admin/index.jsp CHANGES tajo-core/src/test/java/org/apache/tajo/master/rm/TestTajoResourceManager.java tajo-core/src/main/java/org/apache/tajo/master/exec/NonForwardQueryResultSystemScanner.java tajo-core/src/main/resources/webapps/admin/cluster.jsp tajo-dist/src/main/conf/tajo-env.sh tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMaster.java tajo-core/src/main/proto/QueryCoordinatorProtocol.proto tajo-core/src/main/java/org/apache/tajo/master/rm/TajoResourceTracker.java tajo-core/src/main/java/org/apache/tajo/worker/TaskRunnerManager.java tajo-dist/src/main/bin/start-tajo.sh tajo-cli/src/main/java/org/apache/tajo/cli/tools/TajoAdmin.java tajo-dist/src/main/bin/stop-tajo.sh tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java tajo-core/src/main/java/org/apache/tajo/master/rm/WorkerResource.java tajo-pullserver/src/main/java/org/apache/tajo/pullserver/PullServerAuxService.java tajo-core/src/main/resources/tajo-default.xml tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java tajo-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServer.java

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development