Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1462

Replace CSV examples into TEXT examples in docs

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.1
    • Component/s: Documentation
    • Labels:
      None

      Description

      To guide users to move from CSV into TEXT storage type, this issue propose to replace CSV examples into TEXT examples.

      • Case 1: An example with no delimiter definition
        - USING CSV
        + USING TEXT WITH ('textfile.delimiter'=',')
        
      • Case 2: An example with text delimiter definition
        - USING CSV WITH('text.delimiter'='\u0001',...)
        + USING TEXT WITH('text.delimiter'='\u0001',...)
        
      1. TAJO-1462.Hyun.150328.0.patch.txt
        5 kB
        Dongjoon Hyun
      2. TAJO-1462.Hyun.150331.0.patch.txt
        16 kB
        Dongjoon Hyun
      3. TAJO-1462.Hyun.150331.1.patch.txt
        16 kB
        Dongjoon Hyun

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user dongjoon-hyun opened a pull request:

          https://github.com/apache/tajo/pull/475

          TAJO-1462: Replace CSV examples into TEXT examples in docs

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/dongjoon-hyun/tajo TAJO-1462

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tajo/pull/475.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #475


          commit 7e0ed26dd5036a292a76fa23c77a9eb8ae0742eb
          Author: Dongjoon Hyun <dongjoon@apache.org>
          Date: 2015-03-28T07:25:24Z

          TAJO-1462: Replace CSV examples into TEXT examples in docs


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/tajo/pull/475 TAJO-1462 : Replace CSV examples into TEXT examples in docs You can merge this pull request into a Git repository by running: $ git pull https://github.com/dongjoon-hyun/tajo TAJO-1462 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/475.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #475 commit 7e0ed26dd5036a292a76fa23c77a9eb8ae0742eb Author: Dongjoon Hyun <dongjoon@apache.org> Date: 2015-03-28T07:25:24Z TAJO-1462 : Replace CSV examples into TEXT examples in docs
          Hide
          tajoqa Tajo QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12707975/TAJO-1462.Hyun.150328.0.patch.txt
          against master revision release-0.9.0-rc0-223-g373d53c.

          +1 @author. The patch does not contain any @author tags.

          +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/669//testReport/
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/669//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12707975/TAJO-1462.Hyun.150328.0.patch.txt against master revision release-0.9.0-rc0-223-g373d53c. +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/669//testReport/ Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/669//console This message is automatically generated.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on the pull request:

          https://github.com/apache/tajo/pull/475#issuecomment-87891801

          Thanks for your contribution. I have two comments.

          • If any options are given, the delimiter of text files is ','. I think that we need at least one example without the delimiter option.
          • You modified the document for the csv file. However, that document still looks to explain how to use csv files. So, it would be better to change the document title together.
          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/475#issuecomment-87891801 Thanks for your contribution. I have two comments. If any options are given, the delimiter of text files is ','. I think that we need at least one example without the delimiter option. You modified the document for the csv file. However, that document still looks to explain how to use csv files. So, it would be better to change the document title together.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dongjoon-hyun commented on the pull request:

          https://github.com/apache/tajo/pull/475#issuecomment-87911457

          @jihoonson . Thank you! First, I will omit " text.delimiter=',' " and make some notes for the default value. Second, I will replace csv.rst into text.rst. Do you think that is enough?

          Show
          githubbot ASF GitHub Bot added a comment - Github user dongjoon-hyun commented on the pull request: https://github.com/apache/tajo/pull/475#issuecomment-87911457 @jihoonson . Thank you! First, I will omit " text.delimiter=',' " and make some notes for the default value. Second, I will replace csv.rst into text.rst. Do you think that is enough?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on the pull request:

          https://github.com/apache/tajo/pull/475#issuecomment-87913585

          Right. It will be nice.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/475#issuecomment-87913585 Right. It will be nice.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dongjoon-hyun commented on the pull request:

          https://github.com/apache/tajo/pull/475#issuecomment-87927523

          Hi, @jihoonson . I rebased and changed. But I need your guide for one thing. In the document, I found that Tajo defines CSV files as 'character-separated values' files, not 'comma-separated values' file. In that case, I think CSV seems to be a more specific and exact term than TEXT. As a result, `csv.rst` looks good to me. How do you think about this? (By the way, I found that the default value is explained enough in the doc.)

          Show
          githubbot ASF GitHub Bot added a comment - Github user dongjoon-hyun commented on the pull request: https://github.com/apache/tajo/pull/475#issuecomment-87927523 Hi, @jihoonson . I rebased and changed. But I need your guide for one thing. In the document, I found that Tajo defines CSV files as 'character-separated values' files, not 'comma-separated values' file. In that case, I think CSV seems to be a more specific and exact term than TEXT. As a result, `csv.rst` looks good to me. How do you think about this? (By the way, I found that the default value is explained enough in the doc.)
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on the pull request:

          https://github.com/apache/tajo/pull/475#issuecomment-87960849

          In that case, users may be confused because we also provide the ```csv``` file format.
          I think that it will be enough if we introduce the ```text``` file as the delimiter-separated values format.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/475#issuecomment-87960849 In that case, users may be confused because we also provide the ```csv``` file format. I think that it will be enough if we introduce the ```text``` file as the delimiter-separated values format.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dongjoon-hyun commented on the pull request:

          https://github.com/apache/tajo/pull/475#issuecomment-87971837

          I see, @jihoonson . You're right. I renamed and changed more description according to your comments.

          Show
          githubbot ASF GitHub Bot added a comment - Github user dongjoon-hyun commented on the pull request: https://github.com/apache/tajo/pull/475#issuecomment-87971837 I see, @jihoonson . You're right. I renamed and changed more description according to your comments.
          Hide
          tajoqa Tajo QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12708360/TAJO-1462.Hyun.150331.0.patch.txt
          against master revision release-0.9.0-rc0-226-g652e4db.

          +1 @author. The patch does not contain any @author tags.

          +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/683//testReport/
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/683//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12708360/TAJO-1462.Hyun.150331.0.patch.txt against master revision release-0.9.0-rc0-226-g652e4db. +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/683//testReport/ Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/683//console This message is automatically generated.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on a diff in the pull request:

          https://github.com/apache/tajo/pull/475#discussion_r27476477

          — Diff: tajo-docs/src/main/sphinx/table_management/text.rst —
          @@ -1,21 +1,21 @@
          *************************************
          -CSV (TextFile)
          +TEXT
          *************************************

          -A character-separated values (CSV) file represents a tabular data set consisting of rows and columns.
          +A character-separated values text file represents a tabular data set consisting of rows and columns.
          — End diff –

          It would be better if readers can easily understand what text means. As you know, ```text``` can represent both the TEXT file and strings.
          How about emphasize the letters ```text``` when it means the TEXT file? For sphyinx syntax, please refer to http://sphinx-doc.org/rest.html.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/475#discussion_r27476477 — Diff: tajo-docs/src/main/sphinx/table_management/text.rst — @@ -1,21 +1,21 @@ ************************************* -CSV (TextFile) +TEXT ************************************* -A character-separated values (CSV) file represents a tabular data set consisting of rows and columns. +A character-separated values text file represents a tabular data set consisting of rows and columns. — End diff – It would be better if readers can easily understand what text means. As you know, ```text``` can represent both the TEXT file and strings. How about emphasize the letters ```text``` when it means the TEXT file? For sphyinx syntax, please refer to http://sphinx-doc.org/rest.html .
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on a diff in the pull request:

          https://github.com/apache/tajo/pull/475#discussion_r27476499

          — Diff: tajo-docs/src/main/sphinx/table_management/text.rst —
          @@ -1,21 +1,21 @@
          *************************************
          -CSV (TextFile)
          +TEXT
          *************************************

          -A character-separated values (CSV) file represents a tabular data set consisting of rows and columns.
          +A character-separated values text file represents a tabular data set consisting of rows and columns.
          Each row is a plan-text line. A line is usually broken by a character line feed ``\n`` or carriage-return ``\r``.
          The line feed ``\n`` is the default delimiter in Tajo. Each record consists of multiple fields, separated by
          some other character or string, most commonly a literal vertical bar ``|``, comma ``,`` or tab ``\t``.
          The vertical bar is used as the default field delimiter in Tajo.

          =========================================
          -How to Create a CSV Table ?
          +How to Create a TEXT Table ?
          =========================================

          If you are not familiar with the ``CREATE TABLE`` statement, please refer to the Data Definition Language :doc:`/sql_language/ddl`.

          In order to specify a certain file format for your table, you need to use the ``USING`` clause in your ``CREATE TABLE``
          -statement. The below is an example statement for creating a table using CSV files.
          +statement. The below is an example statement for creating a table using text files.
          — End diff –

          Same comment with the above one.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/475#discussion_r27476499 — Diff: tajo-docs/src/main/sphinx/table_management/text.rst — @@ -1,21 +1,21 @@ ************************************* -CSV (TextFile) +TEXT ************************************* -A character-separated values (CSV) file represents a tabular data set consisting of rows and columns. +A character-separated values text file represents a tabular data set consisting of rows and columns. Each row is a plan-text line. A line is usually broken by a character line feed ``\n`` or carriage-return ``\r``. The line feed ``\n`` is the default delimiter in Tajo. Each record consists of multiple fields, separated by some other character or string, most commonly a literal vertical bar ``|``, comma ``,`` or tab ``\t``. The vertical bar is used as the default field delimiter in Tajo. ========================================= -How to Create a CSV Table ? +How to Create a TEXT Table ? ========================================= If you are not familiar with the ``CREATE TABLE`` statement, please refer to the Data Definition Language :doc:`/sql_language/ddl`. In order to specify a certain file format for your table, you need to use the ``USING`` clause in your ``CREATE TABLE`` -statement. The below is an example statement for creating a table using CSV files. +statement. The below is an example statement for creating a table using text files. — End diff – Same comment with the above one.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dongjoon-hyun commented on a diff in the pull request:

          https://github.com/apache/tajo/pull/475#discussion_r27479028

          — Diff: tajo-docs/src/main/sphinx/table_management/text.rst —
          @@ -1,21 +1,21 @@
          *************************************
          -CSV (TextFile)
          +TEXT
          *************************************

          -A character-separated values (CSV) file represents a tabular data set consisting of rows and columns.
          +A character-separated values text file represents a tabular data set consisting of rows and columns.
          — End diff –

          Sure. That would be better.

          Show
          githubbot ASF GitHub Bot added a comment - Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/tajo/pull/475#discussion_r27479028 — Diff: tajo-docs/src/main/sphinx/table_management/text.rst — @@ -1,21 +1,21 @@ ************************************* -CSV (TextFile) +TEXT ************************************* -A character-separated values (CSV) file represents a tabular data set consisting of rows and columns. +A character-separated values text file represents a tabular data set consisting of rows and columns. — End diff – Sure. That would be better.
          Hide
          tajoqa Tajo QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12708433/TAJO-1462.Hyun.150331.1.patch.txt
          against master revision release-0.9.0-rc0-227-g487a0e5.

          +1 @author. The patch does not contain any @author tags.

          +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/685//testReport/
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/685//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12708433/TAJO-1462.Hyun.150331.1.patch.txt against master revision release-0.9.0-rc0-227-g487a0e5. +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/685//testReport/ Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/685//console This message is automatically generated.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dongjoon-hyun commented on the pull request:

          https://github.com/apache/tajo/pull/475#issuecomment-88879349

          Rebased.

          Show
          githubbot ASF GitHub Bot added a comment - Github user dongjoon-hyun commented on the pull request: https://github.com/apache/tajo/pull/475#issuecomment-88879349 Rebased.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on a diff in the pull request:

          https://github.com/apache/tajo/pull/475#discussion_r27768014

          — Diff: tajo-docs/src/main/sphinx/table_management/text.rst —
          @@ -34,19 +34,19 @@ Physical Properties
          Some table storage formats provide parameters for enabling or disabling features and adjusting physical parameters.
          The ``WITH`` clause in the CREATE TABLE statement allows users to set those parameters.

          -Now, the CSV storage format provides the following physical properties.
          +TEXT format provides the following physical properties.

          • ``text.delimiter``: delimiter character. ``|`` or ``\u0001`` is usually used, and the default field delimiter is ``|``.
            • ``text.null``: NULL character. The default NULL character is an empty string ``''``. Hive's default NULL character is ``'
              N'``.
              +* ``text.null``: ``NULL`` character. The default ``NULL`` character is an empty string ``''``. Hive's default ``NULL`` character is ``'
              N'``.
          • ``compression.codec``: Compression codec. You can enable compression feature and set specified compression algorithm. The compression algorithm used to compress files. The compression codec name should be the fully qualified class name inherited from `org.apache.hadoop.io.compress.CompressionCodec <https://hadoop.apache.org/docs/current/api/org/apache/hadoop/io/compress/CompressionCodec.html>`_. By default, compression is disabled.
            • ``csvfile.serde`` (deprecated): custom (De)serializer class. ``org.apache.tajo.storage.TextSerializerDeserializer`` is the default (De)serializer class.
              +* ``text.serde``: custom (De)serializer class. ``org.apache.tajo.storage.TextSerializerDeserializer`` is the default (De)serializer class.
              • End diff –

          The default SerDe class is ```org.apache.tajo.storage.text.CSVLineSerDe```.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on a diff in the pull request: https://github.com/apache/tajo/pull/475#discussion_r27768014 — Diff: tajo-docs/src/main/sphinx/table_management/text.rst — @@ -34,19 +34,19 @@ Physical Properties Some table storage formats provide parameters for enabling or disabling features and adjusting physical parameters. The ``WITH`` clause in the CREATE TABLE statement allows users to set those parameters. -Now, the CSV storage format provides the following physical properties. + TEXT format provides the following physical properties. ``text.delimiter``: delimiter character. ``|`` or ``\u0001`` is usually used, and the default field delimiter is ``|``. ``text.null``: NULL character. The default NULL character is an empty string ``''``. Hive's default NULL character is ``' N'``. +* ``text.null``: ``NULL`` character. The default ``NULL`` character is an empty string ``''``. Hive's default ``NULL`` character is ``' N'``. ``compression.codec``: Compression codec. You can enable compression feature and set specified compression algorithm. The compression algorithm used to compress files. The compression codec name should be the fully qualified class name inherited from `org.apache.hadoop.io.compress.CompressionCodec < https://hadoop.apache.org/docs/current/api/org/apache/hadoop/io/compress/CompressionCodec.html >`_. By default, compression is disabled. ``csvfile.serde`` (deprecated): custom (De)serializer class. ``org.apache.tajo.storage.TextSerializerDeserializer`` is the default (De)serializer class. +* ``text.serde``: custom (De)serializer class. ``org.apache.tajo.storage.TextSerializerDeserializer`` is the default (De)serializer class. End diff – The default SerDe class is ```org.apache.tajo.storage.text.CSVLineSerDe```.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on the pull request:

          https://github.com/apache/tajo/pull/475#issuecomment-89541392

          +1. The patch LGTM in overall.
          I left one comment on the wrong name of the default SerDe class.
          I'll fix it before commit.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/475#issuecomment-89541392 +1. The patch LGTM in overall. I left one comment on the wrong name of the default SerDe class. I'll fix it before commit.
          Hide
          jihoonson Jihoon Son added a comment -

          This issue is a kind of a task rather than a bug.
          I'll change the issue type.

          Show
          jihoonson Jihoon Son added a comment - This issue is a kind of a task rather than a bug. I'll change the issue type.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tajo/pull/475

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/475
          Hide
          jihoonson Jihoon Son added a comment -

          Committed to 0.10.1 and master branches.

          Show
          jihoonson Jihoon Son added a comment - Committed to 0.10.1 and master branches.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Tajo-master-CODEGEN-build #288 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/288/)
          TAJO-1462: Replace CSV examples into TEXT examples in docs. (jihoonson: rev b0abff8e896d7985eaf1aa48d9c2ab3a45618f01)

          • tajo-docs/src/main/sphinx/table_management/csv.rst
          • tajo-docs/src/main/sphinx/backup_and_restore/catalog.rst
          • tajo-docs/src/main/sphinx/table_management/file_formats.rst
          • tajo-docs/src/main/sphinx/table_management/text.rst
          • tajo-docs/src/main/sphinx/table_management/table_overview.rst
          • tajo-docs/src/main/sphinx/getting_started.rst
          • CHANGES
          • tajo-docs/src/main/sphinx/sql_language/ddl.rst
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #288 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/288/ ) TAJO-1462 : Replace CSV examples into TEXT examples in docs. (jihoonson: rev b0abff8e896d7985eaf1aa48d9c2ab3a45618f01) tajo-docs/src/main/sphinx/table_management/csv.rst tajo-docs/src/main/sphinx/backup_and_restore/catalog.rst tajo-docs/src/main/sphinx/table_management/file_formats.rst tajo-docs/src/main/sphinx/table_management/text.rst tajo-docs/src/main/sphinx/table_management/table_overview.rst tajo-docs/src/main/sphinx/getting_started.rst CHANGES tajo-docs/src/main/sphinx/sql_language/ddl.rst
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-build #650 (See https://builds.apache.org/job/Tajo-master-build/650/)
          TAJO-1462: Replace CSV examples into TEXT examples in docs. (jihoonson: rev b0abff8e896d7985eaf1aa48d9c2ab3a45618f01)

          • CHANGES
          • tajo-docs/src/main/sphinx/table_management/csv.rst
          • tajo-docs/src/main/sphinx/table_management/text.rst
          • tajo-docs/src/main/sphinx/backup_and_restore/catalog.rst
          • tajo-docs/src/main/sphinx/sql_language/ddl.rst
          • tajo-docs/src/main/sphinx/table_management/table_overview.rst
          • tajo-docs/src/main/sphinx/table_management/file_formats.rst
          • tajo-docs/src/main/sphinx/getting_started.rst
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #650 (See https://builds.apache.org/job/Tajo-master-build/650/ ) TAJO-1462 : Replace CSV examples into TEXT examples in docs. (jihoonson: rev b0abff8e896d7985eaf1aa48d9c2ab3a45618f01) CHANGES tajo-docs/src/main/sphinx/table_management/csv.rst tajo-docs/src/main/sphinx/table_management/text.rst tajo-docs/src/main/sphinx/backup_and_restore/catalog.rst tajo-docs/src/main/sphinx/sql_language/ddl.rst tajo-docs/src/main/sphinx/table_management/table_overview.rst tajo-docs/src/main/sphinx/table_management/file_formats.rst tajo-docs/src/main/sphinx/getting_started.rst
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dongjoon-hyun commented on the pull request:

          https://github.com/apache/tajo/pull/475#issuecomment-89547559

          Thank you, @jihoonson !

          Show
          githubbot ASF GitHub Bot added a comment - Github user dongjoon-hyun commented on the pull request: https://github.com/apache/tajo/pull/475#issuecomment-89547559 Thank you, @jihoonson !
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dongjoon-hyun commented on a diff in the pull request:

          https://github.com/apache/tajo/pull/475#discussion_r27768262

          — Diff: tajo-docs/src/main/sphinx/table_management/text.rst —
          @@ -34,19 +34,19 @@ Physical Properties
          Some table storage formats provide parameters for enabling or disabling features and adjusting physical parameters.
          The ``WITH`` clause in the CREATE TABLE statement allows users to set those parameters.

          -Now, the CSV storage format provides the following physical properties.
          +TEXT format provides the following physical properties.

          • ``text.delimiter``: delimiter character. ``|`` or ``\u0001`` is usually used, and the default field delimiter is ``|``.
            • ``text.null``: NULL character. The default NULL character is an empty string ``''``. Hive's default NULL character is ``'
              N'``.
              +* ``text.null``: ``NULL`` character. The default ``NULL`` character is an empty string ``''``. Hive's default ``NULL`` character is ``'
              N'``.
          • ``compression.codec``: Compression codec. You can enable compression feature and set specified compression algorithm. The compression algorithm used to compress files. The compression codec name should be the fully qualified class name inherited from `org.apache.hadoop.io.compress.CompressionCodec <https://hadoop.apache.org/docs/current/api/org/apache/hadoop/io/compress/CompressionCodec.html>`_. By default, compression is disabled.
            • ``csvfile.serde`` (deprecated): custom (De)serializer class. ``org.apache.tajo.storage.TextSerializerDeserializer`` is the default (De)serializer class.
              +* ``text.serde``: custom (De)serializer class. ``org.apache.tajo.storage.TextSerializerDeserializer`` is the default (De)serializer class.
              • End diff –

          Of course! Thank you again, @jihoonson !

          Show
          githubbot ASF GitHub Bot added a comment - Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/tajo/pull/475#discussion_r27768262 — Diff: tajo-docs/src/main/sphinx/table_management/text.rst — @@ -34,19 +34,19 @@ Physical Properties Some table storage formats provide parameters for enabling or disabling features and adjusting physical parameters. The ``WITH`` clause in the CREATE TABLE statement allows users to set those parameters. -Now, the CSV storage format provides the following physical properties. + TEXT format provides the following physical properties. ``text.delimiter``: delimiter character. ``|`` or ``\u0001`` is usually used, and the default field delimiter is ``|``. ``text.null``: NULL character. The default NULL character is an empty string ``''``. Hive's default NULL character is ``' N'``. +* ``text.null``: ``NULL`` character. The default ``NULL`` character is an empty string ``''``. Hive's default ``NULL`` character is ``' N'``. ``compression.codec``: Compression codec. You can enable compression feature and set specified compression algorithm. The compression algorithm used to compress files. The compression codec name should be the fully qualified class name inherited from `org.apache.hadoop.io.compress.CompressionCodec < https://hadoop.apache.org/docs/current/api/org/apache/hadoop/io/compress/CompressionCodec.html >`_. By default, compression is disabled. ``csvfile.serde`` (deprecated): custom (De)serializer class. ``org.apache.tajo.storage.TextSerializerDeserializer`` is the default (De)serializer class. +* ``text.serde``: custom (De)serializer class. ``org.apache.tajo.storage.TextSerializerDeserializer`` is the default (De)serializer class. End diff – Of course! Thank you again, @jihoonson !

            People

            • Assignee:
              dongjoon Dongjoon Hyun
              Reporter:
              dongjoon Dongjoon Hyun
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development