Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1449

TestSelectQuery.testExplainSelect() fails

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: Unit Test
    • Labels:
      None

      Description

      In TAJO-1426, the shape of logical plans for explain statements is fixed according to some rules during unit tests. So, the expected result also have to be changed, but it doesn't.

      1. TAJO-1449_2.patch
        3 kB
        Jihoon Son
      2. TAJO-1449_3.patch
        5 kB
        Jihoon Son
      3. TAJO-1449_4.patch
        5 kB
        Jihoon Son
      4. TAJO-1449.patch
        3 kB
        Jihoon Son

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #629 (See https://builds.apache.org/job/Tajo-master-build/629/)
        TAJO-1449: TestSelectQuery.testExplainSelect() fails. (jihoon) (jihoonson: rev 12f30c5856e46d56e217ef0d3f48accc878600f5)

        • tajo-core/src/test/resources/results/TestSelectQuery/testExplainSelect.result
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestSelectQuery.java
        • tajo-core/src/main/java/org/apache/tajo/engine/codegen/TajoGeneratorAdapter.java
        • tajo-core/src/main/java/org/apache/tajo/util/metrics/reporter/MetricsFileScheduledReporter.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #629 (See https://builds.apache.org/job/Tajo-master-build/629/ ) TAJO-1449 : TestSelectQuery.testExplainSelect() fails. (jihoon) (jihoonson: rev 12f30c5856e46d56e217ef0d3f48accc878600f5) tajo-core/src/test/resources/results/TestSelectQuery/testExplainSelect.result tajo-core/src/test/java/org/apache/tajo/engine/query/TestSelectQuery.java tajo-core/src/main/java/org/apache/tajo/engine/codegen/TajoGeneratorAdapter.java tajo-core/src/main/java/org/apache/tajo/util/metrics/reporter/MetricsFileScheduledReporter.java CHANGES
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #267 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/267/)
        TAJO-1449: TestSelectQuery.testExplainSelect() fails. (jihoon) (jihoonson: rev 12f30c5856e46d56e217ef0d3f48accc878600f5)

        • tajo-core/src/main/java/org/apache/tajo/util/metrics/reporter/MetricsFileScheduledReporter.java
        • tajo-core/src/test/resources/results/TestSelectQuery/testExplainSelect.result
        • CHANGES
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestSelectQuery.java
        • tajo-core/src/main/java/org/apache/tajo/engine/codegen/TajoGeneratorAdapter.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #267 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/267/ ) TAJO-1449 : TestSelectQuery.testExplainSelect() fails. (jihoon) (jihoonson: rev 12f30c5856e46d56e217ef0d3f48accc878600f5) tajo-core/src/main/java/org/apache/tajo/util/metrics/reporter/MetricsFileScheduledReporter.java tajo-core/src/test/resources/results/TestSelectQuery/testExplainSelect.result CHANGES tajo-core/src/test/java/org/apache/tajo/engine/query/TestSelectQuery.java tajo-core/src/main/java/org/apache/tajo/engine/codegen/TajoGeneratorAdapter.java
        Hide
        jihoonson Jihoon Son added a comment -

        Committed to the master branch

        Show
        jihoonson Jihoon Son added a comment - Committed to the master branch
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/460

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/460
        Hide
        dongjoon Dongjoon Hyun added a comment -

        +1.
        Thank you!

        Show
        dongjoon Dongjoon Hyun added a comment - +1. Thank you!
        Hide
        tajoqa Tajo QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12706907/TAJO-1449_4.patch
        against master revision release-0.9.0-rc0-217-g3e9a2dd.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/658//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/658//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12706907/TAJO-1449_4.patch against master revision release-0.9.0-rc0-217-g3e9a2dd. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/658//testReport/ Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/658//console This message is automatically generated.
        Hide
        jihoonson Jihoon Son added a comment -

        Thanks for quick review.
        I triggered the jenkins precommit test again.
        I'll commit after that.

        Show
        jihoonson Jihoon Son added a comment - Thanks for quick review. I triggered the jenkins precommit test again. I'll commit after that.
        Hide
        blrunner Jaehwa Jung added a comment -

        +1

        Thanks for quick patch and it looks good to me.
        But maybe something was wrong on jenkins servers last night.
        You need to upload the patch again for build trigger.
        If possible, would you check the jenkins result message and possibly push it to master branch?

        Show
        blrunner Jaehwa Jung added a comment - +1 Thanks for quick patch and it looks good to me. But maybe something was wrong on jenkins servers last night. You need to upload the patch again for build trigger. If possible, would you check the jenkins result message and possibly push it to master branch?
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12706907/TAJO-1449_4.patch
        against master revision release-0.9.0-rc0-217-g3e9a2dd.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in tajo-core:
        org.apache.tajo.cli.tsql.commands.TestExecExternalShellCommand
        org.apache.tajo.cli.tsql.TestTajoCli
        org.apache.tajo.cli.tsql.TestDefaultCliOutputFormatter
        org.apache.tajo.cli.tools.TestTajoDump
        org.apache.tajo.cli.tsql.commands.TestHdfsCommand
        org.apache.tajo.engine.query.TestHBaseTable
        org.apache.tajo.client.TestTajoClient

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/656//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/656//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12706907/TAJO-1449_4.patch against master revision release-0.9.0-rc0-217-g3e9a2dd. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in tajo-core: org.apache.tajo.cli.tsql.commands.TestExecExternalShellCommand org.apache.tajo.cli.tsql.TestTajoCli org.apache.tajo.cli.tsql.TestDefaultCliOutputFormatter org.apache.tajo.cli.tools.TestTajoDump org.apache.tajo.cli.tsql.commands.TestHdfsCommand org.apache.tajo.engine.query.TestHBaseTable org.apache.tajo.client.TestTajoClient Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/656//testReport/ Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/656//console This message is automatically generated.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12706897/TAJO-1449_3.patch
        against master revision release-0.9.0-rc0-217-g3e9a2dd.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in tajo-core:
        org.apache.tajo.util.metrics.TestSystemMetrics

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/655//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/655//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12706897/TAJO-1449_3.patch against master revision release-0.9.0-rc0-217-g3e9a2dd. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in tajo-core: org.apache.tajo.util.metrics.TestSystemMetrics Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/655//testReport/ Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/655//console This message is automatically generated.
        Hide
        jihoonson Jihoon Son added a comment -

        I'll resolve findbugs warning.

        Show
        jihoonson Jihoon Son added a comment - I'll resolve findbugs warning.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12706867/TAJO-1449_2.patch
        against master revision release-0.9.0-rc0-217-g3e9a2dd.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 2 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/651//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/651//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/651//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12706867/TAJO-1449_2.patch against master revision release-0.9.0-rc0-217-g3e9a2dd. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/651//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/651//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/651//console This message is automatically generated.
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jihoonson opened a pull request:

        https://github.com/apache/tajo/pull/460

        TAJO-1449: TestSelectQuery.testExplainSelect() fails

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jihoonson/tajo-2 TAJO-1449

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/460.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #460


        commit 530f246f5ac1a71fd23e9a74045bded552f5568a
        Author: Jihoon Son <jihoonson@apache.org>
        Date: 2015-03-24T09:00:57Z

        TAJO-1449


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jihoonson opened a pull request: https://github.com/apache/tajo/pull/460 TAJO-1449 : TestSelectQuery.testExplainSelect() fails You can merge this pull request into a Git repository by running: $ git pull https://github.com/jihoonson/tajo-2 TAJO-1449 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/460.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #460 commit 530f246f5ac1a71fd23e9a74045bded552f5568a Author: Jihoon Son <jihoonson@apache.org> Date: 2015-03-24T09:00:57Z TAJO-1449

          People

          • Assignee:
            jihoonson Jihoon Son
            Reporter:
            jihoonson Jihoon Son
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development