Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1439

Some method name is written wrongly

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.10.0
    • Fix Version/s: 0.11.0, 0.10.1
    • Component/s: TajoMaster
    • Labels:
      None

      Description

      The name of QueryInprogress.submmitQueryToMaster() should be 'submitQueryToMaster'.

      1. TAJO-1439.patch
        1 kB
        Jongyoung Park

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user eminency opened a pull request:

        https://github.com/apache/tajo/pull/444

        TAJO-1439: Wrong method name is fixed

        Pretty much trivial

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/eminency/tajo tajo-1439

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/444.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #444


        commit 25ff63dd6a312e96335abc627d1e69b5af6c3794
        Author: Jongyoung Park <eminency@gmail.com>
        Date: 2015-03-21T08:24:47Z

        Wrong method name is fixed


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user eminency opened a pull request: https://github.com/apache/tajo/pull/444 TAJO-1439 : Wrong method name is fixed Pretty much trivial You can merge this pull request into a Git repository by running: $ git pull https://github.com/eminency/tajo tajo-1439 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/444.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #444 commit 25ff63dd6a312e96335abc627d1e69b5af6c3794 Author: Jongyoung Park <eminency@gmail.com> Date: 2015-03-21T08:24:47Z Wrong method name is fixed
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12706140/TAJO-1439.patch
        against master revision release-0.9.0-rc0-212-g154f5b9.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 2 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/631//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/631//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/631//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12706140/TAJO-1439.patch against master revision release-0.9.0-rc0-212-g154f5b9. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/631//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/631//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/631//console This message is automatically generated.
        Hide
        jihoonson Jihoon Son added a comment -

        +1
        Very trivial.

        Show
        jihoonson Jihoon Son added a comment - +1 Very trivial.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/444

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/444
        Hide
        jihoonson Jihoon Son added a comment -

        Committed to branch-0.10.1 and master.
        Thanks for your contribution!

        Show
        jihoonson Jihoon Son added a comment - Committed to branch-0.10.1 and master. Thanks for your contribution!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #262 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/262/)
        TAJO-1439: Some method name is written wrongly. (Contributed by Jongyoung Park. Committed by jihoon) (jihoonson: rev 3aaff387c29adf1949d0a6ac4f0d6d7c7388f238)

        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/master/QueryInProgress.java
        • tajo-core/src/main/java/org/apache/tajo/master/QueryManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #262 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/262/ ) TAJO-1439 : Some method name is written wrongly. (Contributed by Jongyoung Park. Committed by jihoon) (jihoonson: rev 3aaff387c29adf1949d0a6ac4f0d6d7c7388f238) CHANGES tajo-core/src/main/java/org/apache/tajo/master/QueryInProgress.java tajo-core/src/main/java/org/apache/tajo/master/QueryManager.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #624 (See https://builds.apache.org/job/Tajo-master-build/624/)
        TAJO-1439: Some method name is written wrongly. (Contributed by Jongyoung Park. Committed by jihoon) (jihoonson: rev 3aaff387c29adf1949d0a6ac4f0d6d7c7388f238)

        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/master/QueryManager.java
        • tajo-core/src/main/java/org/apache/tajo/master/QueryInProgress.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #624 (See https://builds.apache.org/job/Tajo-master-build/624/ ) TAJO-1439 : Some method name is written wrongly. (Contributed by Jongyoung Park. Committed by jihoon) (jihoonson: rev 3aaff387c29adf1949d0a6ac4f0d6d7c7388f238) CHANGES tajo-core/src/main/java/org/apache/tajo/master/QueryManager.java tajo-core/src/main/java/org/apache/tajo/master/QueryInProgress.java
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user dongjoon-hyun commented on the pull request:

        https://github.com/apache/tajo/pull/444#issuecomment-84508446

        Hi, sorry for asking check again. Could you see my comment, please? I don't know the reason.

        https://github.com/apache/tajo/commit/3aaff387c29adf1949d0a6ac4f0d6d7c7388f238

        Show
        githubbot ASF GitHub Bot added a comment - Github user dongjoon-hyun commented on the pull request: https://github.com/apache/tajo/pull/444#issuecomment-84508446 Hi, sorry for asking check again. Could you see my comment, please? I don't know the reason. https://github.com/apache/tajo/commit/3aaff387c29adf1949d0a6ac4f0d6d7c7388f238
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user eminency commented on the pull request:

        https://github.com/apache/tajo/pull/444#issuecomment-84512061

        @dongjoon-hyun I'm working on it.

        Show
        githubbot ASF GitHub Bot added a comment - Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/444#issuecomment-84512061 @dongjoon-hyun I'm working on it.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user dongjoon-hyun commented on the pull request:

        https://github.com/apache/tajo/pull/444#issuecomment-84514043

        @eminency Thank you!

        Show
        githubbot ASF GitHub Bot added a comment - Github user dongjoon-hyun commented on the pull request: https://github.com/apache/tajo/pull/444#issuecomment-84514043 @eminency Thank you!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user eminency commented on the pull request:

        https://github.com/apache/tajo/pull/444#issuecomment-84563816

        @dongjoon-hyun To track it, I created another JIRA ticket right before : https://issues.apache.org/jira/browse/TAJO-1440
        It looks like a different problem.

        Show
        githubbot ASF GitHub Bot added a comment - Github user eminency commented on the pull request: https://github.com/apache/tajo/pull/444#issuecomment-84563816 @dongjoon-hyun To track it, I created another JIRA ticket right before : https://issues.apache.org/jira/browse/TAJO-1440 It looks like a different problem.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user dongjoon-hyun commented on the pull request:

        https://github.com/apache/tajo/pull/444#issuecomment-84567284

        @eminency Thank you for spending your time during weekend. I see.

        Show
        githubbot ASF GitHub Bot added a comment - Github user dongjoon-hyun commented on the pull request: https://github.com/apache/tajo/pull/444#issuecomment-84567284 @eminency Thank you for spending your time during weekend. I see.

          People

          • Assignee:
            eminency Jongyoung Park
            Reporter:
            eminency Jongyoung Park
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development