Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.10.0
    • Fix Version/s: 0.11.0, 0.10.1
    • Component/s: Documentation
    • Labels:
      None

      Description

      Tajo proudly supports Hadoop 2.6.0.

      - * Hadoop 2.3.0 or higher (up to 2.5.1)
      + * Hadoop 2.3.0 or higher (up to 2.6.0)
      

      Also, pom.xml is updated according to the comments.

      -    <hadoop.version>2.5.1</hadoop.version>
      +    <hadoop.version>2.6.0</hadoop.version>
      
      1. TAJO-1434.patch
        1 kB
        Dongjoon Hyun

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user dongjoon-hyun opened a pull request:

        https://github.com/apache/tajo/pull/443

        TAJO-1434: Fix supporting version of Hadoop

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/dongjoon-hyun/tajo TAJO-1434

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/443.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #443


        commit c01fa640d318049c4b06971f063d28eb2b7a6d2f
        Author: Dongjoon Hyun <dongjoon@apache.org>
        Date: 2015-03-20T11:30:08Z

        TAJO-1434: Fix supporting version of Hadoop


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/tajo/pull/443 TAJO-1434 : Fix supporting version of Hadoop You can merge this pull request into a Git repository by running: $ git pull https://github.com/dongjoon-hyun/tajo TAJO-1434 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/443.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #443 commit c01fa640d318049c4b06971f063d28eb2b7a6d2f Author: Dongjoon Hyun <dongjoon@apache.org> Date: 2015-03-20T11:30:08Z TAJO-1434 : Fix supporting version of Hadoop
        Hide
        tajoqa Tajo QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12705893/TAJO-1434.patch
        against master revision release-0.9.0-rc0-212-g154f5b9.

        +1 @author. The patch does not contain any @author tags.

        +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/628//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/628//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12705893/TAJO-1434.patch against master revision release-0.9.0-rc0-212-g154f5b9. +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/628//testReport/ Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/628//console This message is automatically generated.
        Hide
        sirpkt Keuntae Park added a comment -

        +1

        Patch looks good to me.

        Show
        sirpkt Keuntae Park added a comment - +1 Patch looks good to me.
        Hide
        jhkim Jinho Kim added a comment -

        Keuntae Park
        We should update the maven pom.xml

        Show
        jhkim Jinho Kim added a comment - Keuntae Park We should update the maven pom.xml
        Hide
        dongjoon Dongjoon Hyun added a comment -

        Jinho Kim, Oh is it?

        Sorry, I thought we should change our documents based on the following announcement.


        http://tajo.apache.org/releases/0.10.0/announcement.html

        • Eco-system Integration
        • Hadoop 2.6.0 support
        Show
        dongjoon Dongjoon Hyun added a comment - Jinho Kim , Oh is it? Sorry, I thought we should change our documents based on the following announcement. http://tajo.apache.org/releases/0.10.0/announcement.html Eco-system Integration Hadoop 2.6.0 support
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user dongjoon-hyun commented on the pull request:

        https://github.com/apache/tajo/pull/443#issuecomment-85792249

        Rebased.

        Show
        githubbot ASF GitHub Bot added a comment - Github user dongjoon-hyun commented on the pull request: https://github.com/apache/tajo/pull/443#issuecomment-85792249 Rebased.
        Hide
        blrunner Jaehwa Jung added a comment -

        It seems that tajo doesn't support hadoop 2.6.0.
        You can find that hadoop version is set for hadoop 2.5.1 on /tajo-project/pom.xml.
        We need to create another issue for supporting hadoop 2.6.0.

        Show
        blrunner Jaehwa Jung added a comment - It seems that tajo doesn't support hadoop 2.6.0. You can find that hadoop version is set for hadoop 2.5.1 on /tajo-project/pom.xml. We need to create another issue for supporting hadoop 2.6.0.
        Hide
        dongjoon Dongjoon Hyun added a comment -

        To Jaehwa Jung, Jinho Kim.

        Then, could you fix the annoucement, first?

        In fact, I tested Tajo on my labtop with Hadoop 2.6.0 and Tajo on Docker with Hadoop 2.6.0.
        Not real cluster. I agree with both of you.

        Warmly,
        Dongjoon.

        Show
        dongjoon Dongjoon Hyun added a comment - To Jaehwa Jung , Jinho Kim . Then, could you fix the annoucement, first? In fact, I tested Tajo on my labtop with Hadoop 2.6.0 and Tajo on Docker with Hadoop 2.6.0. Not real cluster. I agree with both of you. Warmly, Dongjoon.
        Hide
        sirpkt Keuntae Park added a comment -

        However, current tajo passes 'mvn clean install -Dhadoop.version=2.6.0'.
        And 'extra.source.path', whose value may be influenced by hadoop version, is not used actually.

        I thought above means that tajo supports hadoop version 2.6.0.

        Is there any dependency on hadoop version other than above parts?

        Show
        sirpkt Keuntae Park added a comment - However, current tajo passes 'mvn clean install -Dhadoop.version=2.6.0'. And 'extra.source.path', whose value may be influenced by hadoop version, is not used actually. I thought above means that tajo supports hadoop version 2.6.0. Is there any dependency on hadoop version other than above parts?
        Hide
        jhkim Jinho Kim added a comment -

        We was testing on 2.6.0. I mean that the pom.xml should update to 2.6.0

        Show
        jhkim Jinho Kim added a comment - We was testing on 2.6.0. I mean that the pom.xml should update to 2.6.0
        Hide
        sirpkt Keuntae Park added a comment -

        Oh I see, Jinho Kim

        You mean the default hadoop.version in pom.xml should be updated to 2.6.0, right?

        I totally agree with that.

        Show
        sirpkt Keuntae Park added a comment - Oh I see, Jinho Kim You mean the default hadoop.version in pom.xml should be updated to 2.6.0, right? I totally agree with that.
        Hide
        blrunner Jaehwa Jung added a comment - - edited

        We already removed dependency on hadoop version at TAJO-1166.
        It just looks a simple mistake.

        Dongjoon Hyun Keep on doing what you are doing.

        Show
        blrunner Jaehwa Jung added a comment - - edited We already removed dependency on hadoop version at TAJO-1166 . It just looks a simple mistake. Dongjoon Hyun Keep on doing what you are doing.
        Hide
        jhkim Jinho Kim added a comment -

        Right, please go ahead

        Show
        jhkim Jinho Kim added a comment - Right, please go ahead
        Hide
        jhkim Jinho Kim added a comment - - edited

        Sorry, just miss click

        Show
        jhkim Jinho Kim added a comment - - edited Sorry, just miss click
        Hide
        dongjoon Dongjoon Hyun added a comment -

        Jinho Kim, thank you for pointing out that.

        I thought it's a documentation fix issue.

        According to your advice, I will fix like the following.

        diff --git a/tajo-project/pom.xml b/tajo-project/pom.xml
        index 37121e3..7ad4ae0 100644
        --- a/tajo-project/pom.xml
        +++ b/tajo-project/pom.xml
        @@ -33,7 +33,7 @@
           <properties>
             <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
             <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
        -    <hadoop.version>2.5.1</hadoop.version>
        +    <hadoop.version>2.6.0</hadoop.version>
             <protobuf.version>2.5.0</protobuf.version>
             <tajo.version>0.11.0-SNAPSHOT</tajo.version>
             <hbase.version>0.98.7-hadoop2</hbase.version>
        
        Show
        dongjoon Dongjoon Hyun added a comment - Jinho Kim , thank you for pointing out that. I thought it's a documentation fix issue. According to your advice, I will fix like the following. diff --git a/tajo-project/pom.xml b/tajo-project/pom.xml index 37121e3..7ad4ae0 100644 --- a/tajo-project/pom.xml +++ b/tajo-project/pom.xml @@ -33,7 +33,7 @@ <properties> <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> - <hadoop.version>2.5.1</hadoop.version> + <hadoop.version>2.6.0</hadoop.version> <protobuf.version>2.5.0</protobuf.version> <tajo.version>0.11.0-SNAPSHOT</tajo.version> <hbase.version>0.98.7-hadoop2</hbase.version>
        Hide
        dongjoon Dongjoon Hyun added a comment -

        Ur, I will wait for your more comment for a while.
        Thank you all~

        Show
        dongjoon Dongjoon Hyun added a comment - Ur, I will wait for your more comment for a while. Thank you all~
        Hide
        jhkim Jinho Kim added a comment -

        OK, Thanks

        Show
        jhkim Jinho Kim added a comment - OK, Thanks
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user dongjoon-hyun commented on the pull request:

        https://github.com/apache/tajo/pull/443#issuecomment-85826577

        According to the discussion in https://issues.apache.org/jira/browse/TAJO-1434, pom.xml is updated also.

        Show
        githubbot ASF GitHub Bot added a comment - Github user dongjoon-hyun commented on the pull request: https://github.com/apache/tajo/pull/443#issuecomment-85826577 According to the discussion in https://issues.apache.org/jira/browse/TAJO-1434 , pom.xml is updated also.
        Hide
        tajoqa Tajo QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12707134/TAJO-1434.patch
        against master revision release-0.9.0-rc0-218-g12f30c5.

        +1 @author. The patch does not contain any @author tags.

        +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/659//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/659//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12707134/TAJO-1434.patch against master revision release-0.9.0-rc0-218-g12f30c5. +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/659//testReport/ Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/659//console This message is automatically generated.
        Hide
        blrunner Jaehwa Jung added a comment -

        Dongjoon Hyun

        You don't need to remove existing patch.

        Tajo wiki will help you to name new patch file as follows.
        https://cwiki.apache.org/confluence/display/TAJO/How+to+Contribute+to+Tajo

        Show
        blrunner Jaehwa Jung added a comment - Dongjoon Hyun You don't need to remove existing patch. Tajo wiki will help you to name new patch file as follows. https://cwiki.apache.org/confluence/display/TAJO/How+to+Contribute+to+Tajo
        Hide
        dongjoon Dongjoon Hyun added a comment -

        Jaehwa Jung
        Oh, thank you for your kind guidance.
        Up to now, I didn't notice that I made such a mistake.
        I will read that carefully. Thank you again.

        Show
        dongjoon Dongjoon Hyun added a comment - Jaehwa Jung Oh, thank you for your kind guidance. Up to now, I didn't notice that I made such a mistake. I will read that carefully. Thank you again.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/443#issuecomment-86287362

        +1 LGTM
        I'll commit it soon

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/443#issuecomment-86287362 +1 LGTM I'll commit it soon
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user dongjoon-hyun commented on the pull request:

        https://github.com/apache/tajo/pull/443#issuecomment-86302088

        @jinossy Thank you very much!

        Show
        githubbot ASF GitHub Bot added a comment - Github user dongjoon-hyun commented on the pull request: https://github.com/apache/tajo/pull/443#issuecomment-86302088 @jinossy Thank you very much!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/443

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/443
        Hide
        jhkim Jinho Kim added a comment -

        committed it.
        Thank you for your contribution!

        Show
        jhkim Jinho Kim added a comment - committed it. Thank you for your contribution!
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-master-build #630 (See https://builds.apache.org/job/Tajo-master-build/630/)
        TAJO-1434: Fix supporting version of Hadoop. (jhkim: rev f9346e5093fdcbaab3927d192af25dea721b7956)

        • tajo-docs/src/main/sphinx/getting_started.rst
        • tajo-project/pom.xml
        • CHANGES
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-build #630 (See https://builds.apache.org/job/Tajo-master-build/630/ ) TAJO-1434 : Fix supporting version of Hadoop. (jhkim: rev f9346e5093fdcbaab3927d192af25dea721b7956) tajo-docs/src/main/sphinx/getting_started.rst tajo-project/pom.xml CHANGES
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-master-CODEGEN-build #268 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/268/)
        TAJO-1434: Fix supporting version of Hadoop. (jhkim: rev f9346e5093fdcbaab3927d192af25dea721b7956)

        • CHANGES
        • tajo-project/pom.xml
        • tajo-docs/src/main/sphinx/getting_started.rst
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-CODEGEN-build #268 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/268/ ) TAJO-1434 : Fix supporting version of Hadoop. (jhkim: rev f9346e5093fdcbaab3927d192af25dea721b7956) CHANGES tajo-project/pom.xml tajo-docs/src/main/sphinx/getting_started.rst

          People

          • Assignee:
            dongjoon Dongjoon Hyun
            Reporter:
            dongjoon Dongjoon Hyun
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development