Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1400

Add TajoStatement::setMaxRows method support

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.10.0
    • Fix Version/s: 0.11.0, 0.10.1
    • Component/s: JDBC Driver
    • Labels:
      None

      Description

      Statement::setMaxRows is a frequently used method in JDBC driver. It limits the number of result rows. Our current implementation does not support this method. We need to implement it.

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-build #652 (See https://builds.apache.org/job/Tajo-master-build/652/)
          TAJO-1400: Add TajoStatement::setMaxRows method support. (jihoonson: rev 696d2aa7fe6a507209c5b4660d4c4efb934d49b6)

          • tajo-client/src/main/java/org/apache/tajo/client/TajoClientImpl.java
          • tajo-client/src/main/java/org/apache/tajo/jdbc/FetchResultSet.java
          • tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoStatement.java
          • tajo-core/src/test/java/org/apache/tajo/jdbc/TestTajoJdbc.java
          • CHANGES
          • tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java
          • tajo-client/src/main/java/org/apache/tajo/client/QueryClient.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #652 (See https://builds.apache.org/job/Tajo-master-build/652/ ) TAJO-1400 : Add TajoStatement::setMaxRows method support. (jihoonson: rev 696d2aa7fe6a507209c5b4660d4c4efb934d49b6) tajo-client/src/main/java/org/apache/tajo/client/TajoClientImpl.java tajo-client/src/main/java/org/apache/tajo/jdbc/FetchResultSet.java tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoStatement.java tajo-core/src/test/java/org/apache/tajo/jdbc/TestTajoJdbc.java CHANGES tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java tajo-client/src/main/java/org/apache/tajo/client/QueryClient.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Tajo-master-CODEGEN-build #290 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/290/)
          TAJO-1400: Add TajoStatement::setMaxRows method support. (jihoonson: rev 696d2aa7fe6a507209c5b4660d4c4efb934d49b6)

          • tajo-client/src/main/java/org/apache/tajo/client/TajoClientImpl.java
          • tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoStatement.java
          • tajo-client/src/main/java/org/apache/tajo/jdbc/FetchResultSet.java
          • tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java
          • tajo-core/src/test/java/org/apache/tajo/jdbc/TestTajoJdbc.java
          • CHANGES
          • tajo-client/src/main/java/org/apache/tajo/client/QueryClient.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #290 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/290/ ) TAJO-1400 : Add TajoStatement::setMaxRows method support. (jihoonson: rev 696d2aa7fe6a507209c5b4660d4c4efb934d49b6) tajo-client/src/main/java/org/apache/tajo/client/TajoClientImpl.java tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoStatement.java tajo-client/src/main/java/org/apache/tajo/jdbc/FetchResultSet.java tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java tajo-core/src/test/java/org/apache/tajo/jdbc/TestTajoJdbc.java CHANGES tajo-client/src/main/java/org/apache/tajo/client/QueryClient.java
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tajo/pull/421

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/421
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on the pull request:

          https://github.com/apache/tajo/pull/421#issuecomment-89543503

          Ok. Here is my +1.
          If there are no objections, I'll commit.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/421#issuecomment-89543503 Ok. Here is my +1. If there are no objections, I'll commit.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user hys9958 reopened a pull request:

          https://github.com/apache/tajo/pull/421

          TAJO-1400: Add TajoStatement::setMaxRows method support

          I implemented the setMaxRows and getMaxRows method support.
          Please review my patch.

          thanks.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/hys9958/tajo TAJO-1400

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tajo/pull/421.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #421


          commit b1d30b577ab68f8beac85ed447094c464064e938
          Author: HANYOUNSU <hanyounsu@hanyounsuui-macbook-pro.local>
          Date: 2015-03-13T14:00:54Z

          TAJO-1400: Add TajoStatement::setMaxRows method support

          commit 75cc76ae3ae64a6415449eb6e4a22288467fd529
          Author: Yeonsu Han <hanyounsu@gmail.com>
          Date: 2015-03-28T06:32:08Z

          TAJO-1400: Add TajoStatement::setMaxRows method support(add unit test)

          commit 4e99550e15a84dac9ee9606eb735741b5c9626a2
          Author: Yeonsu Han <hanyounsu@gmail.com>
          Date: 2015-03-28T07:09:12Z

          TAJO-1400: Add TajoStatement::setMaxRows method support(add unit test)

          commit 6e22369e1db1c4e7562770a6721182170fe167a1
          Author: Yeonsu Han <hanyounsu@gmail.com>
          Date: 2015-03-30T05:48:33Z

          TAJO-1400: Add TajoStatement::setMaxRows method support(add unit test)


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user hys9958 reopened a pull request: https://github.com/apache/tajo/pull/421 TAJO-1400 : Add TajoStatement::setMaxRows method support I implemented the setMaxRows and getMaxRows method support. Please review my patch. thanks. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hys9958/tajo TAJO-1400 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/421.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #421 commit b1d30b577ab68f8beac85ed447094c464064e938 Author: HANYOUNSU <hanyounsu@hanyounsuui-macbook-pro.local> Date: 2015-03-13T14:00:54Z TAJO-1400 : Add TajoStatement::setMaxRows method support commit 75cc76ae3ae64a6415449eb6e4a22288467fd529 Author: Yeonsu Han <hanyounsu@gmail.com> Date: 2015-03-28T06:32:08Z TAJO-1400 : Add TajoStatement::setMaxRows method support(add unit test) commit 4e99550e15a84dac9ee9606eb735741b5c9626a2 Author: Yeonsu Han <hanyounsu@gmail.com> Date: 2015-03-28T07:09:12Z TAJO-1400 : Add TajoStatement::setMaxRows method support(add unit test) commit 6e22369e1db1c4e7562770a6721182170fe167a1 Author: Yeonsu Han <hanyounsu@gmail.com> Date: 2015-03-30T05:48:33Z TAJO-1400 : Add TajoStatement::setMaxRows method support(add unit test)
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hys9958 commented on the pull request:

          https://github.com/apache/tajo/pull/421#issuecomment-88016070

          Hi @jihoonson ,
          Query return value is 'java.sql.ResultSet' interfase in TajoStatement. It need to many refactoring.
          And i'll also another patch about getMoreResults. When the getMoreResults patch time, i update maxRows.

          Show
          githubbot ASF GitHub Bot added a comment - Github user hys9958 commented on the pull request: https://github.com/apache/tajo/pull/421#issuecomment-88016070 Hi @jihoonson , Query return value is 'java.sql.ResultSet' interfase in TajoStatement. It need to many refactoring. And i'll also another patch about getMoreResults. When the getMoreResults patch time, i update maxRows.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hys9958 closed the pull request at:

          https://github.com/apache/tajo/pull/421

          Show
          githubbot ASF GitHub Bot added a comment - Github user hys9958 closed the pull request at: https://github.com/apache/tajo/pull/421
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on the pull request:

          https://github.com/apache/tajo/pull/421#issuecomment-87582032

          @hys9958 thanks. I'll wait for the next patch.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/421#issuecomment-87582032 @hys9958 thanks. I'll wait for the next patch.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hys9958 commented on the pull request:

          https://github.com/apache/tajo/pull/421#issuecomment-87581798

          @jinossy Ok, It's better idea.
          I'll re-patch the implementation of maxRows().

          Show
          githubbot ASF GitHub Bot added a comment - Github user hys9958 commented on the pull request: https://github.com/apache/tajo/pull/421#issuecomment-87581798 @jinossy Ok, It's better idea. I'll re-patch the implementation of maxRows().
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on the pull request:

          https://github.com/apache/tajo/pull/421#issuecomment-87576081

          @jinossy thanks for the good suggestion.
          It would be a better implementation.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/421#issuecomment-87576081 @jinossy thanks for the good suggestion. It would be a better implementation.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jinossy commented on the pull request:

          https://github.com/apache/tajo/pull/421#issuecomment-87574590

          @hys9958
          How do you think that move the setMaxRows() to TajoStatement ?

          Show
          githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/421#issuecomment-87574590 @hys9958 How do you think that move the setMaxRows() to TajoStatement ?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on the pull request:

          https://github.com/apache/tajo/pull/421#issuecomment-87570820

          +1
          Thanks for your contribution!

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/421#issuecomment-87570820 +1 Thanks for your contribution!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hys9958 commented on the pull request:

          https://github.com/apache/tajo/pull/421#issuecomment-84359409

          Ok, jihoonson,
          I'll update the TestTajoJDBC for unit tests of this issue soon.

          Show
          githubbot ASF GitHub Bot added a comment - Github user hys9958 commented on the pull request: https://github.com/apache/tajo/pull/421#issuecomment-84359409 Ok, jihoonson, I'll update the TestTajoJDBC for unit tests of this issue soon.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jihoonson commented on the pull request:

          https://github.com/apache/tajo/pull/421#issuecomment-84292092

          Would you add some unit tests?
          TestTajoJDBC will be good to add tests.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/421#issuecomment-84292092 Would you add some unit tests? TestTajoJDBC will be good to add tests.
          Hide
          dongjoon Dongjoon Hyun added a comment - - edited

          Hi~
          Please close both issue together when closing.

          I linked TAJO-901 here.

          Show
          dongjoon Dongjoon Hyun added a comment - - edited Hi~ Please close both issue together when closing. I linked TAJO-901 here.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user blrunner commented on the pull request:

          https://github.com/apache/tajo/pull/421#issuecomment-82117286

          Thank you for your contribution.
          I'll review the patch today.

          Show
          githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/421#issuecomment-82117286 Thank you for your contribution. I'll review the patch today.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user hys9958 opened a pull request:

          https://github.com/apache/tajo/pull/421

          TAJO-1400: Add TajoStatement::setMaxRows method support

          I implemented the setMaxRows and getMaxRows method support.
          Please review my patch.

          thanks.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/hys9958/tajo TAJO-1400

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tajo/pull/421.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #421


          commit b1d30b577ab68f8beac85ed447094c464064e938
          Author: HANYOUNSU <hanyounsu@hanyounsuui-macbook-pro.local>
          Date: 2015-03-13T14:00:54Z

          TAJO-1400: Add TajoStatement::setMaxRows method support


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user hys9958 opened a pull request: https://github.com/apache/tajo/pull/421 TAJO-1400 : Add TajoStatement::setMaxRows method support I implemented the setMaxRows and getMaxRows method support. Please review my patch. thanks. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hys9958/tajo TAJO-1400 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/421.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #421 commit b1d30b577ab68f8beac85ed447094c464064e938 Author: HANYOUNSU <hanyounsu@hanyounsuui-macbook-pro.local> Date: 2015-03-13T14:00:54Z TAJO-1400 : Add TajoStatement::setMaxRows method support
          Hide
          hyunsik Hyunsik Choi added a comment -

          Sure, I've just assigned it to you.

          Show
          hyunsik Hyunsik Choi added a comment - Sure, I've just assigned it to you.
          Hide
          hys9958 YeonSu Han added a comment -

          May I handle this?

          Show
          hys9958 YeonSu Han added a comment - May I handle this?

            People

            • Assignee:
              hys9958 YeonSu Han
              Reporter:
              hyunsik Hyunsik Choi
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development