Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0, 0.10.1
    • Component/s: SQL Shell
    • Labels:
      None

      Description

      In development, we need restart tajo-master frequently. But then we should restart all tsql clients also, which is a little annoying.

      With the new option "--reconnect" for tsql, we can make our life easier, a little bit.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user navis opened a pull request:

        https://github.com/apache/tajo/pull/414

        TAJO-1394 Support reconnect on tsql

        Just reconnect on "invalid session" message and update session vars in local stash to server.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/navis/tajo TAJO-1394

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/414.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #414


        commit 8c0d33b92cad0c52858056b25a1c0631d2a9d985
        Author: navis.ryu <navis@apache.org>
        Date: 2015-03-12T01:57:53Z

        TAJO-1394 Support reconnect on tsql


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user navis opened a pull request: https://github.com/apache/tajo/pull/414 TAJO-1394 Support reconnect on tsql Just reconnect on "invalid session" message and update session vars in local stash to server. You can merge this pull request into a Git repository by running: $ git pull https://github.com/navis/tajo TAJO-1394 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/414.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #414 commit 8c0d33b92cad0c52858056b25a1c0631d2a9d985 Author: navis.ryu <navis@apache.org> Date: 2015-03-12T01:57:53Z TAJO-1394 Support reconnect on tsql
        Hide
        dongjoon Dongjoon Hyun added a comment -

        +1
        It sounds good to me!

        Show
        dongjoon Dongjoon Hyun added a comment - +1 It sounds good to me!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/414#issuecomment-78453921

        +1

        the patch looks good to me. I tested the patch in the case where TajoMaster is restarted. It works well. tsql reconnected to TajoMaster and got new session while keeping cached session variables.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/414#issuecomment-78453921 +1 the patch looks good to me. I tested the patch in the case where TajoMaster is restarted. It works well. tsql reconnected to TajoMaster and got new session while keeping cached session variables.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/414

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/414
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed.

        Show
        hyunsik Hyunsik Choi added a comment - committed.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/414#issuecomment-78455416

        I also verified 'mvn clean install'.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/414#issuecomment-78455416 I also verified 'mvn clean install'.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #610 (See https://builds.apache.org/job/Tajo-master-build/610/)
        TAJO-1394 Support reconnect on tsql. (hyunsik: rev 4a9da73c6cc6ff670f867c13d60dd951bf8190bc)

        • tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java
        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/TajoCli.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #610 (See https://builds.apache.org/job/Tajo-master-build/610/ ) TAJO-1394 Support reconnect on tsql. (hyunsik: rev 4a9da73c6cc6ff670f867c13d60dd951bf8190bc) tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java tajo-cli/src/main/java/org/apache/tajo/cli/tsql/TajoCli.java CHANGES
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #248 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/248/)
        TAJO-1394 Support reconnect on tsql. (hyunsik: rev 4a9da73c6cc6ff670f867c13d60dd951bf8190bc)

        • tajo-cli/src/main/java/org/apache/tajo/cli/tsql/TajoCli.java
        • CHANGES
        • tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #248 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/248/ ) TAJO-1394 Support reconnect on tsql. (hyunsik: rev 4a9da73c6cc6ff670f867c13d60dd951bf8190bc) tajo-cli/src/main/java/org/apache/tajo/cli/tsql/TajoCli.java CHANGES tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java

          People

          • Assignee:
            navis Navis
            Reporter:
            navis Navis
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development