Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1324

Remove warehouse directory rewriting in Unit Test

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.10.0
    • Fix Version/s: 0.10.0, 0.11.0
    • Component/s: Unit Test
    • Labels:
      None

      Description

      Some unit test case is rewrite the warehouse directory. but It is unnecessary operation and It affects the other test cases.

      Results :
      
      Failed tests: 
        TestCreateTable.testCreatedTableWithQuotedIdentifierAndVerifyPath:139->assertPathOfCreatedTable:111 expected:<hdfs://localhost:54973/tajo/warehouse/D6/OldTable> but was:<hdfs://localhost:54973/tajo/D6/OldTable>
        TestCreateTable.testCreatedTableJustCreatedAndVerifyPath:133->assertPathOfCreatedTable:111 expected:<hdfs://localhost:54973/tajo/warehouse/d5/old_table> but was:<hdfs://localhost:54973/tajo/d5/old_table>
      
      Tests run: 1341, Failures: 2, Errors: 0, Skipped: 0
      
      

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jinossy opened a pull request:

        https://github.com/apache/tajo/pull/370

        TAJO-1324: Remove warehouse directory rewriting in Unit Test

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jinossy/tajo TAJO-1324

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/370.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #370


        commit 9447e6c3dfcf809c0f3f8dee0b050dc02945e84b
        Author: jhkim <jhkim@apache.org>
        Date: 2015-02-02T14:01:23Z

        TAJO-1324: Remove warehouse directory rewriting in Unit Test


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/370 TAJO-1324 : Remove warehouse directory rewriting in Unit Test You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-1324 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/370.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #370 commit 9447e6c3dfcf809c0f3f8dee0b050dc02945e84b Author: jhkim <jhkim@apache.org> Date: 2015-02-02T14:01:23Z TAJO-1324 : Remove warehouse directory rewriting in Unit Test
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/370#issuecomment-72583559

        I’ve decrease the travis parallel forks to 2. because jvm terminated
        ```
        [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.17:test (default-test) on project tajo-core: ExecutionException: java.lang.RuntimeException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
        ```

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/370#issuecomment-72583559 I’ve decrease the travis parallel forks to 2. because jvm terminated ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.17:test (default-test) on project tajo-core: ExecutionException: java.lang.RuntimeException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called? ```
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/370#issuecomment-72583775

        The latest travis failure is network issue
        ```
        [ERROR] Failed to execute goal on project tajo-catalog-server: Could not resolve dependencies for project org.apache.tajo:tajo-catalog-server:jar:0.10.0-SNAPSHOT: Could not transfer artifact org.apache.derby:derby:jar:10.8.2.2 from/to central (http://repo.maven.apache.org/maven2): GET request of: org/apache/derby/derby/10.8.2.2/derby-10.8.2.2.jar from central failed: Connection reset -> [Help 1]
        ```

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/370#issuecomment-72583775 The latest travis failure is network issue ``` [ERROR] Failed to execute goal on project tajo-catalog-server: Could not resolve dependencies for project org.apache.tajo:tajo-catalog-server:jar:0.10.0-SNAPSHOT: Could not transfer artifact org.apache.derby:derby:jar:10.8.2.2 from/to central ( http://repo.maven.apache.org/maven2): GET request of: org/apache/derby/derby/10.8.2.2/derby-10.8.2.2.jar from central failed: Connection reset -> [Help 1] ```
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/370#issuecomment-72598551

        +1 LGTM!

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/370#issuecomment-72598551 +1 LGTM!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/370

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/370
        Hide
        jhkim Jinho Kim added a comment -

        committed it.
        Thank you for the review

        Show
        jhkim Jinho Kim added a comment - committed it. Thank you for the review
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-CODEGEN-build #214 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/214/)
        TAJO-1324: Remove warehouse directory rewriting in Unit Test. (jinho) (jhkim: rev 9ad117f07b30874685e58e28b76f8d0a2650b0f5)

        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestFullOuterMergeJoinExec.java
        • tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/HashShuffleAppenderManager.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestMergeJoinExec.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestMergeScanner.java
        • tajo-core/src/test/java/org/apache/tajo/storage/TestRowFile.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestRightOuterMergeJoinExec.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestBSTIndexExec.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestSortExec.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestFullOuterHashJoinExec.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestFileStorageManager.java
        • tajo-core/src/test/java/org/apache/tajo/LocalTajoTestingUtility.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestProgressExternalSortExec.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestExternalSortExec.java
        • tajo-core/src/test/java/org/apache/tajo/BackendTestingUtil.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestHashSemiJoinExec.java
        • tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestHashJoinExec.java
        • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/StorageManager.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestBNLJoinExec.java
        • .travis.yml
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestLeftOuterNLJoinExec.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestLeftOuterHashJoinExec.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestRightOuterHashJoinExec.java
        • CHANGES
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestNLJoinExec.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestHashAntiJoinExec.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-CODEGEN-build #214 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/214/ ) TAJO-1324 : Remove warehouse directory rewriting in Unit Test. (jinho) (jhkim: rev 9ad117f07b30874685e58e28b76f8d0a2650b0f5) tajo-core/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestFullOuterMergeJoinExec.java tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/HashShuffleAppenderManager.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestMergeJoinExec.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestMergeScanner.java tajo-core/src/test/java/org/apache/tajo/storage/TestRowFile.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestRightOuterMergeJoinExec.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestBSTIndexExec.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestSortExec.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestFullOuterHashJoinExec.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestFileStorageManager.java tajo-core/src/test/java/org/apache/tajo/LocalTajoTestingUtility.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestProgressExternalSortExec.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestExternalSortExec.java tajo-core/src/test/java/org/apache/tajo/BackendTestingUtil.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestHashSemiJoinExec.java tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestHashJoinExec.java tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/StorageManager.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestBNLJoinExec.java .travis.yml tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestLeftOuterNLJoinExec.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestLeftOuterHashJoinExec.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestRightOuterHashJoinExec.java CHANGES tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestNLJoinExec.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestHashAntiJoinExec.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #575 (See https://builds.apache.org/job/Tajo-master-build/575/)
        TAJO-1324: Remove warehouse directory rewriting in Unit Test. (jinho) (jhkim: rev 9ad117f07b30874685e58e28b76f8d0a2650b0f5)

        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestLeftOuterNLJoinExec.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestLeftOuterHashJoinExec.java
        • tajo-core/src/test/java/org/apache/tajo/LocalTajoTestingUtility.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestProgressExternalSortExec.java
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestBSTIndexExec.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestHashJoinExec.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestMergeJoinExec.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestHashSemiJoinExec.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestNLJoinExec.java
        • tajo-core/src/test/java/org/apache/tajo/storage/TestRowFile.java
        • tajo-core/src/test/java/org/apache/tajo/BackendTestingUtil.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestExternalSortExec.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestRightOuterHashJoinExec.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestSortExec.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestBNLJoinExec.java
        • CHANGES
        • tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestFullOuterHashJoinExec.java
        • tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/StorageManager.java
        • .travis.yml
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestFullOuterMergeJoinExec.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestMergeScanner.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestRightOuterMergeJoinExec.java
        • tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/HashShuffleAppenderManager.java
        • tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
        • tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestFileStorageManager.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestHashAntiJoinExec.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #575 (See https://builds.apache.org/job/Tajo-master-build/575/ ) TAJO-1324 : Remove warehouse directory rewriting in Unit Test. (jinho) (jhkim: rev 9ad117f07b30874685e58e28b76f8d0a2650b0f5) tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestLeftOuterNLJoinExec.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestLeftOuterHashJoinExec.java tajo-core/src/test/java/org/apache/tajo/LocalTajoTestingUtility.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestProgressExternalSortExec.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestBSTIndexExec.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestHashJoinExec.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestMergeJoinExec.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestHashSemiJoinExec.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestNLJoinExec.java tajo-core/src/test/java/org/apache/tajo/storage/TestRowFile.java tajo-core/src/test/java/org/apache/tajo/BackendTestingUtil.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestExternalSortExec.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestRightOuterHashJoinExec.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestSortExec.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestBNLJoinExec.java CHANGES tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestFullOuterHashJoinExec.java tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/StorageManager.java .travis.yml tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestFullOuterMergeJoinExec.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestMergeScanner.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestRightOuterMergeJoinExec.java tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/HashShuffleAppenderManager.java tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestFileStorageManager.java tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestHashAntiJoinExec.java

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development