[TAJO-1287] Repeated using of the same order by key in multiple window clauses should be supported

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: window function, 0.10.0
• Component/s: distributed query plan, Physical Operator, Planner/Optimizer, SQL Parser
• Assignee: Keuntae Park
• Reporter: Keuntae Park
• Created: 08/Jan/15 07:29
• Updated: 09/Jan/15 06:44
• Resolved: 09/Jan/15 06:26

Description

Following test code does not pass:

  public final void testMultipleWindow() throws Exception {
    KeyValueSet tableOptions = new KeyValueSet();
    tableOptions.set(StorageConstants.TEXT_DELIMITER, StorageConstants.DEFAULT_FIELD_DELIMITER);
    tableOptions.set(StorageConstants.TEXT_NULL, "\\\\N");

    Schema schema = new Schema();
    schema.addColumn("id", TajoDataTypes.Type.INT4);
    schema.addColumn("time", TajoDataTypes.Type.TIME);
    schema.addColumn("name", TajoDataTypes.Type.TEXT);
    String[] data = new String[]{ "1|12:11:12|abc", "2|10:11:13|def", "2|05:42:41|ghi" };
    TajoTestingCluster.createTable("multiwindow", schema, tableOptions, data, 1);

    try {
      ResultSet res = executeString(
          "select id, last_value(time) over ( partition by id order by time ) as time_last, last_value(name) over ( partition by id order by time ) as name_last from multiwindow");
      String ascExpected = "id,time_last, name_last\n" +
          "-------------------------------\n" +
          "1,12:11:12,abc\n" +
          "2,10:11:13,def\n" +
          "2,10:11:13,def\n";

      assertEquals(ascExpected, resultSetToString(res));
      res.close();
    } finally {
      executeString("DROP TABLE multiwindow PURGE");
    }
  }

because the same order by key(in this case, 'time') induces Exception:
"org.apache.tajo.catalog.exception.AlreadyExistsFieldException: Already Exists Field: default.multiwindow.time"

It looks like there is a trivial bug when inserting additionalSortKeyColumns in WindowAggExec.